From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FDE4C43603 for ; Tue, 10 Dec 2019 20:49:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E7692073B for ; Tue, 10 Dec 2019 20:49:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfLJUtL convert rfc822-to-8bit (ORCPT ); Tue, 10 Dec 2019 15:49:11 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:41808 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbfLJUtL (ORCPT ); Tue, 10 Dec 2019 15:49:11 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iemRD-0001LA-IR; Tue, 10 Dec 2019 21:48:55 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 8BB1A101DEC; Tue, 10 Dec 2019 21:48:54 +0100 (CET) From: Thomas Gleixner To: Greg KH , Thomas Renninger Cc: linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org, fschnitzlein@suse.de, Felix Schnizlein , Thomas Renninger Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 In-Reply-To: <20191206163656.GC86904@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> <20191206163656.GC86904@kroah.com> Date: Tue, 10 Dec 2019 21:48:54 +0100 Message-ID: <87sglroqix.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Fri, Dec 06, 2019 at 05:24:20PM +0100, Thomas Renninger wrote: >> From: Felix Schnizlein >> ==> flags <== >> fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm cpuid_fault invpcid_single pti ssbd ibrs ibpb fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt arat umip > > One file with all of that? We are going to run into problems > eventually, that should be split up. > > Just like bugs, that's going to just grow over time and eventually > overflow PAGE_SIZE :( > > Make this: > ├── flags > │   ├── fpu > │   ├── vme > ... > > Much simpler to parse, right? Well, I'm not really sure whether 100+ files are simpler to parse. Aside of that I really don't see the value for 100+ files per CPU which are just returning 1 or True or whatever as long as you are not suggesting to provide real feature files which have 0/1 or True/False content. But I still don't get the whole thing. The only "argument" I've seen so far is the 'proc moves to sys' mantra, but that does not make it any better. We won't get rid of /proc/cpuinfo for a very long time simply because too much userspace uses it. Introducing a mess in /sys/ in parallel just for following the mantra does not help much. Also IF we ever expose feature flags in sys then this needs to be a split ino cpu/common_features and cpu/CPU$N/unique_features On most systems unique_features wont exist, but there is such stuff on the horizon. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED7AC43603 for ; Tue, 10 Dec 2019 20:49:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 901702073B for ; Tue, 10 Dec 2019 20:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UGpDXWoE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 901702073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ZpCRCASSG0V81xIi23+HHNSBZbMSvh9021YpHjRjXk=; b=UGpDXWoEPUgRIZ 3JglP6rgP1wIHtOwseAujeEGYGAp4V1j/eZLlo1HiNU/U4hwUJFOg1swBSb/Xv0RTdHy7EaNPYbrr 7zRmgu2vHEGtOzPOHgE0tca1h7w0TzZtGiIyXvBG+Eff68fsSyr1zrn31jTXXeGiwjk74jydXqOX1 TFTzLlVUTrM2cJ+khAH5mnL/xNJfsp/INjK1f4IZi3n10TRb5xVBWLEQOpsgpN2mN/wUnqsi6oFCn 08avdxwgAsHx+UDRNl1Ffr/ZYh784LyPyh/URKOja3xhf8CVEx9hs2kDJUs9bdFjFhaqap+uk7QDo ip9C0gjTSZFTP6sBxuYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemRS-0000uq-Lx; Tue, 10 Dec 2019 20:49:10 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemRO-0000uS-GF for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 20:49:08 +0000 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iemRD-0001LA-IR; Tue, 10 Dec 2019 21:48:55 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 8BB1A101DEC; Tue, 10 Dec 2019 21:48:54 +0100 (CET) From: Thomas Gleixner To: Greg KH , Thomas Renninger Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 In-Reply-To: <20191206163656.GC86904@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> <20191206163656.GC86904@kroah.com> Date: Tue, 10 Dec 2019 21:48:54 +0100 Message-ID: <87sglroqix.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_124906_680810_F737E276 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Felix Schnizlein , Felix Schnizlein , x86@kernel.org, will.deacon@arm.com, linux@armlinux.org.uk, Thomas Renninger , linux-kernel@vger.kernel.org, fschnitzlein@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org R3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyaXRlczoKPiBPbiBGcmksIERl YyAwNiwgMjAxOSBhdCAwNToyNDoyMFBNICswMTAwLCBUaG9tYXMgUmVubmluZ2VyIHdyb3RlOgo+ PiBGcm9tOiBGZWxpeCBTY2huaXpsZWluIDxmc2Nobml6bGVpbkBzdXNlLmRlPgo+PiA9PT4gZmxh Z3MgPD09Cj4+IGZwdSB2bWUgZGUgcHNlIHRzYyBtc3IgcGFlIG1jZSBjeDggYXBpYyBzZXAgbXRy ciBwZ2UgbWNhIGNtb3YgcGF0IHBzZTM2IGNsZmx1c2ggbW14IGZ4c3Igc3NlIHNzZTIgc3Mgc3lz Y2FsbCBueCBwZHBlMWdiIHJkdHNjcCBsbSBjb25zdGFudF90c2MgcmVwX2dvb2Qgbm9wbCB4dG9w b2xvZ3kgY3B1aWQgdHNjX2tub3duX2ZyZXEgcG5pIHBjbG11bHFkcSBzc3NlMyBmbWEgY3gxNiBw Y2lkIHNzZTRfMSBzc2U0XzIgeDJhcGljIG1vdmJlIHBvcGNudCB0c2NfZGVhZGxpbmVfdGltZXIg YWVzIHhzYXZlIGF2eCBmMTZjIHJkcmFuZCBoeXBlcnZpc29yIGxhaGZfbG0gYWJtIGNwdWlkX2Zh dWx0IGludnBjaWRfc2luZ2xlIHB0aSBzc2JkIGlicnMgaWJwYiBmc2dzYmFzZSB0c2NfYWRqdXN0 IGJtaTEgYXZ4MiBzbWVwIGJtaTIgZXJtcyBpbnZwY2lkIHhzYXZlb3B0IGFyYXQgdW1pcAo+Cj4g T25lIGZpbGUgd2l0aCBhbGwgb2YgdGhhdD8gIFdlIGFyZSBnb2luZyB0byBydW4gaW50byBwcm9i bGVtcwo+IGV2ZW50dWFsbHksIHRoYXQgc2hvdWxkIGJlIHNwbGl0IHVwLgo+Cj4gSnVzdCBsaWtl IGJ1Z3MsIHRoYXQncyBnb2luZyB0byBqdXN0IGdyb3cgb3ZlciB0aW1lIGFuZCBldmVudHVhbGx5 Cj4gb3ZlcmZsb3cgUEFHRV9TSVpFIDooCj4KPiBNYWtlIHRoaXM6Cj4gICDilJzilIDilIAgZmxh Z3MKPiAgIOKUgsKgwqAg4pSc4pSA4pSAIGZwdQo+ICAg4pSCwqDCoCDilJzilIDilIAgdm1lCj4g Li4uCj4KPiBNdWNoIHNpbXBsZXIgdG8gcGFyc2UsIHJpZ2h0PwoKV2VsbCwgSSdtIG5vdCByZWFs bHkgc3VyZSB3aGV0aGVyIDEwMCsgZmlsZXMgYXJlIHNpbXBsZXIgdG8gcGFyc2UuCgpBc2lkZSBv ZiB0aGF0IEkgcmVhbGx5IGRvbid0IHNlZSB0aGUgdmFsdWUgZm9yIDEwMCsgZmlsZXMgcGVyIENQ VSB3aGljaAphcmUganVzdCByZXR1cm5pbmcgMSBvciBUcnVlIG9yIHdoYXRldmVyIGFzIGxvbmcg YXMgeW91IGFyZSBub3QKc3VnZ2VzdGluZyB0byBwcm92aWRlIHJlYWwgZmVhdHVyZSBmaWxlcyB3 aGljaCBoYXZlIDAvMSBvciBUcnVlL0ZhbHNlCmNvbnRlbnQuCgpCdXQgSSBzdGlsbCBkb24ndCBn ZXQgdGhlIHdob2xlIHRoaW5nLiBUaGUgb25seSAiYXJndW1lbnQiIEkndmUgc2VlbiBzbwpmYXIg aXMgdGhlICdwcm9jIG1vdmVzIHRvIHN5cycgbWFudHJhLCBidXQgdGhhdCBkb2VzIG5vdCBtYWtl IGl0IGFueQpiZXR0ZXIuCgpXZSB3b24ndCBnZXQgcmlkIG9mIC9wcm9jL2NwdWluZm8gZm9yIGEg dmVyeSBsb25nIHRpbWUgc2ltcGx5IGJlY2F1c2UKdG9vIG11Y2ggdXNlcnNwYWNlIHVzZXMgaXQu IEludHJvZHVjaW5nIGEgbWVzcyBpbiAvc3lzLyBpbiBwYXJhbGxlbCBqdXN0CmZvciBmb2xsb3dp bmcgdGhlIG1hbnRyYSBkb2VzIG5vdCBoZWxwIG11Y2guCgpBbHNvIElGIHdlIGV2ZXIgZXhwb3Nl IGZlYXR1cmUgZmxhZ3MgaW4gc3lzIHRoZW4gdGhpcyBuZWVkcyB0byBiZSBhCnNwbGl0IGlubwoK ICBjcHUvY29tbW9uX2ZlYXR1cmVzCgphbmQKCiAgY3B1L0NQVSROL3VuaXF1ZV9mZWF0dXJlcwoK T24gbW9zdCBzeXN0ZW1zIHVuaXF1ZV9mZWF0dXJlcyB3b250IGV4aXN0LCBidXQgdGhlcmUgaXMg c3VjaCBzdHVmZiBvbgp0aGUgaG9yaXpvbi4KClRoYW5rcywKCiAgICAgICAgdGdseAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=