From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/i915/selftests: Prevent the timeslice expiring during suppression tests
Date: Mon, 12 Aug 2019 13:28:39 +0300 [thread overview]
Message-ID: <87sgq67k4o.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <156560393718.2301.11983694987791177055@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-08-12 10:39:01)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > When testing whether we prevent suppressing preemption, it helps to
>> > avoid a time slice expiring prematurely.
>> >
>>
>> I did look the test and it does call schedule on it's own.
>>
>> So what we want to do is to postpone the defacto schedule tick
>> provided by driver not to mess our own schedule? (which we
>> use to check that no preemption does occur with equal
>> priorities?)
>
> The test is trying to look at our mechanics to ensure that we don't
> cause preemptions where we simply put back the same request. As such, we
> have a marker in the preemption code that we are trying to avoid, and
> must control the scheduling to exclude all other events than the one we
> are injecting.
>
> The timeslice could expire and reverse A,B (to B,A) such that our
> promotion of A does (correctly) cause a preemption that we expect never
> to need.
If there will be more users, then we can consider
disable|enable_reschedule_timer or similar.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-12 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 9:10 [PATCH 1/8] drm/i915/execlists: Avoid sync calls during park Chris Wilson
2019-08-12 9:10 ` [PATCH 2/8] drm/i915/selftests: Prevent the timeslice expiring during suppression tests Chris Wilson
2019-08-12 9:39 ` Mika Kuoppala
2019-08-12 9:58 ` Chris Wilson
2019-08-12 10:28 ` Mika Kuoppala [this message]
2019-08-12 9:10 ` [PATCH 3/8] drm/i915/guc: Use a local cancel_port_requests Chris Wilson
2019-08-12 9:10 ` [PATCH 4/8] drm/i915: Push the wakeref->count deferral to the backend Chris Wilson
2019-08-12 9:10 ` [PATCH 5/8] drm/i915/gt: Save/restore interrupts around breadcrumb disable Chris Wilson
2019-08-12 9:10 ` [PATCH 6/8] drm/i915/guc: Keep the engine awake until the tasklet is idle Chris Wilson
2019-08-12 10:44 ` Chris Wilson
2019-08-12 20:38 ` Daniele Ceraolo Spurio
2019-08-12 20:42 ` Chris Wilson
2019-08-12 9:10 ` [PATCH 7/8] drm/i915/gt: Use the local engine wakeref when checking RING registers Chris Wilson
2019-08-12 12:16 ` Mika Kuoppala
2019-08-12 9:10 ` [PATCH 8/8] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock Chris Wilson
2019-08-12 11:13 ` [PATCH] " Chris Wilson
2019-08-12 15:29 ` kbuild test robot
2019-08-12 9:27 ` [PATCH 1/8] drm/i915/execlists: Avoid sync calls during park Mika Kuoppala
2019-08-12 9:33 ` Chris Wilson
2019-08-12 9:40 ` Mika Kuoppala
2019-08-12 12:54 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915/execlists: Avoid sync calls during park (rev2) Patchwork
2019-08-12 12:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-08-12 13:22 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-12 19:21 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgq67k4o.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.