From mboxrd@z Thu Jan 1 00:00:00 1970 From: NeilBrown Date: Mon, 26 Nov 2018 14:00:59 +1100 Subject: [lustre-devel] [PATCH 4/9] lustre: rename: DNE2 should return -EXDEV upon remote rename In-Reply-To: References: <154295730810.2850.961218355189474016.stgit@noble> <154295732797.2850.16990175697450002727.stgit@noble> Message-ID: <87sgzor190.fsf@notabene.neil.brown.name> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org On Mon, Nov 26 2018, James Simmons wrote: > On Fri, 23 Nov 2018, NeilBrown wrote: > >> From: Lai Siyao >> >> DNE2 MDS should return -EXDEV upon remote rename, so that old >> client can do rename with copy and delete, instead of fail >> with -EREMOTE. > > Let me guess you were debugging the migration failures and fould this :-) > I was doing the same thing. Nope - I was just looking though all the missing patches to see if anything was relevant. :-) Thanks for all the "Reviewed-by"s ! NeilBrown > > Reviewed-by: James Simmons > >> Signed-off-by: Lai Siyao >> Change-Id: I68e8e99259065922f31bee5343be309380715674 >> WC-bug-id: https://jira.whamcloud.com/browse/LU-6660 >> Reviewed-on: http://review.whamcloud.com/15323 >> Reviewed-by: Andreas Dilger >> Reviewed-by: wangdi >> Reviewed-by: Fan Yong >> Signed-off-by: NeilBrown >> --- >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> index 32bb9fca88c9..7e4ffeb15a63 100644 >> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data, >> } >> >> rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request); >> - if (rc && rc != -EREMOTE) >> + if (rc && rc != -EXDEV) >> return rc; >> >> body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY); >> >> >> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: