Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

From: ebiederm@xmission.com (Eric W. Biederman)
To: Pavel Emelyanov <xemul@virtuozzo.com>
Cc: Adrian Reber <adrian@lisas.de>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrei Vagin <avagin@virtuozzo.com>,
	Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Kees Cook <keescook@chromium.org>,
	Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE
Date: Fri, 13 Jul 2018 08:46:25 -0500	[thread overview]
Message-ID: <87sh4nz1se.fsf@xmission.com> (raw)
In-Reply-To: <23f87cb4-cdf5-0f9c-c7b9-a0abb228b77f@virtuozzo.com> (Pavel Emelyanov's message of "Fri, 13 Jul 2018 11:35:50 +0300")

Pavel Emelyanov <xemul@virtuozzo.com> writes:

> On 07/12/2018 07:33 PM, Eric W. Biederman wrote:
>> 
>> Adrian Reber <adrian@lisas.de> writes:
>> 
>>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and
>>> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many
>>> distribution kernels and also part of the defconfigs of various
>>> architectures.
>>>
>>> To make it easier for distributions to enable CHECKPOINT_RESTORE this
>>> removes EXPERT and moves the configuration option out of the EXPERT
>>> block.
>> 
>> I think we should change the help text at the same time, to match
>> our improve understanding of the situation.
>> 
>> Does anyone remember why this option was added at all?
>
> Sure! Quoting Andrew's ~7 years ago akpm branch merge e-mail:
>
>    However I'm less confident than the developers that it will all
>    eventually work! So what I'm asking them to do is to wrap each piece
>    of new code inside CONFIG_CHECKPOINT_RESTORE.  So if it all
>    eventually comes to tears and the project as a whole fails, it should
>    be a simple matter to go through and delete all trace of it.
>
> the best link with full e-mail I googled for is
> https://gitlab.imag.fr/kaunetem/linux-kaunetem/commit/099469502f62fbe0d7e4f0b83a2f22538367f734

Good explanation.  Thank you.

At this point we even have not CRIU users of some of the pieces.
The project as a whole has not failed.

The code is old enough an common enough (enabled in some distros) that
we need to do the whole watch out for regressions if we remove any part
of it.

Which is a long way of saying the original justifiction for
CONFIG_CHECKPOINT_RESTORE is gone.  So please let's remove the entire
config option and simplify everyone's lives who has to test this stuff.

Unless someone can come up with a justification for keeping some of this
behind a config option.

Eric