From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 04/17] drm/i915: Wrap around the tail offset before setting ring->tail Date: Mon, 11 Jun 2018 13:16:14 +0300 Message-ID: <87sh5twrv5.fsf@gaia.fi.intel.com> References: <20180610194325.13467-1-chris@chris-wilson.co.uk> <20180610194325.13467-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 786A26E09F for ; Mon, 11 Jun 2018 10:16:42 +0000 (UTC) In-Reply-To: <20180610194325.13467-5-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVGhlIEhX IG9ubHkgYWNjZXB0cyBvZmZzZXRzIHdpdGhpbiByaW5nLT5zaXplLCBhbmQgZmFpbHMgcGVjdWxp YXJseSBpZgo+IHRoZSBSSU5HX0hFQUQgb3IgUklOR19UQUlMIGlzIHNldCB0byByaW5nLT5zaXpl LiBUaGVyZWZvcmUgd2hlbmV2ZXIgd2UKPiBzZXQgcmluZy0+aGVhZC9yaW5nLT50YWlsIHdlIHdh bnQgdG8gbWFrZSBzdXJlIGl0IGlzIHdpdGhpbiB2YWx1ZSAodXNpbmcKPiBpbnRlbF9yaW5nX3dy YXAoKSkuCj4KPiB2MjogRG91YmxlIGNoZWNrIGV4ZWNsaXN0cyBhcyB3ZWxsCj4KPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBNaWth IEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF0dGhldyBB dWxkIDxtYXR0aGV3LndpbGxpYW0uYXVsZEBnbWFpbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jICAgICAgICB8ICA2ICsrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmMgfCAgNSArKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmggfCAxMiArKysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMSBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK PiBpbmRleCAwOTFlMjhmMGUwMjQuLjNlMDA4YWRmNWEwMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5jCj4gQEAgLTE0MTMsNiArMTQxMyw3IEBAIF9fZXhlY2xpc3RzX2NvbnRleHRfcGlu KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCWNlLT5scmNfcmVnX3N0YXRlID0g dmFkZHIgKyBMUkNfU1RBVEVfUE4gKiBQQUdFX1NJWkU7Cj4gIAljZS0+bHJjX3JlZ19zdGF0ZVtD VFhfUklOR19CVUZGRVJfU1RBUlQrMV0gPQo+ICAJCWk5MTVfZ2d0dF9vZmZzZXQoY2UtPnJpbmct PnZtYSk7Cj4gKwlHRU1fQlVHX09OKCFpbnRlbF9yaW5nX29mZnNldF92YWxpZChjZS0+cmluZywg Y2UtPnJpbmctPmhlYWQpKTsKPiAgCWNlLT5scmNfcmVnX3N0YXRlW0NUWF9SSU5HX0hFQUQrMV0g PSBjZS0+cmluZy0+aGVhZDsKPiAgCj4gIAljZS0+c3RhdGUtPm9iai0+cGluX2dsb2JhbCsrOwo+ IEBAIC0yMDAxLDkgKzIwMDIsMTAgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX3Jlc2V0KHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCj4gIAkvKiBNb3ZlIHRoZSBSSU5HX0hFQUQg b250byB0aGUgYnJlYWRjcnVtYiwgcGFzdCB0aGUgaGFuZ2luZyBiYXRjaCAqLwo+ICAJcmVnc1tD VFhfUklOR19CVUZGRVJfU1RBUlQgKyAxXSA9IGk5MTVfZ2d0dF9vZmZzZXQocmVxdWVzdC0+cmlu Zy0+dm1hKTsKPiAtCXJlZ3NbQ1RYX1JJTkdfSEVBRCArIDFdID0gcmVxdWVzdC0+cG9zdGZpeDsK PiAgCj4gLQlyZXF1ZXN0LT5yaW5nLT5oZWFkID0gcmVxdWVzdC0+cG9zdGZpeDsKPiArCXJlcXVl c3QtPnJpbmctPmhlYWQgPSBpbnRlbF9yaW5nX3dyYXAocmVxdWVzdC0+cmluZywgcmVxdWVzdC0+ cG9zdGZpeCk7Cj4gKwlyZWdzW0NUWF9SSU5HX0hFQUQgKyAxXSA9IHJlcXVlc3QtPnJpbmctPmhl YWQ7Cj4gKwo+ICAJaW50ZWxfcmluZ191cGRhdGVfc3BhY2UocmVxdWVzdC0+cmluZyk7Cj4gIAo+ ICAJLyogUmVzZXQgV2FJZGxlTGl0ZVJlc3RvcmU6YmR3LHNrbCBhcyB3ZWxsICovCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDQwOWY0OTljMGE0NS4uNzk3 MGVjYjE5OWUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ IEBAIC00OTYsNiArNDk2LDEwIEBAIHN0YXRpYyBpbnQgaW5pdF9yaW5nX2NvbW1vbihzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJRFJNX0RFQlVHX0RSSVZFUigiJXMgaW5pdGlh bGl6YXRpb24gZmFpbGVkIFtoZWFkPSUwOHhdLCBmdWRnaW5nXG4iLAo+ICAJCQkJIGVuZ2luZS0+ bmFtZSwgSTkxNV9SRUFEX0hFQUQoZW5naW5lKSk7Cj4gIAo+ICsJLyogQ2hlY2sgdGhhdCB0aGUg cmluZyBvZmZzZXRzIHBvaW50IHdpdGhpbiB0aGUgcmluZyEgKi8KPiArCUdFTV9CVUdfT04oIWlu dGVsX3Jpbmdfb2Zmc2V0X3ZhbGlkKHJpbmcsIHJpbmctPmhlYWQpKTsKPiArCUdFTV9CVUdfT04o IWludGVsX3Jpbmdfb2Zmc2V0X3ZhbGlkKHJpbmcsIHJpbmctPnRhaWwpKTsKPiArCj4gIAlpbnRl bF9yaW5nX3VwZGF0ZV9zcGFjZShyaW5nKTsKPiAgCUk5MTVfV1JJVEVfSEVBRChlbmdpbmUsIHJp bmctPmhlYWQpOwo+ICAJSTkxNV9XUklURV9UQUlMKGVuZ2luZSwgcmluZy0+dGFpbCk7Cj4gQEAg LTEwNjQsNiArMTA2OCw3IEBAIGludCBpbnRlbF9yaW5nX3BpbihzdHJ1Y3QgaW50ZWxfcmluZyAq cmluZywKPiAgCj4gIHZvaWQgaW50ZWxfcmluZ19yZXNldChzdHJ1Y3QgaW50ZWxfcmluZyAqcmlu ZywgdTMyIHRhaWwpCj4gIHsKPiArCXRhaWwgPSBpbnRlbF9yaW5nX3dyYXAocmluZywgdGFpbCk7 CgpJIGFtIHBvbmRlcmluZyB0aGlzIHdyYXAgaGVyZSBhbmQgaXQncyB1c2VmdWxuZXNzLiBXaGVy ZQpjb3VsZCB3ZSBldmVyIGdldCBhIHRhaWwgd2hpY2ggaXMgbm90IHZhbGlkPyBGcm9tIGNvcnJ1 cHRlZApjb250ZXh0PwoKLU1pa2EKCgo+ICAJcmluZy0+dGFpbCA9IHRhaWw7Cj4gIAlyaW5nLT5o ZWFkID0gdGFpbDsKPiAgCXJpbmctPmVtaXQgPSB0YWlsOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCBiNDRjNjc4NDk3NDkuLjFkODE0MGFjMjAxNiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtODA1LDYgKzgw NSwxOCBAQCBzdGF0aWMgaW5saW5lIHUzMiBpbnRlbF9yaW5nX3dyYXAoY29uc3Qgc3RydWN0IGlu dGVsX3JpbmcgKnJpbmcsIHUzMiBwb3MpCj4gIAlyZXR1cm4gcG9zICYgKHJpbmctPnNpemUgLSAx KTsKPiAgfQo+ICAKPiArc3RhdGljIGlubGluZSBib29sCj4gK2ludGVsX3Jpbmdfb2Zmc2V0X3Zh bGlkKGNvbnN0IHN0cnVjdCBpbnRlbF9yaW5nICpyaW5nLCB1MzIgcG9zKQo+ICt7Cj4gKwlpZiAo cG9zICYgLXJpbmctPnNpemUpIC8qIG11c3QgYmUgc3RyaWN0bHkgd2l0aGluIHRoZSByaW5nICov Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCWlmICghSVNfQUxJR05FRChwb3MsIDgpKSAvKiBt dXN0IGJlIHF3b3JkIGFsaWduZWQgKi8KPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJcmV0dXJu IHRydWU7Cj4gK30KPiArCj4gIHN0YXRpYyBpbmxpbmUgdTMyIGludGVsX3Jpbmdfb2Zmc2V0KGNv bnN0IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCB2b2lkICphZGRyKQo+ICB7Cj4gIAkvKiBEb24n dCB3cml0ZSByaW5nLT5zaXplIChlcXVpdmFsZW50IHRvIDApIGFzIHRoYXQgaGFuZ3Mgc29tZSBH UFVzLiAqLwo+IC0tIAo+IDIuMTcuMQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK