From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need Date: Sat, 21 Apr 2018 21:32:11 +0200 Message-ID: <87sh7oxsn8.fsf@belgarion.home> References: <20180402142656.26815-1-robert.jarzmik@free.fr> <20180402142656.26815-11-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180402142656.26815-11-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 2 Apr 2018 16:26:51 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org List-Id: linux-ide@vger.kernel.org Robert Jarzmik writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more > generic function dma_request_slave_channel(). > > Signed-off-by: Robert Jarzmik Bartlomiej, could I have your ack please ? Cheers. -- Robert PS: The submitted patch > --- > drivers/ata/pata_pxa.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c > index f6c46e9a4dc0..e8b6a2e464c9 100644 > --- a/drivers/ata/pata_pxa.c > +++ b/drivers/ata/pata_pxa.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -180,8 +179,6 @@ static int pxa_ata_probe(struct platform_device *pdev) > struct resource *irq_res; > struct pata_pxa_pdata *pdata = dev_get_platdata(&pdev->dev); > struct dma_slave_config config; > - dma_cap_mask_t mask; > - struct pxad_param param; > int ret = 0; > > /* > @@ -278,10 +275,6 @@ static int pxa_ata_probe(struct platform_device *pdev) > > ap->private_data = data; > > - dma_cap_zero(mask); > - dma_cap_set(DMA_SLAVE, mask); > - param.prio = PXAD_PRIO_LOWEST; > - param.drcmr = pdata->dma_dreq; > memset(&config, 0, sizeof(config)); > config.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; > config.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; > @@ -294,8 +287,7 @@ static int pxa_ata_probe(struct platform_device *pdev) > * Request the DMA channel > */ > data->dma_chan = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶m, &pdev->dev, "data"); > + dma_request_slave_channel(&pdev->dev, "data"); > if (!data->dma_chan) > return -EBUSY; > ret = dmaengine_slave_config(data->dma_chan, &config); From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Sat, 21 Apr 2018 21:32:11 +0200 Subject: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need In-Reply-To: <20180402142656.26815-11-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 2 Apr 2018 16:26:51 +0200") References: <20180402142656.26815-1-robert.jarzmik@free.fr> <20180402142656.26815-11-robert.jarzmik@free.fr> Message-ID: <87sh7oxsn8.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Robert Jarzmik writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more > generic function dma_request_slave_channel(). > > Signed-off-by: Robert Jarzmik Bartlomiej, could I have your ack please ? Cheers. -- Robert PS: The submitted patch > --- > drivers/ata/pata_pxa.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c > index f6c46e9a4dc0..e8b6a2e464c9 100644 > --- a/drivers/ata/pata_pxa.c > +++ b/drivers/ata/pata_pxa.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -180,8 +179,6 @@ static int pxa_ata_probe(struct platform_device *pdev) > struct resource *irq_res; > struct pata_pxa_pdata *pdata = dev_get_platdata(&pdev->dev); > struct dma_slave_config config; > - dma_cap_mask_t mask; > - struct pxad_param param; > int ret = 0; > > /* > @@ -278,10 +275,6 @@ static int pxa_ata_probe(struct platform_device *pdev) > > ap->private_data = data; > > - dma_cap_zero(mask); > - dma_cap_set(DMA_SLAVE, mask); > - param.prio = PXAD_PRIO_LOWEST; > - param.drcmr = pdata->dma_dreq; > memset(&config, 0, sizeof(config)); > config.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; > config.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; > @@ -294,8 +287,7 @@ static int pxa_ata_probe(struct platform_device *pdev) > * Request the DMA channel > */ > data->dma_chan = > - dma_request_slave_channel_compat(mask, pxad_filter_fn, > - ¶m, &pdev->dev, "data"); > + dma_request_slave_channel(&pdev->dev, "data"); > if (!data->dma_chan) > return -EBUSY; > ret = dmaengine_slave_config(data->dma_chan, &config);