From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbdCPLKh (ORCPT ); Thu, 16 Mar 2017 07:10:37 -0400 Received: from ozlabs.org ([103.22.144.67]:47785 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbdCPLKd (ORCPT ); Thu, 16 Mar 2017 07:10:33 -0400 From: Michael Ellerman To: Linus Torvalds , Kyle Huey Cc: "Robert O'Callahan" , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , "the arch\/x86 maintainers" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Jeff Dike , Richard Weinberger , Alexander Viro , Shuah Khan , Dave Hansen , Borislav Petkov , Peter Zijlstra , Boris Ostrovsky , Len Brown , Dmitry Safonov , "Rafael J. Wysocki" , David Matlack , Nadav Amit , Andi Kleen , Linux Kernel Mailing List , uml-devel , user-mode-linux-user@lists.sourceforge.net, linux-kselftest@vger.kernel.org, KVM list Subject: Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID In-Reply-To: References: <20170311194702.28754-1-khuey@kylehuey.com> <20170311194702.28754-7-khuey@kylehuey.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 16 Mar 2017 22:09:53 +1100 Message-ID: <87shmdjx4u.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > Kyle, > your patch format is really odd. > > You seem to have *eight* lines of context rather than the regular 3. > Is there any reason for that oddity? > > It basically means that a one-line hunk ends up being 17 lines of > unified diff rather than 7. Presumably he's done: $ git config diff.context 8 Which I also did at one point because I thought it might help for reading diffs, but reverted after realising it also affects the diffs that are generated by format-patch etc. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Date: Thu, 16 Mar 2017 22:09:53 +1100 Message-ID: <87shmdjx4u.fsf@concordia.ellerman.id.au> References: <20170311194702.28754-1-khuey@kylehuey.com> <20170311194702.28754-7-khuey@kylehuey.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Robert O'Callahan , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , "the arch\/x86 maintainers" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Jeff Dike , Richard Weinberger , Alexander Viro , Shuah Khan , Dave Hansen , Borislav Petkov , Peter Zijlstra , Boris Ostrovsky , Len Brown , Dmitry Safonov , "Rafael J. Wysocki" , Davi To: Linus Torvalds , Kyle Huey Return-path: Received: from ozlabs.org ([103.22.144.67]:47785 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbdCPLKd (ORCPT ); Thu, 16 Mar 2017 07:10:33 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Linus Torvalds writes: > Kyle, > your patch format is really odd. > > You seem to have *eight* lines of context rather than the regular 3. > Is there any reason for that oddity? > > It basically means that a one-line hunk ends up being 17 lines of > unified diff rather than 7. Presumably he's done: $ git config diff.context 8 Which I also did at one point because I thought it might help for reading diffs, but reverted after realising it also affects the diffs that are generated by format-patch etc. cheers