All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: linux-wireless@vger.kernel.org, johannes.berg@intel.com,
	hofrat@osadl.org, prameela.garnepudi@redpinesignals.com
Subject: Re: [PATCH 0/9] rsi: code clean-up
Date: Mon, 12 Sep 2016 15:53:45 +0300	[thread overview]
Message-ID: <87sht5mg86.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <cover.1473669618.git.prameela.j04cs@gmail.com> (Prameela Rani Garnepudi's message of "Mon, 12 Sep 2016 15:08:15 +0530")

Prameela Rani Garnepudi <prameela.j04cs@gmail.com> writes:

> *** BLURB HERE ***

This has a meaning :)

> Prameela Rani Garnepudi (9):
>   rsi: cleanup and added debug prints in file rsi_91x_core.c
>   rsi: Spelling and code format corrections in rsi_91x_debugfs.c
>   rsi: Added freeing of allocated buffers (sbands and dfsentry)         
>     Cleanup (spelling mistakes, code format corrections,     	     
>     empty lines after declaration)
>   rsi: code clean up in file rsi_91x_main.c
>   rsi: code cleanup in file rsi_91x_mgmt.c
>   rsi: code cleanup (spelling mistakes and new line after declaration)
>     in file rsi_91x_sdio.c          Added developer name
>   rsi: zone changed for debug message and cleanup in file
>     rsi_91x_sdio_ops.c
>   rsi: code clean up and replaced ctrl message timeouts with macros in
>     file rsi_91x_usb.c
>   rsi: code cleanup in file rsi_91x_usb_ops.c

Usually patches are split based on type of changes, not by files
affected. So one patch does one type of logical change to all files in
the driver and another patch does again something else. Also the commit
logs are not correctly formatted, for example the title is too long.

I recommend to start with something small, for example one small patch a
time. And once you get more familiar with the process you can submit
more, and bigger, patches at a time. Also code cleanup is not really the
best way to start as it's a very subjective matter.

Also try to get more familiar how development is done, here are few
links:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

https://www.kernel.org/doc/Documentation/SubmittingPatches

https://kernelnewbies.org/FirstKernelPatch

Also mailing list archives and git logs are a great way to learn from
how others do it.

-- 
Kalle Valo

  parent reply	other threads:[~2016-09-12 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  9:38 [PATCH 0/9] rsi: code clean-up Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 1/9] rsi: cleanup and added debug prints in file rsi_91x_core.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 2/9] rsi: Spelling and code format corrections in rsi_91x_debugfs.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 3/9] rsi: Added freeing of allocated buffers (sbands and dfsentry) Cleanup (spelling mistakes, code format corrections, empty lines after declaration) Prameela Rani Garnepudi
2016-09-12 12:05   ` kbuild test robot
2016-09-12 12:05   ` [PATCH] rsi: fix ifnullfree.cocci warnings kbuild test robot
2016-09-12  9:38 ` [PATCH 4/9] rsi: code clean up in file rsi_91x_main.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 5/9] rsi: code cleanup in file rsi_91x_mgmt.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 6/9] rsi: code cleanup (spelling mistakes and new line after declaration) in file rsi_91x_sdio.c Added developer name Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 7/9] rsi: zone changed for debug message and cleanup in file rsi_91x_sdio_ops.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 8/9] rsi: code clean up and replaced ctrl message timeouts with macros in file rsi_91x_usb.c Prameela Rani Garnepudi
2016-09-12  9:38 ` [PATCH 9/9] rsi: code cleanup in file rsi_91x_usb_ops.c Prameela Rani Garnepudi
2016-09-12 12:53 ` Kalle Valo [this message]
2016-09-12 18:50   ` [PATCH 0/9] rsi: code clean-up Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sht5mg86.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=hofrat@osadl.org \
    --cc=johannes.berg@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prameela.garnepudi@redpinesignals.com \
    --cc=prameela.j04cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.