From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8y-0005PC-DP
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:35:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8s-0001Vg-Ai
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:35:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47008)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8s-0001Vb-1F
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:35:34 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466777957-5126-1-git-send-email-armbru@redhat.com>
	<1466777957-5126-4-git-send-email-armbru@redhat.com>
	<576D4F0A.9010103@redhat.com>
Date: Mon, 27 Jun 2016 08:35:31 +0200
In-Reply-To: <576D4F0A.9010103@redhat.com> (Eric Blake's message of "Fri, 24
	Jun 2016 09:17:30 -0600")
Message-ID: <87shvzb0lo.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v2 3/5] tests: Make check-block a phony
 target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 06/24/2016 08:19 AM, Markus Armbruster wrote:
>> Forgotten in commit b8c6f29.
>
> Umm, really?  That commit starts with:
>
> tests/Makefile
> -.PHONY: check
> +
> +.PHONY: check check-block
>
> Rather, I think it was b93b63f5 that accidentally lost it during an
> overhaul.

Oops.  Will fix.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  tests/Makefile.include | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 7b0446b..233cb9c 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c
>>  
>>  # Consolidated targets
>>  
>> -.PHONY: check-qapi-schema check-qtest check-unit check check-source check-clean
>> +.PHONY: check-qapi-schema check-qtest check-unit check check-block check-source check-clean
>
> Long line; worth splitting?

Yes.

> With commit message improved,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!