From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:46187 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757602AbcDEMsW convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2016 08:48:22 -0400 From: "Valo, Kalle" To: "Manoharan, Rajkumar" CC: "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "rmanohar@codeaurora.org" Subject: Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction Date: Tue, 5 Apr 2016 12:48:14 +0000 Message-ID: <87shz0b4s2.fsf@kamboji.qca.qualcomm.com> (sfid-20160405_144831_811773_D35E5FA9) References: <1459352551-11773-1-git-send-email-rmanohar@qti.qualcomm.com> <1459352551-11773-3-git-send-email-rmanohar@qti.qualcomm.com> In-Reply-To: <1459352551-11773-3-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Wed, 30 Mar 2016 21:12:31 +0530") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Rajkumar Manoharan writes: > Decrement num_mpdus_ready only when rx amsdu is processed successfully. > Not doing so, will result in leak and impact stabilty under low memory > cases. > > Signed-off-by: Rajkumar Manoharan > --- > drivers/net/wireless/ath/ath10k/htt_rx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c > index 96a7417..9696c2e 100644 > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2412,14 +2412,12 @@ static void ath10k_htt_txrx_compl_task(unsigned long ptr) > struct ath10k_htt *htt = (struct ath10k_htt *)ptr; > struct ath10k *ar = htt->ar; > struct htt_tx_done tx_done = {}; > - struct sk_buff_head rx_q; > struct sk_buff_head rx_ind_q; > struct sk_buff_head tx_ind_q; > struct sk_buff *skb; > unsigned long flags; > int num_mpdus; > > - __skb_queue_head_init(&rx_q); > __skb_queue_head_init(&rx_ind_q); > __skb_queue_head_init(&tx_ind_q); I guess you are removing the unused rx_q just as a cleanup? It's good practise to mention that in the commit log (or better yet in a separate patch). -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1anQPS-00046n-CT for ath10k@lists.infradead.org; Tue, 05 Apr 2016 12:48:43 +0000 From: "Valo, Kalle" Subject: Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction Date: Tue, 5 Apr 2016 12:48:14 +0000 Message-ID: <87shz0b4s2.fsf@kamboji.qca.qualcomm.com> References: <1459352551-11773-1-git-send-email-rmanohar@qti.qualcomm.com> <1459352551-11773-3-git-send-email-rmanohar@qti.qualcomm.com> In-Reply-To: <1459352551-11773-3-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Wed, 30 Mar 2016 21:12:31 +0530") Content-Language: en-US Content-ID: <067895EA78C09A4B91F9310B9B345930@qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: "Manoharan, Rajkumar" Cc: "linux-wireless@vger.kernel.org" , "rmanohar@codeaurora.org" , "ath10k@lists.infradead.org" Rajkumar Manoharan writes: > Decrement num_mpdus_ready only when rx amsdu is processed successfully. > Not doing so, will result in leak and impact stabilty under low memory > cases. > > Signed-off-by: Rajkumar Manoharan > --- > drivers/net/wireless/ath/ath10k/htt_rx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c > index 96a7417..9696c2e 100644 > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2412,14 +2412,12 @@ static void ath10k_htt_txrx_compl_task(unsigned long ptr) > struct ath10k_htt *htt = (struct ath10k_htt *)ptr; > struct ath10k *ar = htt->ar; > struct htt_tx_done tx_done = {}; > - struct sk_buff_head rx_q; > struct sk_buff_head rx_ind_q; > struct sk_buff_head tx_ind_q; > struct sk_buff *skb; > unsigned long flags; > int num_mpdus; > > - __skb_queue_head_init(&rx_q); > __skb_queue_head_init(&rx_ind_q); > __skb_queue_head_init(&tx_ind_q); I guess you are removing the unused rx_q just as a cleanup? It's good practise to mention that in the commit log (or better yet in a separate patch). -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k