From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbcDAKWN (ORCPT ); Fri, 1 Apr 2016 06:22:13 -0400 Received: from mga11.intel.com ([192.55.52.93]:61835 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752058AbcDAKWL (ORCPT ); Fri, 1 Apr 2016 06:22:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,427,1455004800"; d="asc'?scan'208";a="945961028" From: Felipe Balbi To: Grygorii Strashko , "Thang Q. Nguyen" Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, Arnd Bergmann , "Karicheri\, Muralidharan" , Peter Ujfalusi , Phong Vo , Loc Ho , patches , Santosh Shilimkar , "Ben Dooks \(embedded platforms\)" Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child In-Reply-To: <56FE4378.3030205@ti.com> References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> <56FBDA0D.4030507@ti.com> <87egashxz8.fsf@intel.com> <87k2kjgjjf.fsf@intel.com> <56FD3D2F.8070501@ti.com> <871t6pahg8.fsf@intel.com> <56FE4378.3030205@ti.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Fri, 01 Apr 2016 13:20:03 +0300 Message-ID: <87shz58wbw.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Grygorii Strashko writes: >> if of_dma_configure() does what you want, why don't you just stick it in >> dwc3-keystone.c and let the driver continue to copy things for now ? >> Something like below, perhaps ? >>=20 > > I know (and i have patch to fix that which I'm going to send) that DMA co= nfig=20 > in dwc3-keystone.c is not correct and we are good till now just=20 > because dwc3_keystone is not used for DMA operations directly. > > Now about xhci and friends: > dwc3_keystone *is created* from DT : of_platform_device_create() -> of_pl= atform_device_create_pdata() -> of_dma_configure() > |- dwc3 *is created* from DT : of_platform_device_create() -> of_platform= _device_create_pdata() -> of_dma_configure() > |- [1] *creates* xhci dev manually : DMA configuration copied manually= in dwc3_host_init() > |- [2] *creates* usb_gadget dev manually: DMA configuration copied man= ually in usb_add_gadget_udc_release() > |- *creates* usb_udc dev manually : not used for DMA operations direct= ly (as I've checked) > > Now cases [1] & [2] introduces failures, because DMA configuration is not= complete for > these devices. right, then we just copy whatever's missing, right ? Until there's a generic way of copying these bits, I want to avoid introducing any of_* specific methodologies and prefer to have the manual copy. > I can confirm that if I fix [1] & [2] as above USB Device/Dual modes will= start=20 > working on K2E. cool, I'd be happy to take both patches ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW/ktTAAoJEIaOsuA1yqRELfsP/RpvKKquRtDvU7y0N2JRFlUc 1jMPI3jKEWhqedeN5fWWO/AhZ81j95wj6hYXTL7fEClIIYzvqMzFR7K0ljD4pAls xNj6sDKsApJsK93cMs4NUl3ZRUNieUiPIuYfEoM2Duq0A/+KhG7VjpZLufwZFRFx 7y1Q8nnPnNeyARSBftBZ2zE1PzSZKZvLidhUzhmpaTdFiDhh+sKAlnpUPkV3ESAE TGD1bQnaSd99HJqbqPHYWl/2muHRcqJubdfWK60qUXgwr2ri5qS3uDy/87jvvtOT /d6rVI99/jLEKifzhepz7Kq1wojNW7v++iEFcsVeyM8X3pJgvjZCNKnIhsdj2RKE 8PHXpLg0hhHOCJGa2ZADMAo+m54pTSFjUEmmg8/Zypdf1mbL6G5kWsuw3nMF17Sl /4DY9RWmhsKjus4tc+1G61ib70HqmBWnhoayO13zY8NdTZOgWWuUxT6jbWLiDeSM xeeqV8d+EB1bJfSqBaOAtgXY8N+XlkcjHmGs4lM7fmzj9DhW7fK0PFezyVcHFLW3 NfeT5fUAI1koHDfMGheBdNPD48g9EnvKSk4mPzJ716ik2zdDQPlT8PHYh8TVl1MU rBLmcydYAjpgVoSDFs/SAPUOuLzEGXUjKgirrnHwg+q2TCLy2G6ngnQl/f85FpRX 7N0Esd3wtK2zidkcvCQj =nt70 -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Date: Fri, 01 Apr 2016 13:20:03 +0300 Message-ID: <87shz58wbw.fsf@intel.com> References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> <56FBDA0D.4030507@ti.com> <87egashxz8.fsf@intel.com> <87k2kjgjjf.fsf@intel.com> <56FD3D2F.8070501@ti.com> <871t6pahg8.fsf@intel.com> <56FE4378.3030205@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: In-Reply-To: <56FE4378.3030205-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grygorii Strashko , "Thang Q. Nguyen" Cc: Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Arnd Bergmann , "Karicheri, Muralidharan" , Peter Ujfalusi , Phong Vo , Loc Ho , patches , Santosh Shilimkar , "Ben Dooks (embedded platforms)" List-Id: linux-omap@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Grygorii Strashko writes: >> if of_dma_configure() does what you want, why don't you just stick it in >> dwc3-keystone.c and let the driver continue to copy things for now ? >> Something like below, perhaps ? >>=20 > > I know (and i have patch to fix that which I'm going to send) that DMA co= nfig=20 > in dwc3-keystone.c is not correct and we are good till now just=20 > because dwc3_keystone is not used for DMA operations directly. > > Now about xhci and friends: > dwc3_keystone *is created* from DT : of_platform_device_create() -> of_pl= atform_device_create_pdata() -> of_dma_configure() > |- dwc3 *is created* from DT : of_platform_device_create() -> of_platform= _device_create_pdata() -> of_dma_configure() > |- [1] *creates* xhci dev manually : DMA configuration copied manually= in dwc3_host_init() > |- [2] *creates* usb_gadget dev manually: DMA configuration copied man= ually in usb_add_gadget_udc_release() > |- *creates* usb_udc dev manually : not used for DMA operations direct= ly (as I've checked) > > Now cases [1] & [2] introduces failures, because DMA configuration is not= complete for > these devices. right, then we just copy whatever's missing, right ? Until there's a generic way of copying these bits, I want to avoid introducing any of_* specific methodologies and prefer to have the manual copy. > I can confirm that if I fix [1] & [2] as above USB Device/Dual modes will= start=20 > working on K2E. cool, I'd be happy to take both patches ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW/ktTAAoJEIaOsuA1yqRELfsP/RpvKKquRtDvU7y0N2JRFlUc 1jMPI3jKEWhqedeN5fWWO/AhZ81j95wj6hYXTL7fEClIIYzvqMzFR7K0ljD4pAls xNj6sDKsApJsK93cMs4NUl3ZRUNieUiPIuYfEoM2Duq0A/+KhG7VjpZLufwZFRFx 7y1Q8nnPnNeyARSBftBZ2zE1PzSZKZvLidhUzhmpaTdFiDhh+sKAlnpUPkV3ESAE TGD1bQnaSd99HJqbqPHYWl/2muHRcqJubdfWK60qUXgwr2ri5qS3uDy/87jvvtOT /d6rVI99/jLEKifzhepz7Kq1wojNW7v++iEFcsVeyM8X3pJgvjZCNKnIhsdj2RKE 8PHXpLg0hhHOCJGa2ZADMAo+m54pTSFjUEmmg8/Zypdf1mbL6G5kWsuw3nMF17Sl /4DY9RWmhsKjus4tc+1G61ib70HqmBWnhoayO13zY8NdTZOgWWuUxT6jbWLiDeSM xeeqV8d+EB1bJfSqBaOAtgXY8N+XlkcjHmGs4lM7fmzj9DhW7fK0PFezyVcHFLW3 NfeT5fUAI1koHDfMGheBdNPD48g9EnvKSk4mPzJ716ik2zdDQPlT8PHYh8TVl1MU rBLmcydYAjpgVoSDFs/SAPUOuLzEGXUjKgirrnHwg+q2TCLy2G6ngnQl/f85FpRX 7N0Esd3wtK2zidkcvCQj =nt70 -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html