From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a0ldy-0000fo-1L
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 02:34:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a0ldt-0000ar-B7
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 02:34:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1a0ldt-0000an-6A
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 02:34:29 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1447836791-369-1-git-send-email-eblake@redhat.com>
	<1447836791-369-35-git-send-email-eblake@redhat.com>
	<564FA389.5030003@redhat.com>
Date: Mon, 23 Nov 2015 08:34:27 +0100
In-Reply-To: <564FA389.5030003@redhat.com> (Eric Blake's message of "Fri, 20
	Nov 2015 15:49:45 -0700")
Message-ID: <87si3xcgos.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v12 34/36] qapi: Add positive tests to
	qapi-schema-test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> On 11/18/2015 01:53 AM, Eric Blake wrote:
>> Add positive tests to qapi-schema-test for things that were
>> made possible by recent patches but which caused compile errors
>> due to collisions prior to that point.  The focus is mainly on
>> collisions due to names we have reserved for qapi, even though
>> it is unlikely that anyone will want to abuse these names in
>> actual .json files.
>> 
>> The added tests includes:
>> Use of a member name ending in 'Kind' or 'List' [1, 3]
>
> Violates our coding convention of all lower case, so not worth testing.
>
>> Use of a type name starting with 'has_' [1, 4]
>
> Ditto.
>
>> Use of a type named 'u' [1, 5]
>
> Ditto.
>
>> Use of a union branch name of 'u' [2, 5]
>> Use of a union branch name starting with 'has_' [2, 4]
>
> Leaving just these two feels pretty weak.  I think I'll just drop this
> patch from my queue entirely (it was great at proving that recent layout
> improvements worked, but it's not the end of the world to lose it
> entirely, especially now that v13 is starting to enforce naming
> conventions except for a few whitelisted names, and I don't want to make
> the whitelist longer just for the testsuite).

Makes sense.

[...]