From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMEmq-0007pg-F6 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMEml-0004jA-Ma for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:19:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMEml-0004j6-F5 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 07:19:35 -0400 From: Markus Armbruster References: <1408985672-14423-1-git-send-email-pbonzini@redhat.com> Date: Tue, 26 Aug 2014 13:19:29 +0200 In-Reply-To: <1408985672-14423-1-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 25 Aug 2014 18:54:32 +0200") Message-ID: <87sikja472.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] checkpatch.pl: adjust typedef definition to QEMU coding style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aik@ozlabs.ru, Peter Maydell , qemu-devel@nongnu.org, Stefan Weil Paolo Bonzini writes: > Most QEMU typedefs are camelcase, starting with one uppercase letter > and containing at least one lowercase letter. There are a few > all-uppercase types, add the most common too. > > This fixes recognition of types in lines such as > > static __attribute__((unused)) inline void tcg_out8(TCGContext *s, uint8_t v) > > (Example provided by Peter Maydell). > > Reported-by: Alexey Kardashevskiy > Cc: Peter Maydell > Cc: Stefan Weil > Cc: Markus Armbruster > Signed-off-by: Paolo Bonzini > --- > scripts/checkpatch.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 9d46e5a..053e432 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -206,9 +206,13 @@ our $UTF8 = qr { > | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 > }x; > > +# There are still some false positives, but this catches most > +# common cases. > our $typeTypedefs = qr{(?x: > - (?:__)?(?:u|s|be|le)(?:8|16|32|64)| > - atomic_t > + [A-Z][A-Z\d_]*[a-z][A-Za-z\d_]* # camelcase > + | [A-Z][A-Z\d_]*AIOCB # all uppercase > + | [A-Z][A-Z\d_]*CPU # all uppercase > + | QEMUBH # all uppercase > )}; > > our $logFunctions = qr{(?x: I had to look up \d, and then I got scared until I remembered "Perl will not use locales unless specifically requested to". Applies both to \d and A-Z. Consistent with existing usage, except for the position of '|'. Reviewed-by: Markus Armbruster