From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQK60-0004bV-DJ for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:39:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQK5w-0005Zf-5q for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:39:16 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:54366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQK5v-0005Xz-Hi for qemu-devel@nongnu.org; Mon, 22 Oct 2012 11:39:12 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Oct 2012 21:09:04 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9MFd1ud2228690 for ; Mon, 22 Oct 2012 21:09:01 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9ML8qQL024131 for ; Tue, 23 Oct 2012 08:08:52 +1100 From: Anthony Liguori In-Reply-To: <20121022131601.GC16851@redhat.com> References: <20121021124303.GA5096@redhat.com> <5084E088.9090602@redhat.com> <20121022100821.GB24424@redhat.com> <508521F3.3070008@redhat.com> <20121022131601.GC16851@redhat.com> Date: Mon, 22 Oct 2012 10:37:56 -0500 Message-ID: <87sj9634bv.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Gerd Hoffmann Cc: agraf@suse.de, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de "Michael S. Tsirkin" writes: > On Mon, Oct 22, 2012 at 12:37:39PM +0200, Gerd Hoffmann wrote: >> On 10/22/12 12:08, Michael S. Tsirkin wrote: >> > On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: >> >> Hi, >> >> >> >>> Would it make sense to temporarily rename the machine type e.g. >> >>> pc-q35-experimental to stress it's not fully supported? >> >> >> >> I don't think this is needed as piix will continue to be the default. >> > >> > Well q35 is not yet 100% ready. >> >> I know. >> >> > The point was to hide it from libvirt. >> > libvirt should support pc-q35 not pc-q35-experimental, then >> > it will not cause trouble. >> >> You'll not going to hide it that way. Libvirt will just 'qemu -M ?' >> where q35 will show up even if you rename it to be postfixed -experimental. >> >> But as long as 'pc' continues to be the default the causal user will >> never ever notice q35 is there, at least not with virt-manager (dunno >> about boxes) as there is simply no gui way to pick the machine type. >> You'll have to explicitly "virsh edit $guest" to switch it to q35. >> >> So I'm not sure what you are worryed about. > > I worry about need to maintain bug for bug compatibility on the > unlikely chance that the work to complete it gets delayed and we release > it in an unready state. > >> But in any case this needs >> discussion with the libvirt folks to make sure it will actually work as >> intended. /me tends to think a experimental bit in machine_info (which >> is then printed by 'qemu -M ?' and the QOM-version of that) is more >> useful than playing tricks with the name. >> >> cheers, >> Gerd > > I agree it's best to ask libvirt folks what's the right way to hide > a machine type from it. Add a flag so it's not listed in -M ? ? > Jason, do you know? We don't need to hide it from libvirt. What I'd suggest is that for q35, we don't introduce QEMU versioned machine types but instead provide a machine-level version. IOW: q35-next <- bleeding edge version of code. No compatibility guarantee q35-0.1 <- if we decide we want to have a "tech preview" of q35 that's incomplete but will be supported for compat q35-1.0 <- the first "complete" release of q35 with full compat support I think we should also alias 'q35' to 'q35-next'. Regards, Anthony Liguori > > -- > MST