From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DCDC77B75 for ; Sat, 6 May 2023 05:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbjEFF5w (ORCPT ); Sat, 6 May 2023 01:57:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230418AbjEFF5t (ORCPT ); Sat, 6 May 2023 01:57:49 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695C983EE for ; Fri, 5 May 2023 22:57:48 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F2EDA20B61; Sat, 6 May 2023 05:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683352667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9i0SeTx8lIGtrzyO+u8rvIkHwihnziAaxcN8UqkZhFc=; b=DZ3ZONcavrzajmpiiy4Xnow3NPEbLx5hDAbTEUaOKDf3dFrA2JdVXZrf5jfMgXeyqtZh2z tI5xXsRNbLwzHwDAFMv4wT6KX8fMBOJ3+5dAqZwlQrn6zLU3goriXrit6T8QPeI/V9JOps QGqoglH1TMNDsDQwFyy0WRSoelVp+oM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683352667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9i0SeTx8lIGtrzyO+u8rvIkHwihnziAaxcN8UqkZhFc=; b=DBb0IShcR56G7dP/+K75zwoycxASgT0YrHfurBTFVaxbbXEOMwLVIPBm1uPTTN1OSFOqAJ 64pRhoFRCPA6yIDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB9D4134FB; Sat, 6 May 2023 05:57:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eP9hKFrsVWQAPgAAMHmgww (envelope-from ); Sat, 06 May 2023 05:57:46 +0000 Date: Sat, 06 May 2023 07:57:46 +0200 Message-ID: <87ttwqgfxh.wl-tiwai@suse.de> From: Takashi Iwai To: Srinivas Kandagatla Cc: broonie@kernel.org, tiwai@suse.com, perex@perex.cz, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/3] ALSA: pcm: add snd_pcm_add_chmap_ctls_with_prefix In-Reply-To: <20230505165514.4666-2-srinivas.kandagatla@linaro.org> References: <20230505165514.4666-1-srinivas.kandagatla@linaro.org> <20230505165514.4666-2-srinivas.kandagatla@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 May 2023 18:55:12 +0200, Srinivas Kandagatla wrote: > > On Qualcomm SoC which has multiple Display Port controllers, using > snd_pcm_add_chmap_ctls() to add chmap controls from every ASoC hdmi codec > instance for a give card fails while adding second instance as the control > with same name "Playback Channel Map" already exists from the first instance. > > Fix this by adding a new api wrapper to pass ASoC component name prefix to > avoid such duplicate control naming. It implies that you have conflicting PCM objects with the same PCM device number from the same card. How can it be? Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FCC3C77B75 for ; Sat, 6 May 2023 05:58:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 734672BD7; Sat, 6 May 2023 07:58:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 734672BD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683352734; bh=oovjI6jbdLa3skcz+AwUpdZypL6joV/hrW+m8eH0m2I=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=G6BibpD6CdDcuoB8bpGbyBytL2mg9Qr7q1PQ226Z60nEZWUXWlTjEhNpuLTlcEuxX r7XusJYS7blshlkei9UO5CH6WEtTjQPU9g/8GWoABNNog1BvcUVdxR8u4IhF7qJBKg G31yFCDmoGpoZ9CULbMsO40xCZPjyiIKK//e7wvA= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 202A3F8053B; Sat, 6 May 2023 07:57:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CEC0EF8053B; Sat, 6 May 2023 07:57:51 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F25EAF80533 for ; Sat, 6 May 2023 07:57:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F25EAF80533 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DZ3ZONca; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DBb0IShc Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F2EDA20B61; Sat, 6 May 2023 05:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683352667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9i0SeTx8lIGtrzyO+u8rvIkHwihnziAaxcN8UqkZhFc=; b=DZ3ZONcavrzajmpiiy4Xnow3NPEbLx5hDAbTEUaOKDf3dFrA2JdVXZrf5jfMgXeyqtZh2z tI5xXsRNbLwzHwDAFMv4wT6KX8fMBOJ3+5dAqZwlQrn6zLU3goriXrit6T8QPeI/V9JOps QGqoglH1TMNDsDQwFyy0WRSoelVp+oM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683352667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9i0SeTx8lIGtrzyO+u8rvIkHwihnziAaxcN8UqkZhFc=; b=DBb0IShcR56G7dP/+K75zwoycxASgT0YrHfurBTFVaxbbXEOMwLVIPBm1uPTTN1OSFOqAJ 64pRhoFRCPA6yIDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB9D4134FB; Sat, 6 May 2023 05:57:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eP9hKFrsVWQAPgAAMHmgww (envelope-from ); Sat, 06 May 2023 05:57:46 +0000 Date: Sat, 06 May 2023 07:57:46 +0200 Message-ID: <87ttwqgfxh.wl-tiwai@suse.de> From: Takashi Iwai To: Srinivas Kandagatla Subject: Re: [PATCH 1/3] ALSA: pcm: add snd_pcm_add_chmap_ctls_with_prefix In-Reply-To: <20230505165514.4666-2-srinivas.kandagatla@linaro.org> References: <20230505165514.4666-1-srinivas.kandagatla@linaro.org> <20230505165514.4666-2-srinivas.kandagatla@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: BE4NG5O64V6VFY7RRBQ2ZYZ5M7ILWYDM X-Message-ID-Hash: BE4NG5O64V6VFY7RRBQ2ZYZ5M7ILWYDM X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 18:55:12 +0200, Srinivas Kandagatla wrote: > > On Qualcomm SoC which has multiple Display Port controllers, using > snd_pcm_add_chmap_ctls() to add chmap controls from every ASoC hdmi codec > instance for a give card fails while adding second instance as the control > with same name "Playback Channel Map" already exists from the first instance. > > Fix this by adding a new api wrapper to pass ASoC component name prefix to > avoid such duplicate control naming. It implies that you have conflicting PCM objects with the same PCM device number from the same card. How can it be? Takashi