From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FF89C63797 for ; Tue, 17 Jan 2023 09:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Px3XVESrLL1JSs2d1db+9GilstXPTrx5I1gJgSRmFwk=; b=IeSsz4SfKefCSz E/p9tZq/zqJ6dG0bE+7L/SyqLe443WSBsfMWhH59W4RxYQY1JkgbLO0T6Ug4Xs8xug7Ai8kLp1FGD NY/Y73Moq2ksRAp7sBaTl0XMlZOLghQSG0hIOvfZIcmprCBdMo4Mou665oXRsjTL4fsnMwSqNMey7 6c5oya6uqDbVY7OGAOn/z+CZhC4XyVQ3CTFppMI8iIYZxVa36DvsYP5WdjWvl65i6ML7i7AJFtI6q FTx0LM4sSFCdpKleXWYBtRI3W3tACQl9Zq/O/ujEtaaxF2WUVJAOOBYkEzu/W+3bIq2kMAKZEFNf0 wf47hc64xLWdBJDMJaiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHiQg-00DcEs-8m; Tue, 17 Jan 2023 09:38:54 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHiQY-00DcC8-Gq for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 09:38:47 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673948322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=huHxyGFkEMa6d1D0Au6QELxVkmDV59quuX0vGDYSXaY=; b=pgh2qjtwzxp/nJa3JrElZ2JxShuREDd68JdE2OsjHkpHfJlyUDOKhRrPHHP4aLudOTRna9 Ns9ZLINgGtYh/9Yy5OXlS7Iryt+jSX6KnbowoOc+o52zSMTIEL2osZlRP566fmne9/fjuu ZmpeNn7FqoMO4ZjnHBsk+hW8XeI2BTxfKI0BiPlz9++cxLkhjbReiTTnuXX0d99+D9VoyW g/HGppyULW2tu1E8C/CCkTpYwLTmH4LYmEhXqFs2+A+AuSoa8mr5HitkUNDjgTTDRP8o11 VgmPfnADVuuAUrHyEcD75uqOO+pxfaN4vsuAZflJsl3DNol/pH0TEED2VIblBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673948322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=huHxyGFkEMa6d1D0Au6QELxVkmDV59quuX0vGDYSXaY=; b=px5BPESDxGc8ZR6+hAf/v8dN6WWVHToWOLpC98VyASSEh0tO4D1ZyJAulu/8o5HD2KwtT1 GhXenrlzW8lISbDA== To: Yipeng Zou , Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hewenliang4@huawei.com, chris.zjh@huawei.com, liaochang1@huawei.com Subject: Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity In-Reply-To: <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com> References: <20230106082136.68501-1-zouyipeng@huawei.com> <86pmbrop11.wl-maz@kernel.org> <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com> Date: Tue, 17 Jan 2023 10:38:41 +0100 Message-ID: <87tu0plcv2.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_013846_740273_A6A640B2 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMDkgMjAyMyBhdCAyMDoyNiwgWWlwZW5nIFpvdSB3cm90ZToKPiDlnKggMjAy My8xLzYgMTk6NTUsIE1hcmMgWnluZ2llciDlhpnpgZM6Cj4gaW5kZXggOTczZWRlMDE5N2UzLi5m YWQwOGNjYjdmZDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRz LmMKPiArKysgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYwo+IEBAIC0xNjY3LDYg KzE2NjcsOSBAQCBzdGF0aWMgaW50IGl0c19zZXRfYWZmaW5pdHkoc3RydWN0IGlycV9kYXRhICpk LCAKPiBjb25zdCBzdHJ1Y3QgY3B1bWFzayAqbWFza192YWwsCj4KPiAgwqDCoMKgwqDCoMKgwqAg LyogZG9uJ3Qgc2V0IHRoZSBhZmZpbml0eSB3aGVuIHRoZSB0YXJnZXQgY3B1IGlzIHNhbWUgYXMg Cj4gY3VycmVudCBvbmUgKi8KPiAgwqDCoMKgwqDCoMKgwqAgaWYgKGNwdSAhPSBwcmV2X2NwdSkg ewo+ICsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvLyB3YWl0IGlycSBkb25lIG9u IGFsbCBjcHVzCj4gKwoKVGhlcmUgaXMgbm8gd2F5IHRvIHdhaXQgaGVyZS4gVGhlIGNhbGxlciBo b2xkcyB0aGUgaW50ZXJydXB0IGRlc2NyaXB0b3IKbG9jay4KCklmIHRoaXMgaXMgcmVhbGx5IGFu IGlzc3VlIGZvciBMUEksIHRoZW4gdGhlIG9ubHkgd2F5IHRvIGRlYWwgd2l0aCB0aGF0CmlzIENP TkZJR19HRU5FUklDX1BFTkRJTkdfSVJRLCB3aGljaCBkZWxheXMgdGhlIGFmZmluaXR5IGNoYW5n ZSB0bwppbnRlcnJ1cHQgY29udGV4dAoKV2h5IG9uIGVhcnRoIG11c3QgYWxsIHRoZSBrbm93biBo YXJkd2FyZSBtaXN0YWtlcyBiZSByZXBlYXRlZCBvdmVyIGFuZApvdmVyPwoKVGhhbmtzLAoKICAg ICAgICB0Z2x4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11457C63797 for ; Tue, 17 Jan 2023 09:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbjAQJlX (ORCPT ); Tue, 17 Jan 2023 04:41:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236619AbjAQJkq (ORCPT ); Tue, 17 Jan 2023 04:40:46 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5240C30B1C for ; Tue, 17 Jan 2023 01:38:43 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673948322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=huHxyGFkEMa6d1D0Au6QELxVkmDV59quuX0vGDYSXaY=; b=pgh2qjtwzxp/nJa3JrElZ2JxShuREDd68JdE2OsjHkpHfJlyUDOKhRrPHHP4aLudOTRna9 Ns9ZLINgGtYh/9Yy5OXlS7Iryt+jSX6KnbowoOc+o52zSMTIEL2osZlRP566fmne9/fjuu ZmpeNn7FqoMO4ZjnHBsk+hW8XeI2BTxfKI0BiPlz9++cxLkhjbReiTTnuXX0d99+D9VoyW g/HGppyULW2tu1E8C/CCkTpYwLTmH4LYmEhXqFs2+A+AuSoa8mr5HitkUNDjgTTDRP8o11 VgmPfnADVuuAUrHyEcD75uqOO+pxfaN4vsuAZflJsl3DNol/pH0TEED2VIblBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673948322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=huHxyGFkEMa6d1D0Au6QELxVkmDV59quuX0vGDYSXaY=; b=px5BPESDxGc8ZR6+hAf/v8dN6WWVHToWOLpC98VyASSEh0tO4D1ZyJAulu/8o5HD2KwtT1 GhXenrlzW8lISbDA== To: Yipeng Zou , Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hewenliang4@huawei.com, chris.zjh@huawei.com, liaochang1@huawei.com Subject: Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity In-Reply-To: <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com> References: <20230106082136.68501-1-zouyipeng@huawei.com> <86pmbrop11.wl-maz@kernel.org> <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com> Date: Tue, 17 Jan 2023 10:38:41 +0100 Message-ID: <87tu0plcv2.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09 2023 at 20:26, Yipeng Zou wrote: > =E5=9C=A8 2023/1/6 19:55, Marc Zyngier =E5=86=99=E9=81=93: > index 973ede0197e3..fad08ccb7fd9 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -1667,6 +1667,9 @@ static int its_set_affinity(struct irq_data *d,=20 > const struct cpumask *mask_val, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* don't set the affinity whe= n the target cpu is same as=20 > current one */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (cpu !=3D prev_cpu) { > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 // wait irq done on all cpus > + There is no way to wait here. The caller holds the interrupt descriptor lock. If this is really an issue for LPI, then the only way to deal with that is CONFIG_GENERIC_PENDING_IRQ, which delays the affinity change to interrupt context Why on earth must all the known hardware mistakes be repeated over and over? Thanks, tglx