From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE2E5A495 for ; Mon, 28 Nov 2022 21:03:27 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=zlvNwIwoHG+fU4gxnuatMPxfyVs5ZSLePNJu4/ocONdVKcLEZDqxHiVlXWATLTuFzvzVQH wvylbGYhnIJkRBfI06fvH8zrEydybvoGyJU4k6idIaEb8132jwZUwabOGcYf5ls2TUSa81 SbeW0BZ0iRRMeh23zOgiaOb0YEuMrwElmiEaTS7Nepm/GHglMgTFNCurANP6kTLFcFlxT+ S6h+mst5tidq7iJ67Vk4o2lLC31GVx0EpMSI7Jy53xj9hjy0e+Xb2TiEVK7iM0+bf272Ze 2pAQf4pFBLaQtNW95y+qQXVA9uI271Sl7FODDOKRr/856Yr93LB6VMiYkim0lQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=CWSwp1XKO4MBIhCx2CWco0lkUyqfbLhLh5RYHrL1h2GQY7cqKnAbOprHdP8gtA7ZMoKFpk LeZC3c+3eRBaziBw== To: Frank Li Cc: agross@kernel.org, ammarfaizi2@gnuweeb.org, andersson@kernel.org, andrew@lunn.ch, bhelgaas@google.com, festevam@gmail.com, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, jgg@mellanox.com, kristo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mark.rutland@arm.com, maz@kernel.org, nm@ti.com, okaya@kernel.org, robin.murphy@arm.com, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shameerali.kolothum.thodi@huawei.com, shawnguo@kernel.org, ssantosh@kernel.org, vkoul@kernel.org, will@kernel.org, yuzenghui@huawei.com, imx@lists.linux.dev Subject: Re: [patch V2 33/40] irqchip/imx-mu-msi: Switch to MSI parent In-Reply-To: <20221128204710.2084706-1-Frank.Li@nxp.com> References: <20221121140050.386216606@linutronix.de> <20221128204710.2084706-1-Frank.Li@nxp.com> Date: Mon, 28 Nov 2022 22:03:20 +0100 Message-ID: <87tu2ivlk7.ffs@tglx> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Frank! On Mon, Nov 28 2022 at 15:47, Frank Li wrote: > On Mon, Nov 21, 2022 at 03:40:09PM +0100, Thomas Gleixner wrote: >> * The device MSI domain can never have a set affinity callback it >> --- a/drivers/irqchip/irq-imx-mu-msi.c >> +++ b/drivers/irqchip/irq-imx-mu-msi.c >> @@ -24,6 +24,8 @@ >> #include >> #include >> >> +#include "irq-gic-msi-lib.h" >> + > > I think irq-gic-msi-lib.h is not good name. Actually mu-msi is not arm gic. > irq-gic-msi-lib do common work, which not related arm gic at all. I realized that after a while too, but the main purpose of this series was to establish that the core design holds up to handle the gazillions of ARM variants out there and to solicit technical feedback from the involved parties. >> static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev) >> { >> struct fwnode_handle *fwnodes = dev_fwnode(dev); >> struct irq_domain *parent; >> >> /* Initialize MSI domain parent */ >> - parent = irq_domain_create_linear(fwnodes, >> - IMX_MU_CHANS, >> - &imx_mu_msi_domain_ops, >> - msi_data); >> + parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS, &imx_mu_msi_domain_ops, msi_data); > > coding style change should be in sperated patch. Thanks for the thorough technical feedback! tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4481EC4321E for ; Mon, 28 Nov 2022 21:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sg+Mkwa7OdD6coKOtS6TH5D+V5rZdji2t9SR8KAGgbs=; b=ioylg9/VbzuKPp wnq3G35i28xDjMAKuiL9jfLZaEXYrPf+zOjmQzG9oPN4pODkGHMpK2gcNFk4nPEubl33Tu/PAWqaK x1Gy63c6kKte3yvOYMEjUJvMXS8tSVW/PNZX1ApL2KekEPVAK7Sb6Zd4hLPIdhVuq2Q8MspOr2Ie3 SAvpugn1Ark/JHS7O170kE7WtIn1Ph8Xt7ytppRf2RWPCjL4OXA+UOEIGRDHqriND8eVFnJfI7/BQ 1WZ+TQOAlrwzOkY/H6jGGGoWrC4Ce5PbVIifh696iS4W25NjlntR+gWER7AdyEz4+LUxsIJEYOu4U zfy9wwgBGndWxhJ1Y06Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozlHj-004QMB-OD; Mon, 28 Nov 2022 21:03:27 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozlHf-004QJO-Sj for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 21:03:25 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=zlvNwIwoHG+fU4gxnuatMPxfyVs5ZSLePNJu4/ocONdVKcLEZDqxHiVlXWATLTuFzvzVQH wvylbGYhnIJkRBfI06fvH8zrEydybvoGyJU4k6idIaEb8132jwZUwabOGcYf5ls2TUSa81 SbeW0BZ0iRRMeh23zOgiaOb0YEuMrwElmiEaTS7Nepm/GHglMgTFNCurANP6kTLFcFlxT+ S6h+mst5tidq7iJ67Vk4o2lLC31GVx0EpMSI7Jy53xj9hjy0e+Xb2TiEVK7iM0+bf272Ze 2pAQf4pFBLaQtNW95y+qQXVA9uI271Sl7FODDOKRr/856Yr93LB6VMiYkim0lQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=CWSwp1XKO4MBIhCx2CWco0lkUyqfbLhLh5RYHrL1h2GQY7cqKnAbOprHdP8gtA7ZMoKFpk LeZC3c+3eRBaziBw== To: Frank Li Cc: agross@kernel.org, ammarfaizi2@gnuweeb.org, andersson@kernel.org, andrew@lunn.ch, bhelgaas@google.com, festevam@gmail.com, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, jgg@mellanox.com, kristo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mark.rutland@arm.com, maz@kernel.org, nm@ti.com, okaya@kernel.org, robin.murphy@arm.com, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shameerali.kolothum.thodi@huawei.com, shawnguo@kernel.org, ssantosh@kernel.org, vkoul@kernel.org, will@kernel.org, yuzenghui@huawei.com, imx@lists.linux.dev Subject: Re: [patch V2 33/40] irqchip/imx-mu-msi: Switch to MSI parent In-Reply-To: <20221128204710.2084706-1-Frank.Li@nxp.com> References: <20221121140050.386216606@linutronix.de> <20221128204710.2084706-1-Frank.Li@nxp.com> Date: Mon, 28 Nov 2022 22:03:20 +0100 Message-ID: <87tu2ivlk7.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_130324_091978_EAF5ED04 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Frank! On Mon, Nov 28 2022 at 15:47, Frank Li wrote: > On Mon, Nov 21, 2022 at 03:40:09PM +0100, Thomas Gleixner wrote: >> * The device MSI domain can never have a set affinity callback it >> --- a/drivers/irqchip/irq-imx-mu-msi.c >> +++ b/drivers/irqchip/irq-imx-mu-msi.c >> @@ -24,6 +24,8 @@ >> #include >> #include >> >> +#include "irq-gic-msi-lib.h" >> + > > I think irq-gic-msi-lib.h is not good name. Actually mu-msi is not arm gic. > irq-gic-msi-lib do common work, which not related arm gic at all. I realized that after a while too, but the main purpose of this series was to establish that the core design holds up to handle the gazillions of ARM variants out there and to solicit technical feedback from the involved parties. >> static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev) >> { >> struct fwnode_handle *fwnodes = dev_fwnode(dev); >> struct irq_domain *parent; >> >> /* Initialize MSI domain parent */ >> - parent = irq_domain_create_linear(fwnodes, >> - IMX_MU_CHANS, >> - &imx_mu_msi_domain_ops, >> - msi_data); >> + parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS, &imx_mu_msi_domain_ops, msi_data); > > coding style change should be in sperated patch. Thanks for the thorough technical feedback! tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel