From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B8EC433F5 for ; Wed, 18 May 2022 04:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbiERERZ (ORCPT ); Wed, 18 May 2022 00:17:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbiERERQ (ORCPT ); Wed, 18 May 2022 00:17:16 -0400 Received: from mail.tkos.co.il (mail.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E2E02661; Tue, 17 May 2022 21:17:14 -0700 (PDT) Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id B5A474401D4; Wed, 18 May 2022 07:16:05 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1652847365; bh=9RQ9Noiiv587Vg/jTUw5O1TnbrjqBwOFn7otp7MOCi0=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=bXuURY9a52Og3+pbv1jjY63EQxht7omaZJX8cTIQV252f47OGAtEA5CvXe1horI+X cmCcnrAWGGSdRTZ16c2XhjicBxxHIVRKFj+nBcVeJuNiLew3LVnGSGkczUbSmpfzqH t41Z+0LElO80K+bHOXB9xH2awU5qNodFcGXBHomw5AFW+De+MrZSydg9Vo1J3Z6nO1 LIP2ZzJvnIQL/t4CC5hq+M08hEcbS1ZDP/AUzbcjPigyFBPBS+HFLA0tiBNJqTVoGV CD1cLk0a8kv/li5/nHsZIo/xGb0d6rIC2EKWNMxg1IsQNmGAgZBzz1c/7OeJ54epVq TDCzLAvWEyu3g== References: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Date: Wed, 18 May 2022 07:16:01 +0300 In-reply-to: <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> Message-ID: <87tu9nqxtk.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ilpo, On Tue, May 17 2022, Ilpo J=C3=A4rvinen wrote: > Only CS7 and CS8 seem supported but CSIZE is not sanitized to CS8 in > the default: block. > > Set CSIZE correctly so that userspace knows the effective value. > Incorrect CSIZE also results in miscalculation of the frame bits in > tty_get_char_size() or in its predecessor where the roughly the same > code is directly within uart_update_timeout(). > > Cc: Baruch Siach > Fixes: 5930cb3511df (serial: driver for Conexant Digicolor USART) > Signed-off-by: Ilpo J=C3=A4rvinen Acked-by: Baruch Siach Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/di= gicolor-usart.c > index 6d70fea76bb3..65e653eb5026 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -309,6 +309,8 @@ static void digicolor_uart_set_termios(struct uart_po= rt *port, > case CS8: > default: > config |=3D UA_CONFIG_CHAR_LEN; > + termios->c_cflag &=3D ~CSIZE; > + termios->c_cflag |=3D CS8; > break; > } --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A0EDC433F5 for ; Wed, 18 May 2022 04:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7a0Dsi79yWP8aXK5/suDBOwm8KZuRfHd4LH23p5eY7k=; b=bYEPBCtX0X0OAy Z5CfBplhclLKyBrHTZCQRGJGa+EoZHKrMKbvJU3OoNe8j7S7HMgvdOdTy/xiSXD7wohGx9QzJshIP URgYOxlvoJNKpOhKPw6aLRhSO2Z7I3oCsBgI3Ese7w5TITUXfGGND2X1+diih/pAAOeekDFYslsf+ vabmt2hpI/9a0W48VRjUuy5JZW9ONPbdGq2nMa3UnLgHO8OsMpx1uiY5EXZoeHyJpFVBvP1/dJD9S awB0GfKDdjDM+AdGBeOC5HKjBlUxwcg6/yuqK54MFqswHr0Dw85aZn3EvzNPn3mSZXb8F1DKWjhMg FHBmLJudkPj85I0nSbhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrB7l-00H0eE-Pa; Wed, 18 May 2022 04:17:25 +0000 Received: from mail.tkos.co.il ([84.110.109.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrB7h-00H0cV-Lb for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 04:17:23 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id B5A474401D4; Wed, 18 May 2022 07:16:05 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1652847365; bh=9RQ9Noiiv587Vg/jTUw5O1TnbrjqBwOFn7otp7MOCi0=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=bXuURY9a52Og3+pbv1jjY63EQxht7omaZJX8cTIQV252f47OGAtEA5CvXe1horI+X cmCcnrAWGGSdRTZ16c2XhjicBxxHIVRKFj+nBcVeJuNiLew3LVnGSGkczUbSmpfzqH t41Z+0LElO80K+bHOXB9xH2awU5qNodFcGXBHomw5AFW+De+MrZSydg9Vo1J3Z6nO1 LIP2ZzJvnIQL/t4CC5hq+M08hEcbS1ZDP/AUzbcjPigyFBPBS+HFLA0tiBNJqTVoGV CD1cLk0a8kv/li5/nHsZIo/xGb0d6rIC2EKWNMxg1IsQNmGAgZBzz1c/7OeJ54epVq TDCzLAvWEyu3g== References: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Date: Wed, 18 May 2022 07:16:01 +0300 In-reply-to: <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> Message-ID: <87tu9nqxtk.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_211722_222507_2DF60940 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSWxwbywKCk9uIFR1ZSwgTWF5IDE3IDIwMjIsIElscG8gSsOkcnZpbmVuIHdyb3RlOgo+IE9u bHkgQ1M3IGFuZCBDUzggc2VlbSBzdXBwb3J0ZWQgYnV0IENTSVpFIGlzIG5vdCBzYW5pdGl6ZWQg dG8gQ1M4IGluCj4gdGhlIGRlZmF1bHQ6IGJsb2NrLgo+Cj4gU2V0IENTSVpFIGNvcnJlY3RseSBz byB0aGF0IHVzZXJzcGFjZSBrbm93cyB0aGUgZWZmZWN0aXZlIHZhbHVlLgo+IEluY29ycmVjdCBD U0laRSBhbHNvIHJlc3VsdHMgaW4gbWlzY2FsY3VsYXRpb24gb2YgdGhlIGZyYW1lIGJpdHMgaW4K PiB0dHlfZ2V0X2NoYXJfc2l6ZSgpIG9yIGluIGl0cyBwcmVkZWNlc3NvciB3aGVyZSB0aGUgcm91 Z2hseSB0aGUgc2FtZQo+IGNvZGUgaXMgZGlyZWN0bHkgd2l0aGluIHVhcnRfdXBkYXRlX3RpbWVv dXQoKS4KPgo+IENjOiBCYXJ1Y2ggU2lhY2ggPGJhcnVjaEB0a29zLmNvLmlsPgo+IEZpeGVzOiA1 OTMwY2IzNTExZGYgKHNlcmlhbDogZHJpdmVyIGZvciBDb25leGFudCBEaWdpY29sb3IgVVNBUlQp Cj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmluZW5AbGludXguaW50 ZWwuY29tPgoKQWNrZWQtYnk6IEJhcnVjaCBTaWFjaCA8YmFydWNoQHRrb3MuY28uaWw+CgpUaGFu a3MsCmJhcnVjaAoKPiAtLS0KPiAgZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5j IHwgMiArKwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jIGIvZHJpdmVycy90dHkvc2Vy aWFsL2RpZ2ljb2xvci11c2FydC5jCj4gaW5kZXggNmQ3MGZlYTc2YmIzLi42NWU2NTNlYjUwMjYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jCj4gKysr IGIvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jCj4gQEAgLTMwOSw2ICszMDks OCBAQCBzdGF0aWMgdm9pZCBkaWdpY29sb3JfdWFydF9zZXRfdGVybWlvcyhzdHJ1Y3QgdWFydF9w b3J0ICpwb3J0LAo+ICAJY2FzZSBDUzg6Cj4gIAlkZWZhdWx0Ogo+ICAJCWNvbmZpZyB8PSBVQV9D T05GSUdfQ0hBUl9MRU47Cj4gKwkJdGVybWlvcy0+Y19jZmxhZyAmPSB+Q1NJWkU7Cj4gKwkJdGVy bWlvcy0+Y19jZmxhZyB8PSBDUzg7Cj4gIAkJYnJlYWs7Cj4gIAl9CgoKLS0gCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfi4gLn4gICBUayBPcGVu IFN5c3RlbXMKPX0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS1vb08tLVUtLU9vby0tLS0tLS0tLS0tLXs9CiAgIC0gYmFydWNoQHRrb3MuY28uaWwgLSB0ZWw6 ICs5NzIuNTIuMzY4LjQ2NTYsIGh0dHA6Ly93d3cudGtvcy5jby5pbCAtCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==