From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A49C433F5 for ; Wed, 27 Apr 2022 13:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236766AbiD0Nzj (ORCPT ); Wed, 27 Apr 2022 09:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236700AbiD0Nxs (ORCPT ); Wed, 27 Apr 2022 09:53:48 -0400 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BC5C3F8B5; Wed, 27 Apr 2022 06:50:36 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:40602) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nji3u-00BTkD-8a; Wed, 27 Apr 2022 07:50:34 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:35842 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nji3t-008PdZ-0B; Wed, 27 Apr 2022 07:50:33 -0600 From: "Eric W. Biederman" To: Johannes Berg Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, Oleg Nesterov , mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , inux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn References: <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <20220426225211.308418-3-ebiederm@xmission.com> Date: Wed, 27 Apr 2022 08:50:25 -0500 In-Reply-To: (Johannes Berg's message of "Wed, 27 Apr 2022 09:10:47 +0200") Message-ID: <87tuaeab4u.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nji3t-008PdZ-0B;;;mid=<87tuaeab4u.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX18fBOV3Y1pE4P9eWAoKmnfOqa0I2VzX21o= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 3/9] ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes Berg writes: > On Tue, 2022-04-26 at 17:52 -0500, Eric W. Biederman wrote: >> User mode linux is the last user of the PT_DTRACE flag. Using the flag to indicate >> single stepping is a little confusing and worse changing tsk->ptrace without locking >> could potentionally cause problems. >> >> So use a thread info flag with a better name instead of flag in tsk->ptrace. >> >> Remove the definition PT_DTRACE as uml is the last user. > > > Looks fine to me. > > Acked-by: Johannes Berg Thanks. > Looking at pending patches, I don't see any conflicts from this. I'm > guessing anyway you'll want/need to take these through some tree all > together. Taking them all through a single tree looks like it will be easiest. So I am planning on taking them through my signal tree. Now that I think of it, the lack of locking also means I want to Cc stable. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nji3w-001fLU-BH for linux-um@lists.infradead.org; Wed, 27 Apr 2022 13:50:38 +0000 From: "Eric W. Biederman" References: <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <20220426225211.308418-3-ebiederm@xmission.com> Date: Wed, 27 Apr 2022 08:50:25 -0500 In-Reply-To: (Johannes Berg's message of "Wed, 27 Apr 2022 09:10:47 +0200") Message-ID: <87tuaeab4u.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Subject: Re: [PATCH 3/9] ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Johannes Berg Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, Oleg Nesterov , mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , inux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn Johannes Berg writes: > On Tue, 2022-04-26 at 17:52 -0500, Eric W. Biederman wrote: >> User mode linux is the last user of the PT_DTRACE flag. Using the flag to indicate >> single stepping is a little confusing and worse changing tsk->ptrace without locking >> could potentionally cause problems. >> >> So use a thread info flag with a better name instead of flag in tsk->ptrace. >> >> Remove the definition PT_DTRACE as uml is the last user. > > > Looks fine to me. > > Acked-by: Johannes Berg Thanks. > Looking at pending patches, I don't see any conflicts from this. I'm > guessing anyway you'll want/need to take these through some tree all > together. Taking them all through a single tree looks like it will be easiest. So I am planning on taking them through my signal tree. Now that I think of it, the lack of locking also means I want to Cc stable. Eric _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um