All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
	hreitz@redhat.com, den@openvz.org, eblake@redhat.com
Subject: Re: [PATCH v3 2/9] qapi: make blockdev-add a coroutine command
Date: Mon, 06 Sep 2021 21:28:32 +0200	[thread overview]
Message-ID: <87tuixa4gv.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210906190654.183421-3-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Mon, 6 Sep 2021 22:06:47 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> We are going to support nbd reconnect on open in a next commit. This
> means that we want to do several connection attempts during some time.
> And this should be done in a coroutine, otherwise we'll stuck.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  qapi/block-core.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 06674c25c9..6e4042530a 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4219,7 +4219,8 @@
>  # <- { "return": {} }
>  #
>  ##
> -{ 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true }
> +{ 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true,
> +  'coroutine': true }
>  
>  ##
>  # @blockdev-reopen:

Why is this safe?

Prior discusson:
Message-ID: <87lfq0yp9v.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04921.html



  reply	other threads:[~2021-09-06 19:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 19:06 [PATCH v3 0/9] nbd reconnect on open Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 1/9] nbd/client-connection: nbd_co_establish_connection(): fix non set errp Vladimir Sementsov-Ogievskiy
2021-09-07 17:44   ` Eric Blake
2021-09-24 19:19     ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 2/9] qapi: make blockdev-add a coroutine command Vladimir Sementsov-Ogievskiy
2021-09-06 19:28   ` Markus Armbruster [this message]
2021-09-06 21:40     ` Vladimir Sementsov-Ogievskiy
2021-09-07  6:14       ` Markus Armbruster
2021-09-27 11:25         ` Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 3/9] nbd: allow reconnect on open, with corresponding new options Vladimir Sementsov-Ogievskiy
2021-09-07 20:36   ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 4/9] nbd/client-connection: nbd_co_establish_connection(): return real error Vladimir Sementsov-Ogievskiy
2021-09-07 20:42   ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt Vladimir Sementsov-Ogievskiy
2021-09-07 20:45   ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 6/9] iotests.py: add qemu_tool_popen() Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 7/9] iotests.py: add and use qemu_io_wrap_args() Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 8/9] iotests.py: add qemu_io_popen() Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 9/9] iotests: add nbd-reconnect-on-open test Vladimir Sementsov-Ogievskiy
2021-09-07 20:51   ` Eric Blake
2021-09-08  7:55     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuixa4gv.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.