From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7334AC433EF for ; Fri, 3 Sep 2021 13:13:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38F2060FC0 for ; Fri, 3 Sep 2021 13:13:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38F2060FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM90b-0007Hs-Es for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 09:13:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8vy-0007Aj-1p for qemu-devel@nongnu.org; Fri, 03 Sep 2021 09:08:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8vs-0001N5-Pq for qemu-devel@nongnu.org; Fri, 03 Sep 2021 09:08:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630674516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HNKOxXl702DoCQLssZOle77h7jfycPFUwy0OU8mxiIs=; b=PCiCw3O25bu+XFEwP/uZsta7oAJuR7XG6OV6hePAyZi5fW7+OfwNNYBUdvPDy1xciqIsuR 5nHnthR0hq2C6qHgiUPt+P0mn3CjNwh50Y/PegseE9mvnYU3bWX6JnAxe4ASYAj6hS1DC5 TOualL5h4DSQvTM1wjXl2MJDmJRdKxI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-bH-QvjyWMV2wwlPsN4XgnA-1; Fri, 03 Sep 2021 09:08:35 -0400 X-MC-Unique: bH-QvjyWMV2wwlPsN4XgnA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBB5B8015C7; Fri, 3 Sep 2021 13:08:33 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E8EA6B547; Fri, 3 Sep 2021 13:08:33 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4699411380BA; Wed, 1 Sep 2021 15:19:26 +0200 (CEST) From: Markus Armbruster To: Daniel Henrique Barboza Subject: Re: [PATCH v7 5/7] qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event References: <20210825004835.472919-1-danielhb413@gmail.com> <20210825004835.472919-6-danielhb413@gmail.com> Date: Wed, 01 Sep 2021 15:19:26 +0200 In-Reply-To: <20210825004835.472919-6-danielhb413@gmail.com> (Daniel Henrique Barboza's message of "Tue, 24 Aug 2021 21:48:33 -0300") Message-ID: <87tuj4a0wx.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_24_48=1.34, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: groug@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel Henrique Barboza writes: > At this moment we only provide one event to report a hotunplug error, > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > machine is now able to report unplug errors for other device types, such > as CPUs. > > Instead of creating a (device_type)_UNPLUG_ERROR for each new device, > create a generic DEVICE_UNPLUG_GUEST_ERROR event that can be used by all > guest side unplug errors in the future. This event has a similar API as > the existing DEVICE_DELETED event, always providing the QOM path of the > device and dev->id if there's any. > > With this new generic event, MEM_UNPLUG_ERROR is now marked as deprecated. > > Signed-off-by: Daniel Henrique Barboza > --- [...] > diff --git a/qapi/qdev.json b/qapi/qdev.json > index 0e9cb2ae88..8b1a1dd43b 100644 > --- a/qapi/qdev.json > +++ b/qapi/qdev.json > @@ -84,7 +84,9 @@ > # This command merely requests that the guest begin the hot removal > # process. Completion of the device removal process is signaled with a > # DEVICE_DELETED event. Guest reset will automatically complete removal > -# for all devices. > +# for all devices. If a guest-side error in the hot removal process is > +# detected, the device will not be removed and a DEVICE_UNPLUG_GUEST_ERROR > +# event is sent. Some errors cannot be detected. > # > # Since: 0.14 > # > @@ -124,3 +126,27 @@ > ## > { 'event': 'DEVICE_DELETED', > 'data': { '*device': 'str', 'path': 'str' } } > + > +## > +# @DEVICE_UNPLUG_GUEST_ERROR: > +# > +# Emitted when a device hot unplug fails due to an internal guest > +# error. Suggest to scratch "internal". > +# > +# @device: the device's ID if it has one > +# > +# @path: the device's QOM path > +# > +# Since: 6.2 > +# > +# Example: > +# > +# <- { "event": "DEVICE_UNPLUG_GUEST_ERROR" > +# "data": { "device": "core1", > +# "path": "/machine/peripheral/core1" }, > +# }, > +# "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } > +# > +## > +{ 'event': 'DEVICE_UNPLUG_GUEST_ERROR', > + 'data': { '*device': 'str', 'path': 'str' } } [...]