From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed
Date: Tue, 24 Aug 2021 14:05:39 +0200 [thread overview]
Message-ID: <87tujfdp4c.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA-2ShxjS6YAb_xBk=v5YJ5nLaaKtOLVEn7Vjfe6rkpp2A@mail.gmail.com> (Peter Maydell's message of "Tue, 24 Aug 2021 10:19:44 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Tue, 24 Aug 2021 at 09:14, Markus Armbruster <armbru@redhat.com> wrote:
>> In functions with an Error **errp parameter, use of &error_fatal is
>> almost always wrong.
>
> What are the cases where it is not wrong?
I can't think of a use that isn't wrong. Doesn't mean no such use could
exist. Most rules have exceptions...
> My guess is "in board
> code and other places where the error handling would have been
> 'print a message and call exit()' anyway".
When you know that all callers handle errors like &error_fatal does, use
of &error_fatal doesn't produce wrong behavior. It's still kind of
wrong, because relying on such a non-local argument without a genuine
need is.
next prev parent reply other threads:[~2021-08-24 12:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 17:15 [PATCH v2 0/3] hw/usb: Always expect 'dma' link property to be set to simplify Philippe Mathieu-Daudé
2021-08-19 17:15 ` [PATCH v2 1/3] hw/pci: Introduce pci_dma_memory_region() helper Philippe Mathieu-Daudé
2021-08-19 17:15 ` [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed Philippe Mathieu-Daudé
2021-08-23 18:34 ` Eduardo Habkost
2021-08-24 8:13 ` Markus Armbruster
2021-08-24 8:35 ` Philippe Mathieu-Daudé
2021-08-24 8:46 ` Philippe Mathieu-Daudé
2021-08-24 9:19 ` Peter Maydell
2021-08-24 12:05 ` Markus Armbruster [this message]
2021-08-24 12:16 ` Peter Maydell
2021-08-24 13:57 ` Eduardo Habkost
2021-08-24 14:24 ` Peter Maydell
2021-08-24 14:29 ` Markus Armbruster
2021-08-24 14:27 ` Markus Armbruster
2021-08-24 14:30 ` Peter Maydell
2021-08-24 15:15 ` Markus Armbruster
2021-08-24 15:19 ` Peter Maydell
2021-08-25 7:48 ` Markus Armbruster
2021-08-19 17:15 ` [PATCH v2 3/3] hw/usb/xhci: Always expect 'dma' link property to be set Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tujfdp4c.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.