From: Nikolaus Rath <Nikolaus@rath.org>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: fuse-devel@lists.sourceforge.net, virtio-fs@redhat.com,
vgoyal@redhat.com
Subject: Re: [Virtio-fs] [fuse-devel] 'FORGET' ordering semantics (vs unlink & NFS)
Date: Tue, 05 Jan 2021 10:11:41 +0000 [thread overview]
Message-ID: <87turvsnfm.fsf@vostro.rath.org> (raw)
In-Reply-To: <20210104160013.GG2972@work-vm> (David Alan Gilbert's message of "Mon, 4 Jan 2021 16:00:13 +0000")
On Jan 04 2021, "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> Hi,
> On virtio-fs we're hitting a problem with NFS, where
> unlinking a file in a directory and then rmdir'ing that
> directory fails complaining about the directory not being empty.
>
> The problem here is that if a file has an open fd, NFS doesn't
> actually delete the file on unlink, it just renames it to
> a hidden file (e.g. .nfs*******). That open file is there because
> the 'FORGET' hasn't completed yet by the time the rmdir is issued.
Are you really talking about FORGET and file descriptors here? I always
assumed that the kernel will only drop dentries (aka emit FORGET) when
all fds are closed and never saw otherwise in practice.
Do you mean RELEASE rather than FORGET, or dentry rather than file descriptor?
Best,
-Nikolaus
--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«
next prev parent reply other threads:[~2021-01-05 10:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 16:00 [Virtio-fs] 'FORGET' ordering semantics (vs unlink & NFS) Dr. David Alan Gilbert
2021-01-04 18:45 ` Vivek Goyal
2021-01-04 18:56 ` Dr. David Alan Gilbert
2021-01-04 19:04 ` Vivek Goyal
2021-01-04 19:16 ` Vivek Goyal
2021-01-05 11:24 ` [Virtio-fs] [fuse-devel] " Miklos Szeredi
2021-01-05 15:42 ` Vivek Goyal
2021-01-06 4:29 ` Amir Goldstein
2021-01-06 8:01 ` Miklos Szeredi
2021-01-06 9:16 ` Amir Goldstein
2021-01-06 9:27 ` Amir Goldstein
2021-01-06 13:40 ` Miklos Szeredi
2021-01-06 16:57 ` Vivek Goyal
2021-01-07 8:44 ` Miklos Szeredi
2021-01-07 10:42 ` Amir Goldstein
2021-01-07 20:10 ` Dr. David Alan Gilbert
2021-01-08 4:12 ` Eryu Guan
2021-01-08 9:08 ` Amir Goldstein
2021-01-08 9:25 ` Liu, Jiang
2021-01-08 10:18 ` Eryu Guan
2021-01-08 15:26 ` Vivek Goyal
2021-01-15 10:20 ` Peng Tao
2021-01-08 15:55 ` Vivek Goyal
2021-01-11 15:48 ` Dr. David Alan Gilbert
2021-01-05 10:11 ` Nikolaus Rath [this message]
2021-01-05 12:28 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87turvsnfm.fsf@vostro.rath.org \
--to=nikolaus@rath.org \
--cc=dgilbert@redhat.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.