From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CB5C433E0 for ; Tue, 7 Jul 2020 14:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8352620771 for ; Tue, 7 Jul 2020 14:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t8Q3pm/E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgGGOn0 (ORCPT ); Tue, 7 Jul 2020 10:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbgGGOn0 (ORCPT ); Tue, 7 Jul 2020 10:43:26 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B72B3C061755; Tue, 7 Jul 2020 07:43:25 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id e4so50228359ljn.4; Tue, 07 Jul 2020 07:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=unO6FiP6OsS3N2Z7cCD5xgoqJV/rBl4QePI8AwEUtKI=; b=t8Q3pm/EebY/Ch0SzzzydJR8YQhigTS96x782Gpzfd/vjXS28SkfmriJ+7nMIvF4U2 ENlu+W27Dbw/XDhRZBifVSYG9srZrFs2mZR3GUpie0yaJt60LvjeZnVKebmRcBqSBZWo 4kQGn4P+ibBsH1XoNe/qMqRjkedgt8x13Yy/9mjasM0PVn32EHLNq3DKxcJDNREWXxAW PcQOIywqPi6PTQVYpowvyS78yNuSiriRmjPf1tAHNKz1o9UDwAicgBuwSaMDIagFPXYV 6XnR2KymbLRc8YNNxhtLa2VlRwk8Kb5D2m/E0NFIADQ0V2rXELuCoEUrCHQ0BeD80pa2 3+xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=unO6FiP6OsS3N2Z7cCD5xgoqJV/rBl4QePI8AwEUtKI=; b=GGl+lT7j/3PAGNbt/h6joatEYNZILvlvXk74MsGn68AlJykerCK8JeH08TFXarP9AJ ZaGPLwb2zy8YIY+L9sFRMWlnr07R9vnN4gY79tphQVdMw/lfNfLZq1+LuBavTRZ2cb5+ 6Oq0AZFqnACu2B+G4Yq3cI4G2RWEucFNh87uN4AFMYQJqhWyS45HY+/1tpkUJUtnuVB0 nB0zObc8qaHAJpzFt0+s1Qcj1aC8t2F6BQw82s91aFn2VomlqYFufoUk9vi939JgGwRK 0CJad3Iok0AbNjnP1LYcZl7+WzgDFO/VgWrfxfiFRMZoUB9xOWU+14D7TktrjmwoQ8pD qJNg== X-Gm-Message-State: AOAM532NExW/s5yPrxBMRQoph8GnK+bVa8FXvLodnzLl5PMioylwvcCg HLqN1l7fzwGqBcD1AWZjM3Q= X-Google-Smtp-Source: ABdhPJzxQ2Qnzpm6uIBNS8CYeYZEhUMsxENBOQYvUw27cbo6bsvopxb0tqpMtxD5LBvd24mTG4HeIw== X-Received: by 2002:a2e:81c4:: with SMTP id s4mr28393624ljg.284.1594133004279; Tue, 07 Jul 2020 07:43:24 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id k20sm199996ljc.111.2020.07.07.07.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 07:43:23 -0700 (PDT) From: Sergey Organov To: Andy Duan Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Jakub Kicinski Subject: Re: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set() References: <20200706142616.25192-1-sorganov@gmail.com> <20200706142616.25192-5-sorganov@gmail.com> Date: Tue, 07 Jul 2020 17:43:22 +0300 In-Reply-To: (Andy Duan's message of "Tue, 7 Jul 2020 04:08:08 +0000") Message-ID: <87tuyj8jxx.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Duan writes: > From: Sergey Organov Sent: Monday, July 6, 2020 10:26 PM >> Code of the form "if(x) x = 0" replaced with "x = 0". >> >> Code of the form "if(x == a) x = a" removed. >> >> Signed-off-by: Sergey Organov >> --- >> drivers/net/ethernet/freescale/fec_ptp.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c >> b/drivers/net/ethernet/freescale/fec_ptp.c >> index e455343..4152cae 100644 >> --- a/drivers/net/ethernet/freescale/fec_ptp.c >> +++ b/drivers/net/ethernet/freescale/fec_ptp.c >> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev, struct ifreq >> *ifr) >> >> switch (config.rx_filter) { >> case HWTSTAMP_FILTER_NONE: >> - if (fep->hwts_rx_en) >> - fep->hwts_rx_en = 0; >> - config.rx_filter = HWTSTAMP_FILTER_NONE; > The line should keep according your commit log. You mean I should fix commit log like this: Code of the form "switch(x) case a: x = a; break" removed. ? I'll do if it's cleaner that way. Thanks, -- Sergey > >> + fep->hwts_rx_en = 0; >> break; >> >> default: >> -- >> 2.10.0.1.g57b01a3