From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C665C433E0 for ; Tue, 19 May 2020 04:17:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAAD92072C for ; Tue, 19 May 2020 04:17:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="h5gcpidD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAAD92072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2498917A4; Tue, 19 May 2020 06:16:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2498917A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589861863; bh=aSFJHLjcQDrSRxhim6KMl0BfgKL15RmCrSfkKUT+9MQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=h5gcpidDLJrhW39QtMvq3qFfeBhwcfO9Ei57hi3pS6/Jeqg09dIOpsCINLyf0Q/5l SPMOz1w/LsuobJF5ZfjXHN3ZigEp5LDCwi9BOgFYRB4W7M2XZISoPeioo4gyw4dzR9 LTRgmNPt94n3pZP9HFflvwvUPKrAzEqMzc+zI+xs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A8597F80132; Tue, 19 May 2020 06:16:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 754DFF801A3; Tue, 19 May 2020 06:16:50 +0200 (CEST) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 68A93F80132 for ; Tue, 19 May 2020 06:16:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 68A93F80132 Date: 19 May 2020 13:16:33 +0900 X-IronPort-AV: E=Sophos;i="5.73,408,1583161200"; d="scan'208";a="47435643" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 19 May 2020 13:16:33 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id E833D40065D7; Tue, 19 May 2020 13:16:32 +0900 (JST) Message-ID: <87tv0c4l0f.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Ranjani Sridharan Subject: Re: [PATCH 4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup() In-Reply-To: <3e3c0f3247b1759fb640601bc55ff07cb8e2e92b.camel@linux.intel.com> References: <877dx868op.wl-kuninori.morimoto.gx@renesas.com> <871rng68l1.wl-kuninori.morimoto.gx@renesas.com> <3e3c0f3247b1759fb640601bc55ff07cb8e2e92b.camel@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Ranjani Thank you for reviewing > > From: Kuninori Morimoto > > > > dai_link related function should be implemented at soc-link.c. > > This patch adds snd_soc_link_be_hw_params_fixup(). > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > > + if (ret < 0) { > > + dev_err(be->dev, > > + "ASoC: hw_params BE fixup failed %d\n", > > ret); > We can remove this error too isnt it? snd_soc_link_be_hw_params_fixup() > would already have printed an error and this would be a duplicate? Oh, yes. Will fixup it in v2 Thank you for your help !! Best regards --- Kuninori Morimoto