From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E31C2BB1D for ; Tue, 14 Apr 2020 06:16:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7123F206E9 for ; Tue, 14 Apr 2020 06:16:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7123F206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1ED698E0003; Tue, 14 Apr 2020 02:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19C808E0001; Tue, 14 Apr 2020 02:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 064578E0003; Tue, 14 Apr 2020 02:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id E2DC28E0001 for ; Tue, 14 Apr 2020 02:16:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 94D1152BB for ; Tue, 14 Apr 2020 06:16:28 +0000 (UTC) X-FDA: 76705451256.22.anger40_8fbf0ecc0b336 X-HE-Tag: anger40_8fbf0ecc0b336 X-Filterd-Recvd-Size: 5729 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 06:16:27 +0000 (UTC) Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jOErv-0006zd-Cp; Tue, 14 Apr 2020 00:16:23 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jOEru-0001V9-HH; Tue, 14 Apr 2020 00:16:23 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Andrew Morton Cc: Baoquan He , Russell King - ARM Linux admin , Anshuman Khandual , Catalin Marinas , Bhupesh Sharma , David Hildenbrand , kexec@lists.infradead.org, linux-mm@kvack.org, James Morse , Will Deacon , linux-arm-kernel@lists.infradead.org References: <34274b02-60ba-eb78-eacd-6dc1146ed3cd@arm.com> <80e4d1d7-f493-3f66-f700-86f18002d692@redhat.com> <20200410121013.03b609fd572504c03a666f4a@linux-foundation.org> <20200411034414.GH2129@MiWiFi-R3L-srv> <20200411093009.GH25745@shell.armlinux.org.uk> <20200412053507.GA4247@MiWiFi-R3L-srv> <20200412080836.GM25745@shell.armlinux.org.uk> <87wo6klbw0.fsf@x220.int.ebiederm.org> <20200413023701.GA20265@MiWiFi-R3L-srv> <871rorjzmc.fsf@x220.int.ebiederm.org> <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> Date: Tue, 14 Apr 2020 01:13:25 -0500 In-Reply-To: <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> (Andrew Morton's message of "Mon, 13 Apr 2020 16:01:44 -0700") Message-ID: <87tv1miohm.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jOEru-0001V9-HH;;;mid=<87tv1miohm.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18EIUyySboFEvwkJvY092/gKs+mtMsheRQ= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 1/3] kexec: Prevent removal of memory in use by a loaded kexec image X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Mon, 13 Apr 2020 08:15:23 -0500 ebiederm@xmission.com (Eric W. Biederman) wrote: > >> > For 3), people can still use kexec_load and develop/fix for it, if no >> > kexec_file_load supported. But 32-bit arm should be a different one, >> > more like i386, we will leave it as is, and fix anything which could >> > break it. But people really expects to improve or add feature to it? E.g >> > in this patchset, the mem hotplug issue James raised, I assume James is >> > focusing on arm64, x86_64, but not 32-bit arm. As DavidH commented in >> > another reply, people even don't agree to continue supporting memory >> > hotplug on 32-bit system. We ever took effort to fix a memory hotplug >> > bug on i386 with a patch, but people would rather set it as BROKEN. >> >> For memory hotplug just reload. Userspace already gets good events. >> >> We should not expect anything except a panic kernel to be loaded over a >> memory hotplug event. The kexec on panic code should actually be loaded >> in a location that we don't reliquish if asked for it. > > Is that a nack for James's patchset? I have just read the end of the thread and I have the sense that the patchset had already been rejected. I will see if I can go back and read the beginning. I was mostly reacting to the idea that you could stop maintaining an interface that people are actively using because there is a newer interface. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78BCC2BB1D for ; Tue, 14 Apr 2020 06:16:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98C0B206E9 for ; Tue, 14 Apr 2020 06:16:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="orf4+0Ex" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C0B206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID: In-Reply-To:Date:References:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYSV2aHHz+2wVgNongD6xScaPPwQPrkpAxSgORQacSs=; b=orf4+0Ex2SHiLh vsy5/gzFfkFahBq0L44M3STcb7uhXGwmNqKTbP0ociq6OVCQm9NEJn0o6cT8ez2NYBd7yNO6T1LCT +lBRWH7Gv8Yv2YrGhCp7vBUGTqaNlsPbpkMHmaWUtFraJK2jSxCufEO8al/TCaqcnaao9AKw07Lst wXC72Ml28RIhfLNWJqA5nx2q3ww1gJKQhRxVRSNInrfCd7DVM3/DGNYKmvMDSvoFBNrla8ESiBqj0 U5xERqQYPj5x6l4g9/ulCupmUE36vvMGAKVjUbGWwyYoIRZc1daPviS8e4mzs9ero2nwX+T1s47jc Hlgt9O1S2XLPO9pUpCaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOEsP-0003A1-Vb; Tue, 14 Apr 2020 06:16:53 +0000 Received: from out02.mta.xmission.com ([166.70.13.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOEsM-00037q-JA; Tue, 14 Apr 2020 06:16:51 +0000 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jOErv-0006zd-Cp; Tue, 14 Apr 2020 00:16:23 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jOEru-0001V9-HH; Tue, 14 Apr 2020 00:16:23 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Andrew Morton References: <34274b02-60ba-eb78-eacd-6dc1146ed3cd@arm.com> <80e4d1d7-f493-3f66-f700-86f18002d692@redhat.com> <20200410121013.03b609fd572504c03a666f4a@linux-foundation.org> <20200411034414.GH2129@MiWiFi-R3L-srv> <20200411093009.GH25745@shell.armlinux.org.uk> <20200412053507.GA4247@MiWiFi-R3L-srv> <20200412080836.GM25745@shell.armlinux.org.uk> <87wo6klbw0.fsf@x220.int.ebiederm.org> <20200413023701.GA20265@MiWiFi-R3L-srv> <871rorjzmc.fsf@x220.int.ebiederm.org> <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> Date: Tue, 14 Apr 2020 01:13:25 -0500 In-Reply-To: <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> (Andrew Morton's message of "Mon, 13 Apr 2020 16:01:44 -0700") Message-ID: <87tv1miohm.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-XM-SPF: eid=1jOEru-0001V9-HH; ; ; mid=<87tv1miohm.fsf@x220.int.ebiederm.org>; ; ; hst=in01.mta.xmission.com; ; ; ip=68.227.160.95; ; ; frm=ebiederm@xmission.com; ; ; spf=neutral X-XM-AID: U2FsdGVkX18EIUyySboFEvwkJvY092/gKs+mtMsheRQ= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 1/3] kexec: Prevent removal of memory in use by a loaded kexec image X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200413_231650_630554_D8F23CFF X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baoquan He , David Hildenbrand , Catalin Marinas , Bhupesh Sharma , Anshuman Khandual , kexec@lists.infradead.org, Russell King - ARM Linux admin , linux-mm@kvack.org, James Morse , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew Morton writes: > On Mon, 13 Apr 2020 08:15:23 -0500 ebiederm@xmission.com (Eric W. Biederman) wrote: > >> > For 3), people can still use kexec_load and develop/fix for it, if no >> > kexec_file_load supported. But 32-bit arm should be a different one, >> > more like i386, we will leave it as is, and fix anything which could >> > break it. But people really expects to improve or add feature to it? E.g >> > in this patchset, the mem hotplug issue James raised, I assume James is >> > focusing on arm64, x86_64, but not 32-bit arm. As DavidH commented in >> > another reply, people even don't agree to continue supporting memory >> > hotplug on 32-bit system. We ever took effort to fix a memory hotplug >> > bug on i386 with a patch, but people would rather set it as BROKEN. >> >> For memory hotplug just reload. Userspace already gets good events. >> >> We should not expect anything except a panic kernel to be loaded over a >> memory hotplug event. The kexec on panic code should actually be loaded >> in a location that we don't reliquish if asked for it. > > Is that a nack for James's patchset? I have just read the end of the thread and I have the sense that the patchset had already been rejected. I will see if I can go back and read the beginning. I was mostly reacting to the idea that you could stop maintaining an interface that people are actively using because there is a newer interface. Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: ebiederm@xmission.com (Eric W. Biederman) References: <34274b02-60ba-eb78-eacd-6dc1146ed3cd@arm.com> <80e4d1d7-f493-3f66-f700-86f18002d692@redhat.com> <20200410121013.03b609fd572504c03a666f4a@linux-foundation.org> <20200411034414.GH2129@MiWiFi-R3L-srv> <20200411093009.GH25745@shell.armlinux.org.uk> <20200412053507.GA4247@MiWiFi-R3L-srv> <20200412080836.GM25745@shell.armlinux.org.uk> <87wo6klbw0.fsf@x220.int.ebiederm.org> <20200413023701.GA20265@MiWiFi-R3L-srv> <871rorjzmc.fsf@x220.int.ebiederm.org> <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> Date: Tue, 14 Apr 2020 01:13:25 -0500 In-Reply-To: <20200413160144.0e07c0033afc474228bc9218@linux-foundation.org> (Andrew Morton's message of "Mon, 13 Apr 2020 16:01:44 -0700") Message-ID: <87tv1miohm.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Subject: Re: [PATCH 1/3] kexec: Prevent removal of memory in use by a loaded kexec image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Andrew Morton Cc: Baoquan He , David Hildenbrand , Catalin Marinas , Bhupesh Sharma , Anshuman Khandual , kexec@lists.infradead.org, Russell King - ARM Linux admin , linux-mm@kvack.org, James Morse , Will Deacon , linux-arm-kernel@lists.infradead.org Andrew Morton writes: > On Mon, 13 Apr 2020 08:15:23 -0500 ebiederm@xmission.com (Eric W. Biederman) wrote: > >> > For 3), people can still use kexec_load and develop/fix for it, if no >> > kexec_file_load supported. But 32-bit arm should be a different one, >> > more like i386, we will leave it as is, and fix anything which could >> > break it. But people really expects to improve or add feature to it? E.g >> > in this patchset, the mem hotplug issue James raised, I assume James is >> > focusing on arm64, x86_64, but not 32-bit arm. As DavidH commented in >> > another reply, people even don't agree to continue supporting memory >> > hotplug on 32-bit system. We ever took effort to fix a memory hotplug >> > bug on i386 with a patch, but people would rather set it as BROKEN. >> >> For memory hotplug just reload. Userspace already gets good events. >> >> We should not expect anything except a panic kernel to be loaded over a >> memory hotplug event. The kexec on panic code should actually be loaded >> in a location that we don't reliquish if asked for it. > > Is that a nack for James's patchset? I have just read the end of the thread and I have the sense that the patchset had already been rejected. I will see if I can go back and read the beginning. I was mostly reacting to the idea that you could stop maintaining an interface that people are actively using because there is a newer interface. Eric _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec