* [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long
@ 2020-04-07 8:59 Chris Wilson
2020-04-07 9:21 ` Mika Kuoppala
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Chris Wilson @ 2020-04-07 8:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Tidy the code by casting remain to unsigned long once for the duration
of eb_relocate_vma()
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index d9ab517bbce9..c95dc09c4c93 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1508,11 +1508,11 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct eb_vma *ev)
struct drm_i915_gem_relocation_entry stack[N_RELOC(512)];
struct drm_i915_gem_relocation_entry __user *urelocs;
const struct drm_i915_gem_exec_object2 *entry = ev->exec;
- unsigned int remain;
+ unsigned long remain;
urelocs = u64_to_user_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
- if (unlikely((unsigned long)remain > N_RELOC(ULONG_MAX)))
+ if (unlikely(remain > N_RELOC(ULONG_MAX)))
return -EINVAL;
/*
@@ -1520,13 +1520,12 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct eb_vma *ev)
* to read. However, if the array is not writable the user loses
* the updated relocation values.
*/
- if (unlikely(!access_ok(urelocs, remain*sizeof(*urelocs))))
+ if (unlikely(!access_ok(urelocs, remain * sizeof(*urelocs))))
return -EFAULT;
do {
struct drm_i915_gem_relocation_entry *r = stack;
- unsigned int count =
- min_t(unsigned int, remain, ARRAY_SIZE(stack));
+ unsigned int count = min(remain, ARRAY_SIZE(stack));
unsigned int copied;
/*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
@ 2020-04-07 9:21 ` Mika Kuoppala
2020-04-07 10:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2020-04-07 9:21 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Tidy the code by casting remain to unsigned long once for the duration
> of eb_relocate_vma()
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index d9ab517bbce9..c95dc09c4c93 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -1508,11 +1508,11 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct eb_vma *ev)
> struct drm_i915_gem_relocation_entry stack[N_RELOC(512)];
> struct drm_i915_gem_relocation_entry __user *urelocs;
> const struct drm_i915_gem_exec_object2 *entry = ev->exec;
> - unsigned int remain;
> + unsigned long remain;
>
> urelocs = u64_to_user_ptr(entry->relocs_ptr);
> remain = entry->relocation_count;
> - if (unlikely((unsigned long)remain > N_RELOC(ULONG_MAX)))
> + if (unlikely(remain > N_RELOC(ULONG_MAX)))
> return -EINVAL;
>
> /*
> @@ -1520,13 +1520,12 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct eb_vma *ev)
> * to read. However, if the array is not writable the user loses
> * the updated relocation values.
> */
> - if (unlikely(!access_ok(urelocs, remain*sizeof(*urelocs))))
> + if (unlikely(!access_ok(urelocs, remain * sizeof(*urelocs))))
> return -EFAULT;
>
> do {
> struct drm_i915_gem_relocation_entry *r = stack;
> - unsigned int count =
> - min_t(unsigned int, remain, ARRAY_SIZE(stack));
> + unsigned int count = min(remain, ARRAY_SIZE(stack));
> unsigned int copied;
>
> /*
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Promote 'remain' to unsigned long
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
2020-04-07 9:21 ` Mika Kuoppala
@ 2020-04-07 10:20 ` Patchwork
2020-04-07 10:20 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-04-07 10:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Promote 'remain' to unsigned long
URL : https://patchwork.freedesktop.org/series/75600/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8264 -> Patchwork_17231
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/index.html
Known issues
------------
Here are the changes found in Patchwork_17231 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-icl-dsi: [PASS][1] -> [INCOMPLETE][2] ([i915#1580])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][3] ([i915#1158]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [INCOMPLETE][5] ([i915#1580]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-icl-y/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/fi-icl-y/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([i915#665] / [i915#704])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1158]: https://gitlab.freedesktop.org/drm/intel/issues/1158
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
[i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665
[i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704
Participating hosts (53 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8264 -> Patchwork_17231
CI-20190529: 20190529
CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17231: 19e4a486e221d78b813f329cb88c4688fc4a5002 @ git://anongit.freedesktop.org/gfx-ci/linux
== Kernel 32bit build ==
Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/Patchwork_17231/build_32bit.log
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o
In file included from ./include/linux/iova.h:13:0,
from ./include/linux/intel-iommu.h:14,
from drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:7:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function ‘eb_relocate_vma’:
./include/linux/kernel.h:835:29: error: comparison of distinct pointer types lacks a cast [-Werror]
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
./include/linux/kernel.h:849:4: note: in expansion of macro ‘__typecheck’
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~
./include/linux/kernel.h:859:24: note: in expansion of macro ‘__safe_cmp’
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~
./include/linux/kernel.h:868:19: note: in expansion of macro ‘__careful_cmp’
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1523:24: note: in expansion of macro ‘min’
unsigned int count = min(remain, ARRAY_SIZE(stack));
^~~
cc1: all warnings being treated as errors
scripts/Makefile.build:267: recipe for target 'drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o' failed
make[4]: *** [drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o] Error 1
scripts/Makefile.build:505: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:505: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:505: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1683: recipe for target 'drivers' failed
make: *** [drivers] Error 2
== Linux commits ==
19e4a486e221 drm/i915/gem: Promote 'remain' to unsigned long
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/gem: Promote 'remain' to unsigned long
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
2020-04-07 9:21 ` Mika Kuoppala
2020-04-07 10:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-04-07 10:20 ` Patchwork
2020-04-07 15:41 ` [Intel-gfx] [PATCH] " kbuild test robot
2020-04-07 16:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-04-07 10:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Promote 'remain' to unsigned long
URL : https://patchwork.freedesktop.org/series/75600/
State : warning
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o
In file included from ./include/linux/iova.h:13:0,
from ./include/linux/intel-iommu.h:14,
from drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:7:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function ‘eb_relocate_vma’:
./include/linux/kernel.h:835:29: error: comparison of distinct pointer types lacks a cast [-Werror]
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
./include/linux/kernel.h:849:4: note: in expansion of macro ‘__typecheck’
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~
./include/linux/kernel.h:859:24: note: in expansion of macro ‘__safe_cmp’
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~
./include/linux/kernel.h:868:19: note: in expansion of macro ‘__careful_cmp’
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1523:24: note: in expansion of macro ‘min’
unsigned int count = min(remain, ARRAY_SIZE(stack));
^~~
cc1: all warnings being treated as errors
scripts/Makefile.build:267: recipe for target 'drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o' failed
make[4]: *** [drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o] Error 1
scripts/Makefile.build:505: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:505: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:505: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1683: recipe for target 'drivers' failed
make: *** [drivers] Error 2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/build_32bit.log
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
` (2 preceding siblings ...)
2020-04-07 10:20 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
@ 2020-04-07 15:41 ` kbuild test robot
2020-04-07 16:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2020-04-07 15:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5579 bytes --]
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on next-20200406]
[cannot apply to drm-intel/for-linux-next v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gem-Promote-remain-to-unsigned-long/20200407-185221
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/iova.h:13:0,
from include/linux/intel-iommu.h:14,
from drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:7:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function 'eb_relocate_vma':
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~
include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~
include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1523:24: note: in expansion of macro 'min'
unsigned int count = min(remain, ARRAY_SIZE(stack));
^~~
vim +/min +1523 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
1499
1500 static int eb_relocate_vma(struct i915_execbuffer *eb, struct eb_vma *ev)
1501 {
1502 #define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
1503 struct drm_i915_gem_relocation_entry stack[N_RELOC(512)];
1504 struct drm_i915_gem_relocation_entry __user *urelocs;
1505 const struct drm_i915_gem_exec_object2 *entry = ev->exec;
1506 unsigned long remain;
1507
1508 urelocs = u64_to_user_ptr(entry->relocs_ptr);
1509 remain = entry->relocation_count;
1510 if (unlikely(remain > N_RELOC(ULONG_MAX)))
1511 return -EINVAL;
1512
1513 /*
1514 * We must check that the entire relocation array is safe
1515 * to read. However, if the array is not writable the user loses
1516 * the updated relocation values.
1517 */
1518 if (unlikely(!access_ok(urelocs, remain * sizeof(*urelocs))))
1519 return -EFAULT;
1520
1521 do {
1522 struct drm_i915_gem_relocation_entry *r = stack;
> 1523 unsigned int count = min(remain, ARRAY_SIZE(stack));
1524 unsigned int copied;
1525
1526 /*
1527 * This is the fast path and we cannot handle a pagefault
1528 * whilst holding the struct mutex lest the user pass in the
1529 * relocations contained within a mmaped bo. For in such a case
1530 * we, the page fault handler would call i915_gem_fault() and
1531 * we would try to acquire the struct mutex again. Obviously
1532 * this is bad and so lockdep complains vehemently.
1533 */
1534 copied = __copy_from_user(r, urelocs, count * sizeof(r[0]));
1535 if (unlikely(copied)) {
1536 remain = -EFAULT;
1537 goto out;
1538 }
1539
1540 remain -= count;
1541 do {
1542 u64 offset = eb_relocate_entry(eb, ev, r);
1543
1544 if (likely(offset == 0)) {
1545 } else if ((s64)offset < 0) {
1546 remain = (int)offset;
1547 goto out;
1548 } else {
1549 /*
1550 * Note that reporting an error now
1551 * leaves everything in an inconsistent
1552 * state as we have *already* changed
1553 * the relocation value inside the
1554 * object. As we have not changed the
1555 * reloc.presumed_offset or will not
1556 * change the execobject.offset, on the
1557 * call we may not rewrite the value
1558 * inside the object, leaving it
1559 * dangling and causing a GPU hang. Unless
1560 * userspace dynamically rebuilds the
1561 * relocations on each execbuf rather than
1562 * presume a static tree.
1563 *
1564 * We did previously check if the relocations
1565 * were writable (access_ok), an error now
1566 * would be a strange race with mprotect,
1567 * having already demonstrated that we
1568 * can read from this userspace address.
1569 */
1570 offset = gen8_canonical_addr(offset & ~UPDATE);
1571 __put_user(offset,
1572 &urelocs[r - stack].presumed_offset);
1573 }
1574 } while (r++, --count);
1575 urelocs += ARRAY_SIZE(stack);
1576 } while (remain);
1577 out:
1578 reloc_cache_reset(&eb->reloc_cache);
1579 return remain;
1580 }
1581
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71902 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Promote 'remain' to unsigned long
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
` (3 preceding siblings ...)
2020-04-07 15:41 ` [Intel-gfx] [PATCH] " kbuild test robot
@ 2020-04-07 16:30 ` Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-04-07 16:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gem: Promote 'remain' to unsigned long
URL : https://patchwork.freedesktop.org/series/75600/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17231_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17231_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17231_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17231_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@engines-mixed-process@rcs0:
- shard-tglb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb5/igt@gem_ctx_persistence@engines-mixed-process@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-tglb8/igt@gem_ctx_persistence@engines-mixed-process@rcs0.html
Known issues
------------
Here are the changes found in Patchwork_17231_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#69]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl3/igt@i915_pm_backlight@fade_with_suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl10/igt@i915_pm_backlight@fade_with_suspend.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#54] / [i915#93] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#300]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][13] -> [INCOMPLETE][14] ([i915#221])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl3/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#1487])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-glk7/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#173])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb8/igt@kms_psr@no_drrs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-apl2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_exec_balancer@hang:
- shard-tglb: [FAIL][27] ([i915#1277]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb6/igt@gem_exec_balancer@hang.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-tglb1/igt@gem_exec_balancer@hang.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-skl: [FAIL][29] ([i915#138]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl5/igt@i915_pm_rpm@basic-pci-d3-state.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl9/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@blt:
- shard-snb: [DMESG-FAIL][31] ([i915#1409]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb4/igt@i915_selftest@live@blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-snb2/igt@i915_selftest@live@blt.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][33] ([fdo#109349]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-WARN][35] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-glk: [FAIL][37] ([i915#34]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-glk4/igt@kms_flip@2x-plain-flip-ts-check.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: [FAIL][39] ([i915#79]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl4/igt@kms_flip@flip-vs-expired-vblank.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-apl4/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][43] ([i915#1188]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl3/igt@kms_hdr@bpc-switch.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl10/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-snb: [DMESG-WARN][45] ([i915#42]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-snb7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][47] ([fdo#108145] / [i915#265]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-kbl: [DMESG-WARN][49] ([i915#165] / [i915#78]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_plane_lowres@pipe-a-tiling-none.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl6/igt@kms_plane_lowres@pipe-a-tiling-none.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-skl: [FAIL][53] ([i915#31]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl3/igt@kms_setmode@basic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-skl2/igt@kms_setmode@basic.html
- shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_setmode@basic.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-kbl2/igt@kms_setmode@basic.html
* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][57] ([i915#1542]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb8/igt@perf@blocking-parameterized.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-iclb1/igt@perf@blocking-parameterized.html
#### Warnings ####
* igt@i915_pm_rpm@system-suspend-devices:
- shard-snb: [SKIP][59] ([fdo#109271]) -> [INCOMPLETE][60] ([i915#82]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb4/igt@i915_pm_rpm@system-suspend-devices.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-snb5/igt@i915_pm_rpm@system-suspend-devices.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [FAIL][62] ([fdo#108145] / [i915#265] / [i915#95])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277
[i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138
[i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
[i915#1487]: https://gitlab.freedesktop.org/drm/intel/issues/1487
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8264 -> Patchwork_17231
CI-20190529: 20190529
CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17231: 19e4a486e221d78b813f329cb88c4688fc4a5002 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17231/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-07 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 8:59 [Intel-gfx] [PATCH] drm/i915/gem: Promote 'remain' to unsigned long Chris Wilson
2020-04-07 9:21 ` Mika Kuoppala
2020-04-07 10:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-07 10:20 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-04-07 15:41 ` [Intel-gfx] [PATCH] " kbuild test robot
2020-04-07 16:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.