From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70940C4BA24 for ; Thu, 27 Feb 2020 00:44:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB8EE21D7E for ; Thu, 27 Feb 2020 00:44:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vcZCl4WK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB8EE21D7E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0D6CD166A; Thu, 27 Feb 2020 01:43:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0D6CD166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582764278; bh=a8YgZPuAJfD59VYXRRByJCh2AXCvnoC4rq5Jx5PxuHI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vcZCl4WKqV6QGqSV1i2A9E+PQ+Kr77Jr60/YY+oI3+9Vf4rZVNeL0qNQQP0PkxDxJ +sPyABcEJG4gD3VbFCYpzODxZy25fyoxVPf3F7gl3DZIxYnTlS1tMCxPLjp7XHiwGL eDaaWwxZs9qEZVY0RECgJBklHWmyG+tbQYI2Uq08= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 84E3EF800E8; Thu, 27 Feb 2020 01:43:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 297CAF8014E; Thu, 27 Feb 2020 01:43:46 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id B7985F800E8 for ; Thu, 27 Feb 2020 01:43:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B7985F800E8 Date: 27 Feb 2020 09:43:38 +0900 X-IronPort-AV: E=Sophos;i="5.70,490,1574089200"; d="scan'208";a="40352439" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 27 Feb 2020 09:43:38 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id DDD7A4126E2E; Thu, 27 Feb 2020 09:43:38 +0900 (JST) Message-ID: <87tv3c7tc5.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply In-Reply-To: References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <875zft97i4.wl-kuninori.morimoto.gx@renesas.com> <704a2cb1-ebcd-d433-0b8a-0f8d97d72fa5@linux.intel.com> <87v9ns7tpk.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > >>> - if ((playback && playback_active == 1) || > >>> - (!playback && capture_active == 1)) > >>> + if (codec_dai->active == 1) > >> > >> nit-pick: we have two tests in soc-pcm.c > >> > >> if (codec_dai->active) > >> if (codec_dai->active == 1) > >> > >> The two are functionality equivalent but it'd be good to choose one > >> version - or possibly use 'active' as a boolean. > > > > In my understanding, dai->active can be 0/1/2. > > I see, I guess I missed this completely. Thanks Morimoto-san for the > precision. But, we want to use "if (codec_dai->active)" anyway. Your review indicated my mistake. Thank you for your help !! Best regards --- Kuninori Morimoto