From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/php-*: fix autoconf variables
Date: Mon, 10 Feb 2020 08:36:08 +0100 [thread overview]
Message-ID: <87tv3ysxlj.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200209224516.245288-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sun, 9 Feb 2020 23:45:16 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Build of php-* packages are broken since commit
> 3292f3de499717360cf18d7fecd79ac096216ca8 because
> $(HOST_DIR)/bin/auto{conf,header} have been replaced by
> $(HOST_DIR)/bin/auto{conf,header} -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)"
> So revert this change (which should have been only refactoring) for
> those packages
> Fixes:
> - http://autobuild.buildroot.org/results/0d5f4a792652e302b8c00c1e0f99966cc930fbac
> - http://autobuild.buildroot.org/results/91a559183db212803a90cb399a1cb505b14818d9
Thanks, I also just noticed that.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/php-amqp/php-amqp.mk | 4 ++--
> package/php-geoip/php-geoip.mk | 4 ++--
> package/php-gnupg/php-gnupg.mk | 4 ++--
> package/php-imagick/php-imagick.mk | 4 ++--
> package/php-memcached/php-memcached.mk | 4 ++--
> package/php-ssh2/php-ssh2.mk | 4 ++--
> package/php-yaml/php-yaml.mk | 4 ++--
> package/php-zmq/php-zmq.mk | 4 ++--
> 8 files changed, 16 insertions(+), 16 deletions(-)
> diff --git a/package/php-amqp/php-amqp.mk b/package/php-amqp/php-amqp.mk
> index 8f3ba1f9f4..c808ecdbd6 100644
> --- a/package/php-amqp/php-amqp.mk
> +++ b/package/php-amqp/php-amqp.mk
> @@ -16,8 +16,8 @@ PHP_AMQP_LICENSE_FILES = LICENSE
> define PHP_AMQP_PHPIZE
> (cd $(@D); \
> - PHP_AUTOCONF=$(AUTOCONF) \
> - PHP_AUTOHEADER=$(AUTOHEADER) \
> + PHP_AUTOCONF=$(HOST_DIR)/bin/autoconf \
> + PHP_AUTOHEADER=$(HOST_DIR)/bin/autoheader \
This means dropping the -I flags, is that correct? Alternatively, I
guess we could do PHP_AUTOCONF='$(AUTOCONF)'
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2020-02-10 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 22:45 [Buildroot] [PATCH 1/1] package/php-*: fix autoconf variables Fabrice Fontaine
2020-02-10 7:36 ` Peter Korsgaard [this message]
2020-02-10 8:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv3ysxlj.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.