From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83557C33C8C for ; Tue, 7 Jan 2020 13:30:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D9F62081E for ; Tue, 7 Jan 2020 13:30:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VZdm5nd/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D9F62081E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioowf-0007Sc-9Q for qemu-devel@archiver.kernel.org; Tue, 07 Jan 2020 08:30:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47726) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ionT8-00049x-5H for qemu-devel@nongnu.org; Tue, 07 Jan 2020 06:56:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ionT6-0000vn-St for qemu-devel@nongnu.org; Tue, 07 Jan 2020 06:56:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:38820 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ionT6-0000vY-Oh for qemu-devel@nongnu.org; Tue, 07 Jan 2020 06:56:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578398176; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZwJ1rMU3VQl5V/RiTacanmZiUVAi98iCtwJ2TepIAt8=; b=VZdm5nd/qztXep5jdVxaXN2J1mlaG9z4ml1tmB+dPS7wLePNmN5I8TszGVXOmlwtEV+hMX qUJfonkyPHGB4Pq8D37UAwi2eQR59EFC3LHwDIwUhTR0QzkeFXpn8j6vfV0hWDVJgp6/51 f5AJUih5a2c4N5rGEMxm1PHNnr1Ogbg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-dWH5cCLnPOy0Q4RCW0yhvw-1; Tue, 07 Jan 2020 06:56:13 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1508110054E3; Tue, 7 Jan 2020 11:56:12 +0000 (UTC) Received: from redhat.com (ovpn-116-141.ams2.redhat.com [10.36.116.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8515D28980; Tue, 7 Jan 2020 11:56:11 +0000 (UTC) From: Juan Quintela To: "Dr. David Alan Gilbert" Subject: Re: [PATCH v2 1/3] migration-test: Add migration multifd test In-Reply-To: <20200107110717.GB2732@work-vm> (David Alan Gilbert's message of "Tue, 7 Jan 2020 11:07:17 +0000") References: <20200107104914.1814-1-quintela@redhat.com> <20200107104914.1814-2-quintela@redhat.com> <20200107110717.GB2732@work-vm> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Tue, 07 Jan 2020 12:56:08 +0100 Message-ID: <87tv57qy3r.fsf@trasno.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: dWH5cCLnPOy0Q4RCW0yhvw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Dr. David Alan Gilbert" wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> We set multifd-channels. >>=20 >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert >> Reviewed-by: Thomas Huth >> Tested-by: Wei Yang >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 56 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >>=20 >> diff --git a/tests/migration-test.c b/tests/migration-test.c >> index 53afec4395..1a8d06718e 100644 >> --- a/tests/migration-test.c >> +++ b/tests/migration-test.c >> @@ -1202,6 +1202,61 @@ static void test_migrate_auto_converge(void) >> test_migrate_end(from, to, true); >> } >> =20 >> +static void test_multifd_tcp(void) >> +{ >> + MigrateStart *args =3D migrate_start_new(); >> + QTestState *from, *to; >> + QDict *rsp; >> + char *uri; >> + >> + if (test_migrate_start(&from, &to, "defer", args)) { >> + return; >> + } >> + >> + /* >> + * We want to pick a speed slow enough that the test completes >> + * quickly, but that it doesn't complete precopy even on a slow >> + * machine, so also set the downtime. >> + */ >> + /* 1 ms should make it not converge*/ >> + migrate_set_parameter_int(from, "downtime-limit", 1); >> + /* 1GB/s */ >> + migrate_set_parameter_int(from, "max-bandwidth", 1000000000); >> + >> + migrate_set_parameter_int(from, "multifd-channels", 16); >> + migrate_set_parameter_int(to, "multifd-channels", 16); >> + >> + migrate_set_capability(from, "multifd", "true"); >> + migrate_set_capability(to, "multifd", "true"); >> + >> + /* Start incoming migration from the 1st socket */ >> + rsp =3D wait_command(to, "{ 'execute': 'migrate-incoming'," >> + " 'arguments': { 'uri': 'tcp:127.0.0.1:0' }= }"); >> + qobject_unref(rsp); >> + >> + /* Wait for the first serial output from the source */ >> + wait_for_serial("src_serial"); >> + >> + uri =3D migrate_get_socket_address(to, "socket-address"); >> + >> + migrate_qmp(from, uri, "{}"); >> + >> + wait_for_migration_pass(from); >> + >> + /* 300ms it should converge */ >> + migrate_set_parameter_int(from, "downtime-limit", 600); > > Comment doesn't quite match here; but other than that; Fixed code, thanks.