From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7707EC5DF60 for ; Fri, 8 Nov 2019 20:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DF102075C for ; Fri, 8 Nov 2019 20:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730137AbfKHUAn convert rfc822-to-8bit (ORCPT ); Fri, 8 Nov 2019 15:00:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729683AbfKHUAm (ORCPT ); Fri, 8 Nov 2019 15:00:42 -0500 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 695F4859FB for ; Fri, 8 Nov 2019 20:00:42 +0000 (UTC) Received: by mail-lf1-f70.google.com with SMTP id t6so1499999lfd.13 for ; Fri, 08 Nov 2019 12:00:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=qG5pX45gqbqgt+VLx3ZjRVv+L6FBbAKqh5UrCUuYNjo=; b=LQYOe8/dYzHwMaZC9gSBRLX/LYvjsXh2hHBFMF2/PMFyXiVTTIzTxulsar5bz5tGzR h0CqPiNqquEFc4f4nNwo11PVvVPVnXPy0nM9trjCZMvweIYSTojGKNggA5WUlqK8mGcg 9OfeqaZ3Zh8Kd+kMZKMlbVuvZqMDBESm/wEHKJCy+ZYF5TKwvChYzTkoL/VZVpnpATUq /aTOeIMcwxeIXFHkRqvkoZ+kIS29rqwm11qyhkGGONuWwrnplMT7choeC9zCrhEWs4LO gW0TveKaC4RBeg7flK/QGPBP6nrjddccOiFoAGbFKKRRv+RmYUrVaChbSpZquHEappns pNEQ== X-Gm-Message-State: APjAAAW22pF6I3/0G9ZvirWKXGkMvYjEpVLBjGDRNXMwJJzrfJmdUUIY 1ZbLCAx0fRFg+ApHNC+Cdb2fNSzLXzSjcoJd2tI9AIgOSwPODI2kfsVVb6yeUfS7lJL4Y9xPauC SkkkP67f6Qb2k X-Received: by 2002:a05:6512:cf:: with SMTP id c15mr541392lfp.92.1573243240996; Fri, 08 Nov 2019 12:00:40 -0800 (PST) X-Google-Smtp-Source: APXvYqz3KRIyyJtyr6xfpzu00SYuEjhR/UcZ7yKD4FlZJR7wm45/z141T9Wkea9jRVLo9JN2qMv0mQ== X-Received: by 2002:a05:6512:cf:: with SMTP id c15mr541374lfp.92.1573243240775; Fri, 08 Nov 2019 12:00:40 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id a11sm3186951ljp.97.2019.11.08.12.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 12:00:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0DE861818B6; Fri, 8 Nov 2019 21:00:39 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Song Liu Cc: Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Jesper Dangaard Brouer , Andrii Nakryiko , David Miller , Networking , bpf Subject: Re: [PATCH bpf-next 2/6] selftests/bpf: Add tests for automatic map unpinning on load failure In-Reply-To: References: <157314553801.693412.15522462897300280861.stgit@toke.dk> <157314554027.693412.3764267220990589755.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 08 Nov 2019 21:00:39 +0100 Message-ID: <87tv7ecf4o.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Song Liu writes: > On Thu, Nov 7, 2019 at 8:52 AM Toke Høiland-Jørgensen wrote: >> >> From: Toke Høiland-Jørgensen >> >> This add tests for the different variations of automatic map unpinning on >> load failure. >> >> Signed-off-by: Toke Høiland-Jørgensen >> --- > > [...] > >> diff --git a/tools/testing/selftests/bpf/progs/test_pinning.c b/tools/testing/selftests/bpf/progs/test_pinning.c >> index f69a4a50d056..f20e7e00373f 100644 >> --- a/tools/testing/selftests/bpf/progs/test_pinning.c >> +++ b/tools/testing/selftests/bpf/progs/test_pinning.c >> @@ -21,7 +21,7 @@ struct { >> } nopinmap SEC(".maps"); >> >> struct { >> - __uint(type, BPF_MAP_TYPE_ARRAY); >> + __uint(type, BPF_MAP_TYPE_HASH); > > Why do we need this change? Because it needs to be different from the top map: I'm changing which of the maps to use for the "check for parameter mismatch" selftest; the last map needs to be the one that fails, so that a previous one can succeed first and get removed on failure clean-up (which we can then test for)... -Toke