All of lore.kernel.org
 help / color / mirror / Atom feed
* ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
@ 2019-06-13  1:02 ` Patchwork
  2019-06-13  1:03 ` ✗ Fi.CI.SPARSE: " Patchwork
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-06-13  1:02 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: gpu/drm/i915: globally replace dev_priv with i915
URL   : https://patchwork.freedesktop.org/series/61983/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5585dfe286e9 gpu/drm/i915: globally replace dev_priv with i915
-:633: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!r"
#633: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:141:
+		if (r == NULL && !IS_GEN(i915, 3)) {

-:2243: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2243: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:909:
+	if (IS_GEN(gvt->i915, 9) &&
 			intel_gvt_mmio_is_in_ctx(gvt, offset) &&

-:2863: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2863: FILE: drivers/gpu/drm/i915/gvt/gtt.c:293:
+static void write_pte64(struct drm_i915_private *i915,
 		unsigned long index, u64 pte)

-:3109: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#3109: FILE: drivers/gpu/drm/i915/gvt/gvt.h:376:
+#define gvt_aperture_sz(gvt)	  (gvt->i915->ggtt.mappable_end)

-:3110: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#3110: FILE: drivers/gpu/drm/i915/gvt/gvt.h:377:
+#define gvt_aperture_pa_base(gvt) (gvt->i915->ggtt.gmadr.start)

-:3113: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#3113: FILE: drivers/gpu/drm/i915/gvt/gvt.h:379:
+#define gvt_ggtt_gm_sz(gvt)	  (gvt->i915->ggtt.vm.total)

-:3125: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#3125: FILE: drivers/gpu/drm/i915/gvt/gvt.h:393:
+#define gvt_fence_sz(gvt) (gvt->i915->num_fence_regs)

-:3309: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3309: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1420:
+		if (IS_SKYLAKE(vgpu->gvt->i915)
+			 || IS_KABYLAKE(vgpu->gvt->i915)

-:3310: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3310: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1421:
+			 || IS_KABYLAKE(vgpu->gvt->i915)
+			 || IS_COFFEELAKE(vgpu->gvt->i915)) {

-:3331: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3331: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1445:
+		if (IS_SKYLAKE(vgpu->gvt->i915)
+			 || IS_KABYLAKE(vgpu->gvt->i915)

-:3332: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3332: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1446:
+			 || IS_KABYLAKE(vgpu->gvt->i915)
+			 || IS_COFFEELAKE(vgpu->gvt->i915))

-:3457: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3457: FILE: drivers/gpu/drm/i915/gvt/handlers.c:3364:
+	} else if (IS_SKYLAKE(i915)
+		|| IS_KABYLAKE(i915)

-:3458: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3458: FILE: drivers/gpu/drm/i915/gvt/handlers.c:3365:
+		|| IS_KABYLAKE(i915)
+		|| IS_COFFEELAKE(i915)) {

-:3919: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#3919: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1019:
+			intel_uncore_forcewake_get(&gvt->i915->uncore,
 					FORCEWAKE_ALL);

-:3928: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#3928: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1041:
+			intel_uncore_forcewake_put(&gvt->i915->uncore,
 					FORCEWAKE_ALL);

-:4443: CHECK:BRACES: braces {} should be used on all arms of this statement
#4443: FILE: drivers/gpu/drm/i915/i915_debugfs.c:907:
+		if (INTEL_GEN(i915) >= 9)
[...]
 		else {
[...]

-:4959: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63)
#4959: FILE: drivers/gpu/drm/i915/i915_debugfs.c:1496:
+	if (INTEL_GEN(i915) >= 9)
 		/* no global SR status; inspect per-plane WM */;

-:7255: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!i915->wq"
#7255: FILE: drivers/gpu/drm/i915/i915_drv.c:819:
+	if (i915->wq == NULL)

-:7261: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!i915->hotplug.dp_wq"
#7261: FILE: drivers/gpu/drm/i915/i915_drv.c:823:
+	if (i915->hotplug.dp_wq == NULL)

-:8663: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#8663: FILE: drivers/gpu/drm/i915/i915_drv.c:2857:
+static int vlv_resume_prepare(struct drm_i915_private *i915,
 				bool rpm_resume)

-:9173: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9173: FILE: drivers/gpu/drm/i915/i915_drv.h:2176:
+#define IS_G4X(i915)	(IS_G45(i915) || IS_GM45(i915))

-:9177: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9177: FILE: drivers/gpu/drm/i915/i915_drv.h:2180:
+#define IS_IRONLAKE_M(i915) \
+	(IS_PLATFORM(i915, INTEL_IRONLAKE) && IS_MOBILE(i915))

-:9180: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9180: FILE: drivers/gpu/drm/i915/i915_drv.h:2183:
+#define IS_IVB_GT1(i915)	(IS_IVYBRIDGE(i915) && \
+				 INTEL_INFO(i915)->gt == 1)

-:9194: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9194: FILE: drivers/gpu/drm/i915/i915_drv.h:2197:
+#define IS_HSW_EARLY_SDV(i915) (IS_HASWELL(i915) && \
+				    (INTEL_DEVID(i915) & 0xFF00) == 0x0C00)

-:9200: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9200: FILE: drivers/gpu/drm/i915/i915_drv.h:2203:
+#define IS_BDW_GT3(i915)	(IS_BROADWELL(i915) && \
+				 INTEL_INFO(i915)->gt == 3)

-:9204: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9204: FILE: drivers/gpu/drm/i915/i915_drv.h:2207:
+#define IS_HSW_GT3(i915)	(IS_HASWELL(i915) && \
+				 INTEL_INFO(i915)->gt == 3)

-:9206: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9206: FILE: drivers/gpu/drm/i915/i915_drv.h:2209:
+#define IS_HSW_GT1(i915)	(IS_HASWELL(i915) && \
+				 INTEL_INFO(i915)->gt == 1)

-:9251: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9251: FILE: drivers/gpu/drm/i915/i915_drv.h:2222:
+#define IS_SKL_GT2(i915)	(IS_SKYLAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 2)

-:9253: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9253: FILE: drivers/gpu/drm/i915/i915_drv.h:2224:
+#define IS_SKL_GT3(i915)	(IS_SKYLAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 3)

-:9255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9255: FILE: drivers/gpu/drm/i915/i915_drv.h:2226:
+#define IS_SKL_GT4(i915)	(IS_SKYLAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 4)

-:9257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9257: FILE: drivers/gpu/drm/i915/i915_drv.h:2228:
+#define IS_KBL_GT2(i915)	(IS_KABYLAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 2)

-:9259: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9259: FILE: drivers/gpu/drm/i915/i915_drv.h:2230:
+#define IS_KBL_GT3(i915)	(IS_KABYLAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 3)

-:9265: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9265: FILE: drivers/gpu/drm/i915/i915_drv.h:2236:
+#define IS_CFL_GT2(i915)	(IS_COFFEELAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 2)

-:9267: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9267: FILE: drivers/gpu/drm/i915/i915_drv.h:2238:
+#define IS_CFL_GT3(i915)	(IS_COFFEELAKE(i915) && \
+				 INTEL_INFO(i915)->gt == 3)

-:9282: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9282: FILE: drivers/gpu/drm/i915/i915_drv.h:2262:
+#define IS_BXT_REVID(i915, since, until) \
+	(IS_BROXTON(i915) && IS_REVID(i915, since, until))

-:9293: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9293: FILE: drivers/gpu/drm/i915/i915_drv.h:2271:
+#define IS_KBL_REVID(i915, since, until) \
+	(IS_KABYLAKE(i915) && IS_REVID(i915, since, until))

-:9301: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9301: FILE: drivers/gpu/drm/i915/i915_drv.h:2277:
+#define IS_GLK_REVID(i915, since, until) \
+	(IS_GEMINILAKE(i915) && IS_REVID(i915, since, until))

-:9314: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9314: FILE: drivers/gpu/drm/i915/i915_drv.h:2297:
+#define IS_GEN9_LP(i915)	(IS_GEN(i915, 9) && IS_LP(i915))

-:9315: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9315: FILE: drivers/gpu/drm/i915/i915_drv.h:2298:
+#define IS_GEN9_BC(i915)	(IS_GEN(i915, 9) && !IS_LP(i915))

-:9365: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9365: FILE: drivers/gpu/drm/i915/i915_drv.h:2316:
+#define HAS_WT(i915)	((IS_HASWELL(i915) || \
+				 IS_BROADWELL(i915)) && HAS_EDRAM(i915))

-:9385: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sizes' - possible side-effects?
#9385: FILE: drivers/gpu/drm/i915/i915_drv.h:2336:
+#define HAS_PAGE_SIZES(i915, sizes) ({ \
 	GEM_BUG_ON((sizes) == 0); \
+	((sizes) & ~INTEL_INFO(i915)->page_sizes) == 0; \
 })

-:9400: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9400: FILE: drivers/gpu/drm/i915/i915_drv.h:2346:
+#define HAS_BROKEN_CS_TLB(i915)	(IS_I830(i915) || IS_I845G(i915))

-:9406: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9406: FILE: drivers/gpu/drm/i915/i915_drv.h:2349:
+#define NEEDS_WaRsDisableCoarsePowerGating(i915) \
+	(IS_CANNONLAKE(i915) || \
+	 IS_SKL_GT3(i915) || IS_SKL_GT4(i915))

-:9415: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9415: FILE: drivers/gpu/drm/i915/i915_drv.h:2354:
+#define HAS_GMBUS_BURST_READ(i915) (INTEL_GEN(i915) >= 10 || \
+					IS_GEMINILAKE(i915) || \
+					IS_KABYLAKE(i915))

-:9427: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9427: FILE: drivers/gpu/drm/i915/i915_drv.h:2361:
+#define HAS_128_BYTE_Y_TILING(i915) (!IS_GEN(i915, 2) && \
+					 !(IS_I915G(i915) || \
+					 IS_I915GM(i915)))

-:9436: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9436: FILE: drivers/gpu/drm/i915/i915_drv.h:2367:
+#define HAS_FW_BLC(i915) ^I(INTEL_GEN(i915) > 2)$

-:9438: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9438: FILE: drivers/gpu/drm/i915/i915_drv.h:2369:
+#define HAS_CUR_FBC(i915)	(!HAS_GMCH(i915) && INTEL_GEN(i915) >= 7)

-:9441: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9441: FILE: drivers/gpu/drm/i915/i915_drv.h:2371:
+#define HAS_IPS(i915)	(IS_HSW_ULT(i915) || IS_BROADWELL(i915))

-:9537: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9537: FILE: drivers/gpu/drm/i915/i915_drv.h:2438:
+#define HAS_PCH_LPT_LP(i915) \
+	(INTEL_PCH_ID(i915) == INTEL_PCH_LPT_LP_DEVICE_ID_TYPE || \
+	 INTEL_PCH_ID(i915) == INTEL_PCH_WPT_LP_DEVICE_ID_TYPE)

-:9540: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9540: FILE: drivers/gpu/drm/i915/i915_drv.h:2441:
+#define HAS_PCH_LPT_H(i915) \
+	(INTEL_PCH_ID(i915) == INTEL_PCH_LPT_DEVICE_ID_TYPE || \
+	 INTEL_PCH_ID(i915) == INTEL_PCH_WPT_DEVICE_ID_TYPE)

-:9557: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#9557: FILE: drivers/gpu/drm/i915/i915_drv.h:2455:
+#define NUM_L3_SLICES(i915) (IS_HSW_GT3(i915) ? \
+				 2 : HAS_L3_DPF(i915))

-:9606: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9606: FILE: drivers/gpu/drm/i915/i915_drv.h:2506:
+extern void intel_hangcheck_init(struct drm_i915_private *i915);

-:9802: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9802: FILE: drivers/gpu/drm/i915/i915_drv.h:2799:
+extern void i915_perf_init(struct drm_i915_private *i915);

-:9803: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9803: FILE: drivers/gpu/drm/i915/i915_drv.h:2800:
+extern void i915_perf_fini(struct drm_i915_private *i915);

-:9804: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9804: FILE: drivers/gpu/drm/i915/i915_drv.h:2801:
+extern void i915_perf_register(struct drm_i915_private *i915);

-:9805: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9805: FILE: drivers/gpu/drm/i915/i915_drv.h:2802:
+extern void i915_perf_unregister(struct drm_i915_private *i915);

-:9810: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9810: FILE: drivers/gpu/drm/i915/i915_drv.h:2805:
+extern int i915_save_state(struct drm_i915_private *i915);

-:9811: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9811: FILE: drivers/gpu/drm/i915/i915_drv.h:2806:
+extern int i915_restore_state(struct drm_i915_private *i915);

-:9833: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9833: FILE: drivers/gpu/drm/i915/i915_drv.h:2823:
+extern int intel_modeset_vga_set_state(struct drm_i915_private *i915,

-:9839: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9839: FILE: drivers/gpu/drm/i915/i915_drv.h:2826:
+extern void i915_redisable_vga(struct drm_i915_private *i915);

-:9840: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9840: FILE: drivers/gpu/drm/i915/i915_drv.h:2827:
+extern void i915_redisable_vga_power_on(struct drm_i915_private *i915);

-:9841: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#9841: FILE: drivers/gpu/drm/i915/i915_drv.h:2828:
+extern void intel_init_pch_refclk(struct drm_i915_private *i915);

-:10147: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#10147: FILE: drivers/gpu/drm/i915/i915_gem.c:1284:
+	BUG_ON(!i915->kernel_context);

-:12501: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#12501: FILE: drivers/gpu/drm/i915/i915_irq.c:1464:
+		i915->l3_parity.which_slice &= ~(1<<slice);
 		                                  ^

-:14642: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#14642: FILE: drivers/gpu/drm/i915/i915_irq.c:3984:
+	if (IS_GEN(i915, 5)) {
[...]
 	} else {
[...]

-:14879: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#14879: FILE: drivers/gpu/drm/i915/i915_irq.c:4187:
+		if (intel_display_power_is_enabled(i915,
 				POWER_DOMAIN_PIPE(pipe)))

-:15739: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#15739: FILE: drivers/gpu/drm/i915/i915_irq.h:16:
+extern void intel_irq_init(struct drm_i915_private *i915);

-:15740: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#15740: FILE: drivers/gpu/drm/i915/i915_irq.h:17:
+extern void intel_irq_fini(struct drm_i915_private *i915);

-:15785: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#15785: FILE: drivers/gpu/drm/i915/i915_irq.h:50:
 }
+void bdw_update_pipe_irq(struct drm_i915_private *i915,

-:15797: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#15797: FILE: drivers/gpu/drm/i915/i915_irq.h:59:
 }
+static inline void bdw_disable_pipe_irq(struct drm_i915_private *i915,

-:15804: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#15804: FILE: drivers/gpu/drm/i915/i915_irq.h:64:
 }
+void ibx_display_interrupt_update(struct drm_i915_private *i915,

-:15949: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#15949: FILE: drivers/gpu/drm/i915/i915_oa_bdw.h:13:
+extern void i915_perf_load_test_config_bdw(struct drm_i915_private *i915);

-:16010: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16010: FILE: drivers/gpu/drm/i915/i915_oa_bxt.h:13:
+extern void i915_perf_load_test_config_bxt(struct drm_i915_private *i915);

-:16071: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16071: FILE: drivers/gpu/drm/i915/i915_oa_cflgt2.h:13:
+extern void i915_perf_load_test_config_cflgt2(struct drm_i915_private *i915);

-:16132: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16132: FILE: drivers/gpu/drm/i915/i915_oa_cflgt3.h:13:
+extern void i915_perf_load_test_config_cflgt3(struct drm_i915_private *i915);

-:16193: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16193: FILE: drivers/gpu/drm/i915/i915_oa_chv.h:13:
+extern void i915_perf_load_test_config_chv(struct drm_i915_private *i915);

-:16254: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16254: FILE: drivers/gpu/drm/i915/i915_oa_cnl.h:13:
+extern void i915_perf_load_test_config_cnl(struct drm_i915_private *i915);

-:16315: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16315: FILE: drivers/gpu/drm/i915/i915_oa_glk.h:13:
+extern void i915_perf_load_test_config_glk(struct drm_i915_private *i915);

-:16376: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16376: FILE: drivers/gpu/drm/i915/i915_oa_hsw.h:13:
+extern void i915_perf_load_test_config_hsw(struct drm_i915_private *i915);

-:16437: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16437: FILE: drivers/gpu/drm/i915/i915_oa_icl.h:13:
+extern void i915_perf_load_test_config_icl(struct drm_i915_private *i915);

-:16498: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16498: FILE: drivers/gpu/drm/i915/i915_oa_kblgt2.h:13:
+extern void i915_perf_load_test_config_kblgt2(struct drm_i915_private *i915);

-:16559: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16559: FILE: drivers/gpu/drm/i915/i915_oa_kblgt3.h:13:
+extern void i915_perf_load_test_config_kblgt3(struct drm_i915_private *i915);

-:16620: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16620: FILE: drivers/gpu/drm/i915/i915_oa_sklgt2.h:13:
+extern void i915_perf_load_test_config_sklgt2(struct drm_i915_private *i915);

-:16681: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16681: FILE: drivers/gpu/drm/i915/i915_oa_sklgt3.h:13:
+extern void i915_perf_load_test_config_sklgt3(struct drm_i915_private *i915);

-:16742: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#16742: FILE: drivers/gpu/drm/i915/i915_oa_sklgt4.h:13:
+extern void i915_perf_load_test_config_sklgt4(struct drm_i915_private *i915);

-:16990: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i915->perf.oa.oa_buffer.last_ctx_id ==
 		     i915->perf.oa.specific_ctx_id'
#16990: FILE: drivers/gpu/drm/i915/i915_perf.c:788:
+		if (!i915->perf.oa.exclusive_stream->ctx ||
+		    i915->perf.oa.specific_ctx_id == ctx_id ||
+		    (i915->perf.oa.oa_buffer.last_ctx_id ==
+		     i915->perf.oa.specific_ctx_id) ||
 		    reason & OAREPORT_REASON_CTX_SWITCH) {

-:17259: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#17259: FILE: drivers/gpu/drm/i915/i915_perf.c:1364:
+	BUG_ON(stream != i915->perf.oa.exclusive_stream);

-:17925: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#17925: FILE: drivers/gpu/drm/i915/i915_perf.c:2326:
+static __poll_t i915_perf_poll_locked(struct drm_i915_private *i915,
 					  struct i915_perf_stream *stream,

-:18638: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#18638: FILE: drivers/gpu/drm/i915/i915_perf.c:3464:
+				i915->perf.oa.gen8_valid_ctx_bit = (1<<25);
 				                                     ^

-:18646: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#18646: FILE: drivers/gpu/drm/i915/i915_perf.c:3469:
+				i915->perf.oa.gen8_valid_ctx_bit = (1<<16);
 				                                     ^

-:18671: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#18671: FILE: drivers/gpu/drm/i915/i915_perf.c:3485:
+			i915->perf.oa.gen8_valid_ctx_bit = (1<<16);
 			                                     ^

-:18679: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#18679: FILE: drivers/gpu/drm/i915/i915_perf.c:3491:
+		hrtimer_init(&i915->perf.oa.poll_check_timer,
 				CLOCK_MONOTONIC, HRTIMER_MODE_REL);

-:18914: WARNING:LONG_LINE: line over 100 characters
#18914: FILE: drivers/gpu/drm/i915/i915_reg.h:254:
+

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* ✗ Fi.CI.SPARSE: warning for gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
  2019-06-13  1:02 ` ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915 Patchwork
@ 2019-06-13  1:03 ` Patchwork
  2019-06-13  2:19 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-06-13  1:03 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: gpu/drm/i915: globally replace dev_priv with i915
URL   : https://patchwork.freedesktop.org/series/61983/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: gpu/drm/i915: globally replace dev_priv with i915
-O:drivers/gpu/drm/i915/i915_gem_gtt.c:2859:26: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_gem_gtt.c:2859:26: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_perf.c:1432:15: warning: memset with byte count of 16777216
-O:drivers/gpu/drm/i915/i915_perf.c:1490:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_irq.c:1407:21: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_perf.c:1432:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_perf.c:1490:15: warning: memset with byte count of 16777216
-O:drivers/gpu/drm/i915/i915_vma.c:584:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_vma.c:584:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/i915_vma.c:586:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:584:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:584:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/i915_vma.c:586:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:971:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_audio.c:971:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:971:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_audio.c:971:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:171:20: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:171:20: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:171:20: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:171:20: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2228:37: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2231:37: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2240:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2248:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2257:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2289:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2289:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2325:37: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_cdclk.c:2325:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_bw.c:244:24: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2228:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2231:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2240:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2248:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2257:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2289:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2289:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2325:37: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_cdclk.c:2325:37: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_display.c:1201:22: error: Expected constant expression in case statement
-O:drivers/gpu/drm/i915/intel_display.c:1204:22: error: Expected constant expression in case statement
-O:drivers/gpu/drm/i915/intel_display.c:1207:22: error: Expected constant expression in case statement
-O:drivers/gpu/drm/i915/intel_display.c:1210:22: error: Expected constant expression in case statement
+drivers/gpu/drm/i915/intel_display.c:1201:22: error: Expected constant expression in case statement
+drivers/gpu/drm/i915/intel_display.c:1204:22: error: Expected constant expression in case statement
+drivers/gpu/drm/i915/intel_display.c:1207:22: error: Expected constant expression in case statement
+drivers/gpu/drm/i915/intel_display.c:1210:22: error: Expected constant expression in case statement
-O:drivers/gpu/drm/i915/intel_dp.c:6645:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_dp.c:6645:31: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_fbc.c:92:25: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_fbc.c:94:25: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_gmbus.c:459:31: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_gmbus.c:461:31: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_gmbus.c:461:31: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_gmbus.c:523:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_gmbus.c:523:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_fbc.c:92:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_fbc.c:94:25: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_gmbus.c:459:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_gmbus.c:461:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_gmbus.c:461:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_gmbus.c:523:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_gmbus.c:523:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_overlay.c:824:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_overlay.c:824:29: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_overlay.c:824:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_overlay.c:824:29: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1558:15: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: too many warnings
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_panel.c:1753:34: warning: too many warnings
-O:drivers/gpu/drm/i915/intel_pm.c:1188:17: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:1188:17: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:1644:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:1644:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:2672:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:2672:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:2672:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:2672:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:3963:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:3963:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:3963:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:3963:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_pm.c:936:16: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:473:27: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:478:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:478:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:505:27: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:507:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_psr.c:507:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_pm.c:936:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:473:27: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:478:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:478:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:505:27: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:507:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_psr.c:507:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/vlv_dsi.c:1731:26: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/vlv_dsi.c:1731:26: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/vlv_dsi.c:1731:26: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/vlv_dsi.c:1731:26: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* ✓ Fi.CI.BAT: success for gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
  2019-06-13  1:02 ` ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915 Patchwork
  2019-06-13  1:03 ` ✗ Fi.CI.SPARSE: " Patchwork
@ 2019-06-13  2:19 ` Patchwork
  2019-06-13  6:07 ` [PATCH] " Chris Wilson
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-06-13  2:19 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: gpu/drm/i915: globally replace dev_priv with i915
URL   : https://patchwork.freedesktop.org/series/61983/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13261
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/

Known issues
------------

  Here are the changes found in Patchwork_13261 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@busy-all:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/fi-icl-u3/igt@gem_busy@busy-all.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/fi-icl-u3/igt@gem_busy@busy-all.html

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/fi-blb-e6850/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/fi-blb-e6850/igt@i915_module_load@reload.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-all:
    - fi-icl-guc:         [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/fi-icl-guc/igt@gem_busy@busy-all.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/fi-icl-guc/igt@gem_busy@busy-all.html

  * igt@gem_ctx_create@basic-files:
    - fi-icl-u2:          [INCOMPLETE][7] ([fdo#107713] / [fdo#109100]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/fi-icl-u2/igt@gem_ctx_create@basic-files.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/fi-icl-u2/igt@gem_ctx_create@basic-files.html

  
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100


Participating hosts (53 -> 47)
------------------------------

  Additional (1): fi-icl-dsi 
  Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6253 -> Patchwork_13261

  CI_DRM_6253: 83fdc69645c5c6b511e36e171f1c75a6132f007c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5054: 7a295df596fdf71e5c28ecb1fbfec002060e9293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13261: 5585dfe286e95307d073e4d8025116f3c7ae7b01 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5585dfe286e9 gpu/drm/i915: globally replace dev_priv with i915

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
                   ` (2 preceding siblings ...)
  2019-06-13  2:19 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-13  6:07 ` Chris Wilson
  2019-06-13  6:14   ` Lucas De Marchi
  2019-06-13 13:12 ` Jani Nikula
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2019-06-13  6:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

Quoting Lucas De Marchi (2019-06-12 17:29:00)
> We are slowly converting dev_priv to i915 everywhere, spread into
> smaller series. While this is good to avoid unrelated breakages to other
> inflight patches, it's bad because inflight patches on nearby paths keep
> breaking. Paired with other code moves and refactores this is becoming a
> nightmare.
> 
> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
> longer exists we can simply sed all files and be done with the
> conversion. This was generated with the following commands with no
> additional fixups:
> 
>         git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>                 xargs -0 sed -i 's/\bdev_priv\b/i915/g'
> 
> Any pending series can apply the same search and replace when rebasing.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/i915/dvo_ch7017.c             |    6 +-
>  drivers/gpu/drm/i915/dvo_ch7xxx.c             |   10 +-
>  drivers/gpu/drm/i915/dvo_ivch.c               |   14 +-
>  drivers/gpu/drm/i915/dvo_ns2501.c             |   14 +-
>  drivers/gpu/drm/i915/dvo_sil164.c             |   10 +-
>  drivers/gpu/drm/i915/dvo_tfp410.c             |   10 +-

Notice that the very start of this, the dev_priv backpointers are
not i915.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13  6:07 ` [PATCH] " Chris Wilson
@ 2019-06-13  6:14   ` Lucas De Marchi
  0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-06-13  6:14 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx, Lucas De Marchi

On Thu, Jun 13, 2019 at 07:07:28AM +0100, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-06-12 17:29:00)
>> We are slowly converting dev_priv to i915 everywhere, spread into
>> smaller series. While this is good to avoid unrelated breakages to other
>> inflight patches, it's bad because inflight patches on nearby paths keep
>> breaking. Paired with other code moves and refactores this is becoming a
>> nightmare.
>>
>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>> longer exists we can simply sed all files and be done with the
>> conversion. This was generated with the following commands with no
>> additional fixups:
>>
>>         git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>>                 xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>>
>> Any pending series can apply the same search and replace when rebasing.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>>  drivers/gpu/drm/i915/dvo_ch7017.c             |    6 +-
>>  drivers/gpu/drm/i915/dvo_ch7xxx.c             |   10 +-
>>  drivers/gpu/drm/i915/dvo_ivch.c               |   14 +-
>>  drivers/gpu/drm/i915/dvo_ns2501.c             |   14 +-
>>  drivers/gpu/drm/i915/dvo_sil164.c             |   10 +-
>>  drivers/gpu/drm/i915/dvo_tfp410.c             |   10 +-
>
>Notice that the very start of this, the dev_priv backpointers are
>not i915.

true. AFAICS it's in all the dvo_*.c - I will fix it for next time.

thanks
Lucas De Marchi

>-Chris
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
                   ` (3 preceding siblings ...)
  2019-06-13  6:07 ` [PATCH] " Chris Wilson
@ 2019-06-13 13:12 ` Jani Nikula
  2019-06-13 16:29   ` Lucas De Marchi
       [not found] ` <0000a4b2-ac8b-a18d-4c78-0db197c712a1@linux.intel.com>
  2019-06-14 16:41 ` ✓ Fi.CI.IGT: success for " Patchwork
  6 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2019-06-13 13:12 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> We are slowly converting dev_priv to i915 everywhere, spread into
> smaller series. While this is good to avoid unrelated breakages to other
> inflight patches, it's bad because inflight patches on nearby paths keep
> breaking. Paired with other code moves and refactores this is becoming a
> nightmare.
>
> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
> longer exists we can simply sed all files and be done with the
> conversion. This was generated with the following commands with no
> additional fixups:
>
> 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
> 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>
> Any pending series can apply the same search and replace when rebasing.

I'm pretty strongly against renaming the implicit dev_priv local
variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
converting a function to not use the implicit dev_priv helps us by
catching any leftover references.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
       [not found] ` <0000a4b2-ac8b-a18d-4c78-0db197c712a1@linux.intel.com>
@ 2019-06-13 15:19   ` Chris Wilson
  2019-06-13 15:21     ` Tvrtko Ursulin
  0 siblings, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2019-06-13 15:19 UTC (permalink / raw)
  To: Lucas De Marchi, Tvrtko Ursulin, intel-gfx

Quoting Tvrtko Ursulin (2019-06-13 16:12:16)
> 
> On 12/06/2019 17:29, Lucas De Marchi wrote:
> > We are slowly converting dev_priv to i915 everywhere, spread into
> > smaller series. While this is good to avoid unrelated breakages to other
> > inflight patches, it's bad because inflight patches on nearby paths keep
> > breaking. Paired with other code moves and refactores this is becoming a
> > nightmare.
> > 
> > Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
> 
> Who removed I915_READ/WRITE? In fact I see some in this patch. Well 
> colour me confused.. how did the patch compile?

The secret is in changing the implicit parameter as well, s/dev_priv/i915/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13 15:19   ` Chris Wilson
@ 2019-06-13 15:21     ` Tvrtko Ursulin
  0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-06-13 15:21 UTC (permalink / raw)
  To: Chris Wilson, Lucas De Marchi, intel-gfx


On 13/06/2019 16:19, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 16:12:16)
>>
>> On 12/06/2019 17:29, Lucas De Marchi wrote:
>>> We are slowly converting dev_priv to i915 everywhere, spread into
>>> smaller series. While this is good to avoid unrelated breakages to other
>>> inflight patches, it's bad because inflight patches on nearby paths keep
>>> breaking. Paired with other code moves and refactores this is becoming a
>>> nightmare.
>>>
>>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>>
>> Who removed I915_READ/WRITE? In fact I see some in this patch. Well
>> colour me confused.. how did the patch compile?
> 
> The secret is in changing the implicit parameter as well, s/dev_priv/i915/

Lolz are on me. :))

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13 13:12 ` Jani Nikula
@ 2019-06-13 16:29   ` Lucas De Marchi
  2019-06-13 16:48     ` Lucas De Marchi
  0 siblings, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2019-06-13 16:29 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Thu, Jun 13, 2019 at 04:12:37PM +0300, Jani Nikula wrote:
>On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> We are slowly converting dev_priv to i915 everywhere, spread into
>> smaller series. While this is good to avoid unrelated breakages to other
>> inflight patches, it's bad because inflight patches on nearby paths keep
>> breaking. Paired with other code moves and refactores this is becoming a
>> nightmare.
>>
>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>> longer exists we can simply sed all files and be done with the
>> conversion. This was generated with the following commands with no
>> additional fixups:
>>
>> 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>> 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>>
>> Any pending series can apply the same search and replace when rebasing.
>
>I'm pretty strongly against renaming the implicit dev_priv local
>variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
>converting a function to not use the implicit dev_priv helps us by
>catching any leftover references.

I don't think this is strong enough reason to block the conversion. The
conversion is taking forever and is gonna take year+ if it continues at
this pace. It affects multiple developers rebasing their work and
introduce bugs on pending series.

Removing any file-scope reference (I didn't review yet if we still have
any) and reviewing the macros is sufficient. And if we later we find out
we missed one, we just go and fix it. I see zero advantage on slow and
forever. You have a mixed code base and new code following what's around
will just propagate more the mixed code base :(

Lucas De Marchi

>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13 16:29   ` Lucas De Marchi
@ 2019-06-13 16:48     ` Lucas De Marchi
  2019-06-13 17:04       ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Lucas De Marchi @ 2019-06-13 16:48 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Thu, Jun 13, 2019 at 09:29:48AM -0700, Lucas De Marchi wrote:
>On Thu, Jun 13, 2019 at 04:12:37PM +0300, Jani Nikula wrote:
>>On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>>We are slowly converting dev_priv to i915 everywhere, spread into
>>>smaller series. While this is good to avoid unrelated breakages to other
>>>inflight patches, it's bad because inflight patches on nearby paths keep
>>>breaking. Paired with other code moves and refactores this is becoming a
>>>nightmare.
>>>
>>>Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>>>longer exists we can simply sed all files and be done with the
>>>conversion. This was generated with the following commands with no
>>>additional fixups:
>>>
>>>	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>>>		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>>>
>>>Any pending series can apply the same search and replace when rebasing.
>>
>>I'm pretty strongly against renaming the implicit dev_priv local
>>variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
>>converting a function to not use the implicit dev_priv helps us by
>>catching any leftover references.
>
>I don't think this is strong enough reason to block the conversion. The
>conversion is taking forever and is gonna take year+ if it continues at
>this pace. It affects multiple developers rebasing their work and
>introduce bugs on pending series.
>
>Removing any file-scope reference (I didn't review yet if we still have
>any) and reviewing the macros is sufficient. And if we later we find out
>we missed one, we just go and fix it. I see zero advantage on slow and
>forever. You have a mixed code base and new code following what's around
>will just propagate more the mixed code base :(

btw, let me be clear the proposal is not "this should be done now". I do
think we should be smart and think on the best opportunity to do it.
Probably like after the big code moves gt/, gem/, display/, etc end.

Lucas De Marchi

>
>Lucas De Marchi
>
>>
>>BR,
>>Jani.
>>
>>
>>-- 
>>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13 16:48     ` Lucas De Marchi
@ 2019-06-13 17:04       ` Rodrigo Vivi
  2019-06-14 12:47         ` Jani Nikula
  0 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2019-06-13 17:04 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Thu, Jun 13, 2019 at 09:48:16AM -0700, Lucas De Marchi wrote:
> On Thu, Jun 13, 2019 at 09:29:48AM -0700, Lucas De Marchi wrote:
> > On Thu, Jun 13, 2019 at 04:12:37PM +0300, Jani Nikula wrote:
> > > On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > > > We are slowly converting dev_priv to i915 everywhere, spread into
> > > > smaller series. While this is good to avoid unrelated breakages to other
> > > > inflight patches, it's bad because inflight patches on nearby paths keep
> > > > breaking. Paired with other code moves and refactores this is becoming a
> > > > nightmare.
> > > > 
> > > > Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
> > > > longer exists we can simply sed all files and be done with the
> > > > conversion. This was generated with the following commands with no
> > > > additional fixups:
> > > > 
> > > > 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
> > > > 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
> > > > 
> > > > Any pending series can apply the same search and replace when rebasing.
> > > 
> > > I'm pretty strongly against renaming the implicit dev_priv local
> > > variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
> > > converting a function to not use the implicit dev_priv helps us by
> > > catching any leftover references.
> > 
> > I don't think this is strong enough reason to block the conversion. The
> > conversion is taking forever and is gonna take year+ if it continues at
> > this pace. It affects multiple developers rebasing their work and
> > introduce bugs on pending series.
> > 
> > Removing any file-scope reference (I didn't review yet if we still have
> > any) and reviewing the macros is sufficient. And if we later we find out
> > we missed one, we just go and fix it. I see zero advantage on slow and
> > forever. You have a mixed code base and new code following what's around
> > will just propagate more the mixed code base :(
> 
> btw, let me be clear the proposal is not "this should be done now". I do
> think we should be smart and think on the best opportunity to do it.
> Probably like after the big code moves gt/, gem/, display/, etc end.

yeap, doing per folder is probably a good thing, specially because gt and gem
are far ahead this conversion.

> 
> Lucas De Marchi
> 
> > 
> > Lucas De Marchi
> > 
> > > 
> > > BR,
> > > Jani.
> > > 
> > > 
> > > -- 
> > > Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-13 17:04       ` Rodrigo Vivi
@ 2019-06-14 12:47         ` Jani Nikula
  2019-06-14 17:06           ` Lucas De Marchi
  0 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2019-06-14 12:47 UTC (permalink / raw)
  To: Rodrigo Vivi, Lucas De Marchi; +Cc: intel-gfx

On Thu, 13 Jun 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Jun 13, 2019 at 09:48:16AM -0700, Lucas De Marchi wrote:
>> On Thu, Jun 13, 2019 at 09:29:48AM -0700, Lucas De Marchi wrote:
>> > On Thu, Jun 13, 2019 at 04:12:37PM +0300, Jani Nikula wrote:
>> > > On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> > > > We are slowly converting dev_priv to i915 everywhere, spread into
>> > > > smaller series. While this is good to avoid unrelated breakages to other
>> > > > inflight patches, it's bad because inflight patches on nearby paths keep
>> > > > breaking. Paired with other code moves and refactores this is becoming a
>> > > > nightmare.
>> > > > 
>> > > > Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>> > > > longer exists we can simply sed all files and be done with the
>> > > > conversion. This was generated with the following commands with no
>> > > > additional fixups:
>> > > > 
>> > > > 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>> > > > 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>> > > > 
>> > > > Any pending series can apply the same search and replace when rebasing.
>> > > 
>> > > I'm pretty strongly against renaming the implicit dev_priv local
>> > > variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
>> > > converting a function to not use the implicit dev_priv helps us by
>> > > catching any leftover references.
>> > 
>> > I don't think this is strong enough reason to block the conversion. The
>> > conversion is taking forever and is gonna take year+ if it continues at
>> > this pace. It affects multiple developers rebasing their work and
>> > introduce bugs on pending series.
>> > 
>> > Removing any file-scope reference (I didn't review yet if we still have
>> > any) and reviewing the macros is sufficient. And if we later we find out
>> > we missed one, we just go and fix it. I see zero advantage on slow and
>> > forever. You have a mixed code base and new code following what's around
>> > will just propagate more the mixed code base :(
>> 
>> btw, let me be clear the proposal is not "this should be done now". I do
>> think we should be smart and think on the best opportunity to do it.
>> Probably like after the big code moves gt/, gem/, display/, etc end.
>
> yeap, doing per folder is probably a good thing, specially because gt and gem
> are far ahead this conversion.

In general I think getting rid of the implicit dev_priv local is much
more important than a global s/dev_priv/i915/ rename. In the end, it's
just a local variable; the problematic part is the dependency on the
implicit name.

IMO you don't even have to do the rename at the time of getting rid of
the local. It's just a nice bonus to be able to freely choose the
variable name.

For the renames, sure, please do them in gt and gem subdirs first,
because that's actually feasible:

$ git grep -w dev_priv -- gt | wc -l
94

$ git grep -w dev_priv -- gem | wc -l
168

$ git grep -w dev_priv -- display | wc -l
6241


BR,
Jani.


>
>> 
>> Lucas De Marchi
>> 
>> > 
>> > Lucas De Marchi
>> > 
>> > > 
>> > > BR,
>> > > Jani.
>> > > 
>> > > 
>> > > -- 
>> > > Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* ✓ Fi.CI.IGT: success for gpu/drm/i915: globally replace dev_priv with i915
       [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
                   ` (5 preceding siblings ...)
       [not found] ` <0000a4b2-ac8b-a18d-4c78-0db197c712a1@linux.intel.com>
@ 2019-06-14 16:41 ` Patchwork
  6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-06-14 16:41 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: gpu/drm/i915: globally replace dev_priv with i915
URL   : https://patchwork.freedesktop.org/series/61983/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6253_full -> Patchwork_13261_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13261_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vcs1-s3:
    - shard-kbl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-kbl6/igt@gem_ctx_isolation@vcs1-s3.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-kbl1/igt@gem_ctx_isolation@vcs1-s3.html

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108566])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl3/igt@gem_ctx_isolation@vecs0-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl3/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@gem_eio@in-flight-contexts-1us:
    - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-glk6/igt@gem_eio@in-flight-contexts-1us.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-glk5/igt@gem_eio@in-flight-contexts-1us.html

  * igt@gem_eio@reset-stress:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl4/igt@gem_eio@reset-stress.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl1/igt@gem_eio@reset-stress.html

  * igt@gem_fence_thrash@bo-copy:
    - shard-apl:          [PASS][9] -> [INCOMPLETE][10] ([fdo#103927])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl2/igt@gem_fence_thrash@bo-copy.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl6/igt@gem_fence_thrash@bo-copy.html

  * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
    - shard-snb:          [PASS][11] -> [DMESG-WARN][12] ([fdo#110789] / [fdo#110913 ]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-snb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-snb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-hsw:          [PASS][13] -> [DMESG-WARN][14] ([fdo#110789] / [fdo#110913 ])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-skl:          [PASS][15] -> [DMESG-WARN][16] ([fdo#110913 ]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-kbl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#110913 ])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-kbl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-iclb:         [PASS][19] -> [DMESG-WARN][20] ([fdo#110913 ])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@kms_atomic_transition@plane-toggle-modeset-transition:
    - shard-iclb:         [PASS][21] -> [INCOMPLETE][22] ([fdo#107713])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb1/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb7/igt@kms_atomic_transition@plane-toggle-modeset-transition.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-180:
    - shard-kbl:          [PASS][23] -> [DMESG-FAIL][24] ([fdo#105763])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-kbl1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-kbl7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
    - shard-apl:          [PASS][25] -> [FAIL][26] ([fdo#103232]) +2 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][27] -> [FAIL][28] ([fdo#105363])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-skl:          [PASS][29] -> [INCOMPLETE][30] ([fdo#109507])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl6/igt@kms_flip@flip-vs-suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl8/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][31] -> [FAIL][32] ([fdo#103167]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109642])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb2/igt@kms_psr2_su@page_flip.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb4/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#109441]) +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [PASS][37] -> [FAIL][38] ([fdo#100047])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb5/igt@kms_sysfs_edid_timing.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb3/igt@kms_sysfs_edid_timing.html

  
#### Possible fixes ####

  * igt@gem_eio@in-flight-internal-immediate:
    - shard-snb:          [DMESG-WARN][39] ([fdo#110789] / [fdo#110913 ]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-snb1/igt@gem_eio@in-flight-internal-immediate.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-snb6/igt@gem_eio@in-flight-internal-immediate.html

  * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
    - shard-hsw:          [DMESG-WARN][41] ([fdo#110789] / [fdo#110913 ]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-hsw2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-hsw4/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-kbl:          [DMESG-WARN][43] ([fdo#110913 ]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-skl:          [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +2 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl8/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-iclb:         [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
    - shard-hsw:          [DMESG-WARN][49] ([fdo#110913 ]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-glk:          [DMESG-WARN][51] ([fdo#110913 ]) -> [PASS][52] +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-glk7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-glk1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] +3 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl7/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-skl:          [INCOMPLETE][55] ([fdo#104108]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl6/igt@i915_suspend@fence-restore-untiled.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl9/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-random:
    - shard-skl:          [FAIL][57] ([fdo#103232]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][59] ([fdo#109349]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@2x-flip-vs-modeset-vs-hang-interruptible:
    - shard-hsw:          [INCOMPLETE][61] ([fdo#103540]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-hsw4/igt@kms_flip@2x-flip-vs-modeset-vs-hang-interruptible.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-hsw7/igt@kms_flip@2x-flip-vs-modeset-vs-hang-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
    - shard-iclb:         [FAIL][63] ([fdo#103167]) -> [PASS][64] +3 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [SKIP][65] ([fdo#109271]) -> [PASS][66] +28 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
    - shard-skl:          [FAIL][67] ([fdo#108145]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [FAIL][69] ([fdo#103166]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][71] ([fdo#108341]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb1/igt@kms_psr@no_drrs.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb8/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][73] ([fdo#109441]) -> [PASS][74] +2 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@perf_pmu@rc6-runtime-pm-long:
    - shard-apl:          [FAIL][75] ([fdo#105010]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl4/igt@perf_pmu@rc6-runtime-pm-long.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl1/igt@perf_pmu@rc6-runtime-pm-long.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-pgflip-blt:
    - shard-apl:          [INCOMPLETE][77] ([fdo#103927]) -> [SKIP][78] ([fdo#109271])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6253/shard-apl2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-pgflip-blt.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/shard-apl2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-pgflip-blt.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6253 -> Patchwork_13261

  CI_DRM_6253: 83fdc69645c5c6b511e36e171f1c75a6132f007c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5054: 7a295df596fdf71e5c28ecb1fbfec002060e9293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13261: 5585dfe286e95307d073e4d8025116f3c7ae7b01 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13261/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
  2019-06-14 12:47         ` Jani Nikula
@ 2019-06-14 17:06           ` Lucas De Marchi
  0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-06-14 17:06 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Fri, Jun 14, 2019 at 03:47:49PM +0300, Jani Nikula wrote:
>On Thu, 13 Jun 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> On Thu, Jun 13, 2019 at 09:48:16AM -0700, Lucas De Marchi wrote:
>>> On Thu, Jun 13, 2019 at 09:29:48AM -0700, Lucas De Marchi wrote:
>>> > On Thu, Jun 13, 2019 at 04:12:37PM +0300, Jani Nikula wrote:
>>> > > On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>> > > > We are slowly converting dev_priv to i915 everywhere, spread into
>>> > > > smaller series. While this is good to avoid unrelated breakages to other
>>> > > > inflight patches, it's bad because inflight patches on nearby paths keep
>>> > > > breaking. Paired with other code moves and refactores this is becoming a
>>> > > > nightmare.
>>> > > >
>>> > > > Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>>> > > > longer exists we can simply sed all files and be done with the
>>> > > > conversion. This was generated with the following commands with no
>>> > > > additional fixups:
>>> > > >
>>> > > > 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>>> > > > 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>>> > > >
>>> > > > Any pending series can apply the same search and replace when rebasing.
>>> > >
>>> > > I'm pretty strongly against renaming the implicit dev_priv local
>>> > > variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
>>> > > converting a function to not use the implicit dev_priv helps us by
>>> > > catching any leftover references.
>>> >
>>> > I don't think this is strong enough reason to block the conversion. The
>>> > conversion is taking forever and is gonna take year+ if it continues at
>>> > this pace. It affects multiple developers rebasing their work and
>>> > introduce bugs on pending series.
>>> >
>>> > Removing any file-scope reference (I didn't review yet if we still have
>>> > any) and reviewing the macros is sufficient. And if we later we find out
>>> > we missed one, we just go and fix it. I see zero advantage on slow and
>>> > forever. You have a mixed code base and new code following what's around
>>> > will just propagate more the mixed code base :(
>>>
>>> btw, let me be clear the proposal is not "this should be done now". I do
>>> think we should be smart and think on the best opportunity to do it.
>>> Probably like after the big code moves gt/, gem/, display/, etc end.
>>
>> yeap, doing per folder is probably a good thing, specially because gt and gem
>> are far ahead this conversion.
>
>In general I think getting rid of the implicit dev_priv local is much
>more important than a global s/dev_priv/i915/ rename. In the end, it's
>just a local variable; the problematic part is the dependency on the
>implicit name.
>
>IMO you don't even have to do the rename at the time of getting rid of
>the local. It's just a nice bonus to be able to freely choose the
>variable name.

I agree, the renames are causing major headaches for rebasing work
because it changes in some places, not all and give conflicts mixed with
other "real conflicts". End result is that the conflict is much more
difficult to solve.

>For the renames, sure, please do them in gt and gem subdirs first,
>because that's actually feasible:
>
>$ git grep -w dev_priv -- gt | wc -l
>94
>
>$ git grep -w dev_priv -- gem | wc -l
>168
>
>$ git grep -w dev_priv -- display | wc -l
>6241

thanks, will do.

Lucas De Marchi

>
>
>BR,
>Jani.
>
>
>>
>>>
>>> Lucas De Marchi
>>>
>>> >
>>> > Lucas De Marchi
>>> >
>>> > >
>>> > > BR,
>>> > > Jani.
>>> > >
>>> > >
>>> > > --
>>> > > Jani Nikula, Intel Open Source Graphics Center
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-06-14 17:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
2019-06-13  1:02 ` ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915 Patchwork
2019-06-13  1:03 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-13  2:19 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-13  6:07 ` [PATCH] " Chris Wilson
2019-06-13  6:14   ` Lucas De Marchi
2019-06-13 13:12 ` Jani Nikula
2019-06-13 16:29   ` Lucas De Marchi
2019-06-13 16:48     ` Lucas De Marchi
2019-06-13 17:04       ` Rodrigo Vivi
2019-06-14 12:47         ` Jani Nikula
2019-06-14 17:06           ` Lucas De Marchi
     [not found] ` <0000a4b2-ac8b-a18d-4c78-0db197c712a1@linux.intel.com>
2019-06-13 15:19   ` Chris Wilson
2019-06-13 15:21     ` Tvrtko Ursulin
2019-06-14 16:41 ` ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.