From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Emilio G. Cota" <cota@braap.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes
Date: Fri, 18 Jan 2019 19:45:10 +0000 [thread overview]
Message-ID: <87tvi5ycl5.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_-rWCT=S6hf=83tozdGtsj_U4zHi6jza4usbXk7cxkhQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Fri, 18 Jan 2019 at 18:16, Emilio G. Cota <cota@braap.org> wrote:
>>
>> On Fri, Jan 18, 2019 at 17:00:17 +0000, Alex Bennée wrote:
>> > Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> > > Can you modify the Makefile.include to use:
>> > > "fp-test ... 2>int-to-float.err || {cat int-to-float.err && exit 1;}"
>> >
>> > Well it's in the test-softfloat macro but sure...
>>
>> Actually, can we do &> instead of 2> ?
>
> "&>" is a bashism. The POSIX equivalent is >file.err 2>&1
>
> thanks
> -- PMM
I've gone for this:
# $1 = tests, $2 = description
test-softfloat = $(call quiet-command, \
- cd $(BUILD_DIR)/tests/fp && ./fp-test -s $(FP_TL) $1 > $2.out 2> $2.err, \
+ cd $(BUILD_DIR)/tests/fp && \
+ ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \
+ (cat $2.out && exit 1;), \
"FLOAT TEST", $2)
As for the tests it seems quite a lot are broken on s390x for a reason I
don't quite follow yet:
i32_to_f128
i64_to_f128
ui64_to_f128
extF80_to_i32
extF80_to_i32_r_minMag
extF80_eq
and more which I haven't confirmed yet. I'm tempted to ifndef the tests
for s390 for now while we sort out what's going on. Should I re-send
with that?
--
Alex Bennée
prev parent reply other threads:[~2019-01-18 19:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 13:26 [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes Alex Bennée
2019-01-17 13:26 ` [Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops Alex Bennée
2019-01-17 13:26 ` [Qemu-devel] [PULL 2/7] fp-bench: remove wrong exponent raise in fill_random Alex Bennée
2019-01-17 13:26 ` [Qemu-devel] [PULL 3/7] softfloat: enforce softfloat if the host's FMA is broken Alex Bennée
2019-01-17 13:27 ` [Qemu-devel] [PULL 4/7] include/fpu/softfloat: Fix compilation with Clang on s390x Alex Bennée
2019-01-17 13:27 ` [Qemu-devel] [PULL 5/7] tests/Makefile: add floating point tests Alex Bennée
2019-01-17 13:27 ` [Qemu-devel] [PULL 6/7] scripts/archive-source: include softfloat tests Alex Bennée
2019-01-17 13:27 ` [Qemu-devel] [PULL 7/7] tests/Makfile: add check-softfloat rule Alex Bennée
2019-01-17 17:37 ` [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes Peter Maydell
2019-01-17 18:30 ` Emilio G. Cota
2019-01-17 18:55 ` Peter Maydell
2019-01-17 20:08 ` Emilio G. Cota
2019-01-18 17:41 ` Alex Bennée
2019-01-18 17:42 ` Peter Maydell
2019-01-18 20:19 ` Emilio G. Cota
2019-01-17 20:10 ` Alex Bennée
2019-01-18 9:03 ` Philippe Mathieu-Daudé
2019-01-18 17:00 ` Alex Bennée
2019-01-18 18:16 ` Emilio G. Cota
2019-01-18 18:30 ` Peter Maydell
2019-01-18 19:45 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvi5ycl5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.