From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 4/8] drm/i915: Make all GPU resets atomic
Date: Thu, 17 Jan 2019 16:14:24 +0200
Message-ID: <87tvi7wev3.fsf@gaia.fi.intel.com>
References: <20190114210408.4561-1-chris@chris-wilson.co.uk>
 <20190114210408.4561-5-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 061266E3AC
 for <intel-gfx@lists.freedesktop.org>; Thu, 17 Jan 2019 14:16:12 +0000 (UTC)
In-Reply-To: <20190114210408.4561-5-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gcHJl
cGFyYXRpb24gZm9yIHRoZSBuZXh0IGZldyBjb21taXRzLCBtYWtlIHJlc2V0dGluZyB0aGUgR1BV
IGF0b21pYy4KPiBDdXJyZW50bHksIHdlIGhhdmUgcHJlcGFyZWQgZ2VuNisgZm9yIGF0b21pYyBy
ZXNldHRpbmcgb2YgaW5kaXZpZHVhbAo+IGVuZ2luZXMsIGJ1dCBub3cgdGhlcmUgaXMgYSByZXF1
aXJlbWVudCB0byBwZXJmb3JtIHRoZSB3aG9sZSBkZXZpY2UKPiBsZXZlbCByZXNldCAoanVzdCB0
aGUgcmVnaXN0ZXIgcG9raW5nKSBmcm9tIGluc2lkZSBhbiBhdG9taWMgY29udGV4dC4KPgo+IFNp
Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0t
LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMgICAgICAgICAgICAgfCA1MCAr
KysrKysrKysrLS0tLS0tLS0tCj4gIC4uLi9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ2Vt
X2RldmljZS5jICB8ICA0ICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg
MjUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9yZXNldC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5jCj4gaW5kZXggZTJl
NDBiNDRhOWE4Li5mOTUxMmUwNzY0NmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9yZXNldC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXNldC5j
Cj4gQEAgLTE0NCwxNCArMTQ0LDE0IEBAIHN0YXRpYyBpbnQgaTkxNV9kb19yZXNldChzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgCj4gIAkvKiBBc3NlcnQgcmVzZXQgZm9yIGF0IGxl
YXN0IDIwIHVzZWMsIGFuZCB3YWl0IGZvciBhY2tub3dsZWRnZW1lbnQuICovCj4gIAlwY2lfd3Jp
dGVfY29uZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwgR1JET01fUkVTRVRfRU5BQkxFKTsKPiAt
CXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPiAtCWVyciA9IHdhaXRfZm9yKGk5MTVfaW5fcmVzZXQo
cGRldiksIDUwMCk7Cj4gKwl1ZGVsYXkoNTApOwo+ICsJZXJyID0gd2FpdF9mb3JfYXRvbWljKGk5
MTVfaW5fcmVzZXQocGRldiksIDUwKTsKPiAgCj4gIAkvKiBDbGVhciB0aGUgcmVzZXQgcmVxdWVz
dC4gKi8KPiAgCXBjaV93cml0ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCAwKTsKPiAt
CXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPiArCXVkZWxheSg1MCk7Cj4gIAlpZiAoIWVycikKPiAt
CQllcnIgPSB3YWl0X2ZvcighaTkxNV9pbl9yZXNldChwZGV2KSwgNTAwKTsKPiArCQllcnIgPSB3
YWl0X2Zvcl9hdG9taWMoIWk5MTVfaW5fcmVzZXQocGRldiksIDUwKTsKCjUwbXMgc3RpbGwgc2Vl
bXMgbG9uZyBidXQgSSBndWVzcyB5b3Ugd2FudCB0byBwbGF5IGl0IHNhZmUuCgpXb3VsZG4ndCBp
dCBiZSBuaWNlIGlmIHdlIHdvdWxkIGdldCBlYXNpbHkgcHVibGlzaCBhIGNvbXBsZXRpb24KdGlt
ZSB2YWx1ZSB0byBzb21lIGV4dGVybmFsIGRhdGFiYXNlIGZyb20gQ0kuCgo+ICAKPiAgCXJldHVy
biBlcnI7Cj4gIH0KPiBAQCAtMTcxLDcgKzE3MSw3IEBAIHN0YXRpYyBpbnQgZzMzX2RvX3Jlc2V0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAJc3RydWN0IHBjaV9kZXYgKnBkZXYg
PSBpOTE1LT5kcm0ucGRldjsKPiAgCj4gIAlwY2lfd3JpdGVfY29uZmlnX2J5dGUocGRldiwgSTkx
NV9HRFJTVCwgR1JET01fUkVTRVRfRU5BQkxFKTsKPiAtCXJldHVybiB3YWl0X2ZvcihnNHhfcmVz
ZXRfY29tcGxldGUocGRldiksIDUwMCk7Cj4gKwlyZXR1cm4gd2FpdF9mb3JfYXRvbWljKGc0eF9y
ZXNldF9jb21wbGV0ZShwZGV2KSwgNTApOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGc0eF9kb19y
ZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gQEAgLTE4MiwxMyArMTgy
LDEzIEBAIHN0YXRpYyBpbnQgZzR4X2RvX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiwKPiAgCWludCByZXQ7Cj4gIAo+ICAJLyogV2FWY3BDbGtHYXRlRGlzYWJsZUZvck1l
ZGlhUmVzZXQ6Y3RnLGVsayAqLwo+IC0JSTkxNV9XUklURShWREVDQ0xLX0dBVEVfRCwKPiAtCQkg
ICBJOTE1X1JFQUQoVkRFQ0NMS19HQVRFX0QpIHwgVkNQX1VOSVRfQ0xPQ0tfR0FURV9ESVNBQkxF
KTsKPiAtCVBPU1RJTkdfUkVBRChWREVDQ0xLX0dBVEVfRCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZE
RUNDTEtfR0FURV9ELAo+ICsJCSAgICAgIEk5MTVfUkVBRChWREVDQ0xLX0dBVEVfRCkgfCBWQ1Bf
VU5JVF9DTE9DS19HQVRFX0RJU0FCTEUpOwo+ICsJUE9TVElOR19SRUFEX0ZXKFZERUNDTEtfR0FU
RV9EKTsKPiAgCj4gIAlwY2lfd3JpdGVfY29uZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwKPiAg
CQkJICAgICAgR1JET01fTUVESUEgfCBHUkRPTV9SRVNFVF9FTkFCTEUpOwo+IC0JcmV0ID0gIHdh
aXRfZm9yKGc0eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTAwKTsKPiArCXJldCA9ICB3YWl0X2Zv
cl9hdG9taWMoZzR4X3Jlc2V0X2NvbXBsZXRlKHBkZXYpLCA1MCk7Cj4gIAlpZiAocmV0KSB7Cj4g
IAkJRFJNX0RFQlVHX0RSSVZFUigiV2FpdCBmb3IgbWVkaWEgcmVzZXQgZmFpbGVkXG4iKTsKPiAg
CQlnb3RvIG91dDsKPiBAQCAtMTk2LDcgKzE5Niw3IEBAIHN0YXRpYyBpbnQgZzR4X2RvX3Jlc2V0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCj4gIAlwY2lfd3JpdGVfY29u
ZmlnX2J5dGUocGRldiwgSTkxNV9HRFJTVCwKPiAgCQkJICAgICAgR1JET01fUkVOREVSIHwgR1JE
T01fUkVTRVRfRU5BQkxFKTsKPiAtCXJldCA9ICB3YWl0X2ZvcihnNHhfcmVzZXRfY29tcGxldGUo
cGRldiksIDUwMCk7Cj4gKwlyZXQgPSAgd2FpdF9mb3JfYXRvbWljKGc0eF9yZXNldF9jb21wbGV0
ZShwZGV2KSwgNTApOwo+ICAJaWYgKHJldCkgewo+ICAJCURSTV9ERUJVR19EUklWRVIoIldhaXQg
Zm9yIHJlbmRlciByZXNldCBmYWlsZWRcbiIpOwo+ICAJCWdvdG8gb3V0Owo+IEBAIC0yMDUsOSAr
MjA1LDkgQEAgc3RhdGljIGludCBnNHhfZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2LAo+ICBvdXQ6Cj4gIAlwY2lfd3JpdGVfY29uZmlnX2J5dGUocGRldiwgSTkxNV9H
RFJTVCwgMCk7Cj4gIAo+IC0JSTkxNV9XUklURShWREVDQ0xLX0dBVEVfRCwKPiAtCQkgICBJOTE1
X1JFQUQoVkRFQ0NMS19HQVRFX0QpICYgflZDUF9VTklUX0NMT0NLX0dBVEVfRElTQUJMRSk7Cj4g
LQlQT1NUSU5HX1JFQUQoVkRFQ0NMS19HQVRFX0QpOwo+ICsJSTkxNV9XUklURV9GVyhWREVDQ0xL
X0dBVEVfRCwKPiArCQkgICAgICBJOTE1X1JFQUQoVkRFQ0NMS19HQVRFX0QpICYgflZDUF9VTklU
X0NMT0NLX0dBVEVfRElTQUJMRSk7Cj4gKwlQT1NUSU5HX1JFQURfRlcoVkRFQ0NMS19HQVRFX0Qp
Owo+ICAKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiBAQCAtMjE4LDI3ICsyMTgsMjkgQEAgc3RhdGlj
IGludCBpcm9ubGFrZV9kb19yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+IC0JSTkxNV9XUklURShJTEtfR0RTUiwgSUxLX0dSRE9N
X1JFTkRFUiB8IElMS19HUkRPTV9SRVNFVF9FTkFCTEUpOwo+IC0JcmV0ID0gaW50ZWxfd2FpdF9m
b3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkgICAgICBJTEtfR0RTUiwgSUxLX0dSRE9NX1JF
U0VUX0VOQUJMRSwgMCwKPiAtCQkJCSAgICAgIDUwMCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKElMS19H
RFNSLCBJTEtfR1JET01fUkVOREVSIHwgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gKwlyZXQg
PSBfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyX2Z3KGRldl9wcml2LCBJTEtfR0RTUiwKPiArCQkJ
CQkgICBJTEtfR1JET01fUkVTRVRfRU5BQkxFLCAwLAo+ICsJCQkJCSAgIDUwMDAsIDAsCj4gKwkJ
CQkJICAgTlVMTCk7CgpGcm9tIDUwMG1zIHRvIDVtcy4gVGhlcmUgaGFzIGJlZW4gc29tZSBzbGFj
ayBpbiB0aGVyZSBmb3Igc3VyZS4uLgoKPiAgCWlmIChyZXQpIHsKPiAgCQlEUk1fREVCVUdfRFJJ
VkVSKCJXYWl0IGZvciByZW5kZXIgcmVzZXQgZmFpbGVkXG4iKTsKPiAgCQlnb3RvIG91dDsKPiAg
CX0KPiAgCj4gLQlJOTE1X1dSSVRFKElMS19HRFNSLCBJTEtfR1JET01fTUVESUEgfCBJTEtfR1JE
T01fUkVTRVRfRU5BQkxFKTsKPiAtCXJldCA9IGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9w
cml2LAo+IC0JCQkJICAgICAgSUxLX0dEU1IsIElMS19HUkRPTV9SRVNFVF9FTkFCTEUsIDAsCj4g
LQkJCQkgICAgICA1MDApOwo+ICsJSTkxNV9XUklURV9GVyhJTEtfR0RTUiwgSUxLX0dSRE9NX01F
RElBIHwgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gKwlyZXQgPSBfX2ludGVsX3dhaXRfZm9y
X3JlZ2lzdGVyX2Z3KGRldl9wcml2LCBJTEtfR0RTUiwKPiArCQkJCQkgICBJTEtfR1JET01fUkVT
RVRfRU5BQkxFLCAwLAo+ICsJCQkJCSAgIDUwMDAsIDAsCj4gKwkJCQkJICAgTlVMTCk7Cj4gIAlp
ZiAocmV0KSB7Cj4gIAkJRFJNX0RFQlVHX0RSSVZFUigiV2FpdCBmb3IgbWVkaWEgcmVzZXQgZmFp
bGVkXG4iKTsKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4gIG91dDoKPiAtCUk5MTVfV1JJVEUo
SUxLX0dEU1IsIDApOwo+IC0JUE9TVElOR19SRUFEKElMS19HRFNSKTsKPiArCUk5MTVfV1JJVEVf
RlcoSUxLX0dEU1IsIDApOwo+ICsJUE9TVElOR19SRUFEX0ZXKElMS19HRFNSKTsKPiAgCXJldHVy
biByZXQ7Cj4gIH0KPiAgCj4gQEAgLTU3Miw3ICs1NzQsOSBAQCBpbnQgaW50ZWxfZ3B1X3Jlc2V0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCB1bnNpZ25lZCBpbnQgZW5naW5lX21hc2sp
Cj4gIAkJcmV0ID0gLUVOT0RFVjsKPiAgCQlpZiAocmVzZXQpIHsKCk9rLCBpIG1pZ2h0IGhhdmUg
bWlzc2VkIHNvbWUgc3BvdCBidXQgZm9yIG1lIGl0IGxvb2tzCmxpa2UgeW91IGNhbiBsaWZ0IHRo
ZSBtaWdodF9zbGVlcF9pZihlbmdpbmVfbWFzayA9PSBBTExfRU5HSU5FUykKZnJvbSBhYm92ZS4K
Cj4gIAkJCUdFTV9UUkFDRSgiZW5naW5lX21hc2s9JXhcbiIsIGVuZ2luZV9tYXNrKTsKPiArCQkJ
cHJlZW1wdF9kaXNhYmxlKCk7Cj4gIAkJCXJldCA9IHJlc2V0KGk5MTUsIGVuZ2luZV9tYXNrLCBy
ZXRyeSk7Cj4gKwkJCXByZWVtcHRfZW5hYmxlKCk7Cj4gIAkJfQo+ICAJCWlmIChyZXQgIT0gLUVU
SU1FRE9VVCB8fCBlbmdpbmVfbWFzayAhPSBBTExfRU5HSU5FUykKPiAgCQkJYnJlYWs7Cj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2Uu
YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2UuYwo+IGlu
ZGV4IDNjZGE2NjI5MmU3Ni4uODg4YzY5NzhiYzU0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2dlbV9kZXZpY2UuYwo+IEBAIC01OCw4ICs1OCw4IEBA
IHN0YXRpYyB2b2lkIG1vY2tfZGV2aWNlX3JlbGVhc2Uoc3RydWN0IGRybV9kZXZpY2UgKmRldikK
PiAgCWk5MTVfZ2VtX2NvbnRleHRzX2xvc3QoaTkxNSk7Cj4gIAltdXRleF91bmxvY2soJmk5MTUt
PmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAKPiAtCWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmaTkx
NS0+Z3QucmV0aXJlX3dvcmspOwo+IC0JY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZpOTE1LT5n
dC5pZGxlX3dvcmspOwo+ICsJZHJhaW5fZGVsYXllZF93b3JrKCZpOTE1LT5ndC5yZXRpcmVfd29y
ayk7Cj4gKwlkcmFpbl9kZWxheWVkX3dvcmsoJmk5MTUtPmd0LmlkbGVfd29yayk7CgpZZWFoLCBi
dXQgd2h5IGluIHRoaXMgcGF0Y2g/Ci1NaWthCgo+ICAJaTkxNV9nZW1fZHJhaW5fd29ya3F1ZXVl
KGk5MTUpOwo+ICAKPiAgCW11dGV4X2xvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+IC0t
IAo+IDIuMjAuMQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK