From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752035AbeBZPbp (ORCPT ); Mon, 26 Feb 2018 10:31:45 -0500 Received: from mga07.intel.com ([134.134.136.100]:39490 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbeBZPbj (ORCPT ); Mon, 26 Feb 2018 10:31:39 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,397,1515484800"; d="scan'208";a="33712202" From: Jani Nikula To: Chris Wilson , linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, Chris Wilson , Rusty Russell , Jean Delvare , Andrew Morton , Li Zhong , Petri Latvala , Daniel Vetter Subject: Re: [PATCH] kernel: Downgrade warning for unsafe parameters In-Reply-To: <20180226151919.9674-1-chris@chris-wilson.co.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180226151919.9674-1-chris@chris-wilson.co.uk> Date: Mon, 26 Feb 2018 17:31:32 +0200 Message-ID: <87tvu322ej.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Feb 2018, Chris Wilson wrote: > As using an unsafe module parameter is, by its very definition, an > expected user action, emitting a warning is overkill. Nothing has yet > gone wrong, and we add a taint flag for any future oops should > something actually go wrong. So instead of having a user controllable > pr_warn, downgrade it to a pr_notice for "a normal, but significant > condition". > > We make use of unsafe kernel parameters in igt (we have not yet > succeeded in removing all such debugging options), which generates a > warning and taints the kernel. The warning is unhelpful as we then need > to filter it out again as we check that every test themselves do not > provoke any kernel warnings. IGT being https://cgit.freedesktop.org/drm/igt-gpu-tools/ for those not in the DRM/KMS circles. > References: 91f9d330cc14 ("module: make it possible to have unsafe, tainting module params") > Signed-off-by: Chris Wilson > Cc: Jani Nikula > Cc: Rusty Russell > Cc: Jean Delvare > Cc: Andrew Morton > Cc: Li Zhong > Cc: Petri Latvala > Cc: Daniel Vetter Acked-by: Jani Nikula When I added the unsafe module params, I erred on the side of making more noise about tainting, but there was really no discussion about it. FWIW, I don't mind the change, as long as it's not debug level. BR, Jani. > --- > kernel/params.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/params.c b/kernel/params.c > index cc9108c2a1fd..ce89f757e6da 100644 > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -111,8 +111,8 @@ bool parameq(const char *a, const char *b) > static void param_check_unsafe(const struct kernel_param *kp) > { > if (kp->flags & KERNEL_PARAM_FL_UNSAFE) { > - pr_warn("Setting dangerous option %s - tainting kernel\n", > - kp->name); > + pr_notice("Setting dangerous option %s - tainting kernel\n", > + kp->name); > add_taint(TAINT_USER, LOCKDEP_STILL_OK); > } > } -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] kernel: Downgrade warning for unsafe parameters Date: Mon, 26 Feb 2018 17:31:32 +0200 Message-ID: <87tvu322ej.fsf@intel.com> References: <20180226151919.9674-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 454386E032 for ; Mon, 26 Feb 2018 15:31:39 +0000 (UTC) In-Reply-To: <20180226151919.9674-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , linux-kernel@vger.kernel.org Cc: Li Zhong , Daniel Vetter , intel-gfx@lists.freedesktop.org, Rusty Russell , Jean Delvare , Andrew Morton List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyNiBGZWIgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IEFzIHVzaW5nIGFuIHVuc2FmZSBtb2R1bGUgcGFyYW1ldGVyIGlzLCBieSBp dHMgdmVyeSBkZWZpbml0aW9uLCBhbgo+IGV4cGVjdGVkIHVzZXIgYWN0aW9uLCBlbWl0dGluZyBh IHdhcm5pbmcgaXMgb3ZlcmtpbGwuIE5vdGhpbmcgaGFzIHlldAo+IGdvbmUgd3JvbmcsIGFuZCB3 ZSBhZGQgYSB0YWludCBmbGFnIGZvciBhbnkgZnV0dXJlIG9vcHMgc2hvdWxkCj4gc29tZXRoaW5n IGFjdHVhbGx5IGdvIHdyb25nLiBTbyBpbnN0ZWFkIG9mIGhhdmluZyBhIHVzZXIgY29udHJvbGxh YmxlCj4gcHJfd2FybiwgZG93bmdyYWRlIGl0IHRvIGEgcHJfbm90aWNlIGZvciAiYSBub3JtYWws IGJ1dCBzaWduaWZpY2FudAo+IGNvbmRpdGlvbiIuCj4KPiBXZSBtYWtlIHVzZSBvZiB1bnNhZmUg a2VybmVsIHBhcmFtZXRlcnMgaW4gaWd0ICh3ZSBoYXZlIG5vdCB5ZXQKPiBzdWNjZWVkZWQgaW4g cmVtb3ZpbmcgYWxsIHN1Y2ggZGVidWdnaW5nIG9wdGlvbnMpLCB3aGljaCBnZW5lcmF0ZXMgYQo+ IHdhcm5pbmcgYW5kIHRhaW50cyB0aGUga2VybmVsLiBUaGUgd2FybmluZyBpcyB1bmhlbHBmdWwg YXMgd2UgdGhlbiBuZWVkCj4gdG8gZmlsdGVyIGl0IG91dCBhZ2FpbiBhcyB3ZSBjaGVjayB0aGF0 IGV2ZXJ5IHRlc3QgdGhlbXNlbHZlcyBkbyBub3QKPiBwcm92b2tlIGFueSBrZXJuZWwgd2Fybmlu Z3MuCgpJR1QgYmVpbmcgaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9kcm0vaWd0LWdwdS10 b29scy8gZm9yIHRob3NlIG5vdAppbiB0aGUgRFJNL0tNUyBjaXJjbGVzLgoKPiBSZWZlcmVuY2Vz OiA5MWY5ZDMzMGNjMTQgKCJtb2R1bGU6IG1ha2UgaXQgcG9zc2libGUgdG8gaGF2ZSB1bnNhZmUs IHRhaW50aW5nIG1vZHVsZSBwYXJhbXMiKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA aW50ZWwuY29tPgo+IENjOiBSdXN0eSBSdXNzZWxsIDxydXN0eUBydXN0Y29ycC5jb20uYXU+Cj4g Q2M6IEplYW4gRGVsdmFyZSA8a2hhbGlAbGludXgtZnIub3JnPgo+IENjOiBBbmRyZXcgTW9ydG9u IDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+IENjOiBMaSBaaG9uZyA8emhvbmdAbGludXgu dm5ldC5pYm0uY29tPgo+IENjOiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNv bT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCkFja2VkLWJ5 OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKV2hlbiBJIGFkZGVkIHRoZSB1 bnNhZmUgbW9kdWxlIHBhcmFtcywgSSBlcnJlZCBvbiB0aGUgc2lkZSBvZiBtYWtpbmcKbW9yZSBu b2lzZSBhYm91dCB0YWludGluZywgYnV0IHRoZXJlIHdhcyByZWFsbHkgbm8gZGlzY3Vzc2lvbiBh Ym91dAppdC4gRldJVywgSSBkb24ndCBtaW5kIHRoZSBjaGFuZ2UsIGFzIGxvbmcgYXMgaXQncyBu b3QgZGVidWcgbGV2ZWwuCgpCUiwKSmFuaS4KCj4gLS0tCj4gIGtlcm5lbC9wYXJhbXMuYyB8IDQg KystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9wYXJhbXMuYyBiL2tlcm5lbC9wYXJhbXMuYwo+IGluZGV4 IGNjOTEwOGMyYTFmZC4uY2U4OWY3NTdlNmRhIDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9wYXJhbXMu Ywo+ICsrKyBiL2tlcm5lbC9wYXJhbXMuYwo+IEBAIC0xMTEsOCArMTExLDggQEAgYm9vbCBwYXJh bWVxKGNvbnN0IGNoYXIgKmEsIGNvbnN0IGNoYXIgKmIpCj4gIHN0YXRpYyB2b2lkIHBhcmFtX2No ZWNrX3Vuc2FmZShjb25zdCBzdHJ1Y3Qga2VybmVsX3BhcmFtICprcCkKPiAgewo+ICAJaWYgKGtw LT5mbGFncyAmIEtFUk5FTF9QQVJBTV9GTF9VTlNBRkUpIHsKPiAtCQlwcl93YXJuKCJTZXR0aW5n IGRhbmdlcm91cyBvcHRpb24gJXMgLSB0YWludGluZyBrZXJuZWxcbiIsCj4gLQkJCWtwLT5uYW1l KTsKPiArCQlwcl9ub3RpY2UoIlNldHRpbmcgZGFuZ2Vyb3VzIG9wdGlvbiAlcyAtIHRhaW50aW5n IGtlcm5lbFxuIiwKPiArCQkJICBrcC0+bmFtZSk7Cj4gIAkJYWRkX3RhaW50KFRBSU5UX1VTRVIs IExPQ0tERVBfU1RJTExfT0spOwo+ICAJfQo+ICB9CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=