From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758256AbdJQM0w (ORCPT ); Tue, 17 Oct 2017 08:26:52 -0400 Received: from ozlabs.org ([103.22.144.67]:44635 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754763AbdJQM0u (ORCPT ); Tue, 17 Oct 2017 08:26:50 -0400 From: Michael Ellerman To: Dan Carpenter , Julia Lawall Cc: Jarkko Sakkinen , SF Markus Elfring , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Nayna Jain , Paul Mackerras , Peter =?utf-8?Q?H=C3=BCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations In-Reply-To: <20171017094434.csarc5fw5d32u64w@mwanda> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <20171017085124.pkrjzghcf5wmcydc@mwanda> <20171017094434.csarc5fw5d32u64w@mwanda> Date: Tue, 17 Oct 2017 23:26:47 +1100 Message-ID: <87tvyyhse0.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: >> >> >> On Tue, 17 Oct 2017, Dan Carpenter wrote: >> >> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: >> > > >> > > A minor complaint: all commits are missing "Fixes:" tag. >> > > >> > >> > Fixes is only for bug fixes. These don't fix any bugs. >> >> 0-day seems to put Fixes for everything. Should they be removed when the >> old code is undesirable but doesn't actually cause a crash, eg out of date >> API. > > Yeah, I feel like Fixes tags don't belong for API updates and cleanups. I try to use the criteria of "if someone had backported commit A, would they also want commit B" (where B Fixes: A). So it's a bit broader than just "A had a *bug*" and this is the fix. That's obviously still a bit of a slippery slope, but somewhat helpful I think. eg, pretty much no one is interested in backporting spelling fixes, so those aren't Fixes. And generally people aren't interested in backporting commits like these ones that just update coding style. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Tue, 17 Oct 2017 12:26:47 +0000 Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-Id: <87tvyyhse0.fsf@concordia.ellerman.id.au> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <20171017085124.pkrjzghcf5wmcydc@mwanda> <20171017094434.csarc5fw5d32u64w@mwanda> In-Reply-To: <20171017094434.csarc5fw5d32u64w@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Julia Lawall Cc: Jarkko Sakkinen , SF Markus Elfring , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Nayna Jain , Paul Mackerras , Peter =?utf-8?Q?H=C3=BCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Dan Carpenter writes: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: >> >> >> On Tue, 17 Oct 2017, Dan Carpenter wrote: >> >> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: >> > > >> > > A minor complaint: all commits are missing "Fixes:" tag. >> > > >> > >> > Fixes is only for bug fixes. These don't fix any bugs. >> >> 0-day seems to put Fixes for everything. Should they be removed when the >> old code is undesirable but doesn't actually cause a crash, eg out of date >> API. > > Yeah, I feel like Fixes tags don't belong for API updates and cleanups. I try to use the criteria of "if someone had backported commit A, would they also want commit B" (where B Fixes: A). So it's a bit broader than just "A had a *bug*" and this is the fix. That's obviously still a bit of a slippery slope, but somewhat helpful I think. eg, pretty much no one is interested in backporting spelling fixes, so those aren't Fixes. And generally people aren't interested in backporting commits like these ones that just update coding style. cheers