From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbdATFru (ORCPT ); Fri, 20 Jan 2017 00:47:50 -0500 Received: from ozlabs.org ([103.22.144.67]:56851 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdATFrs (ORCPT ); Fri, 20 Jan 2017 00:47:48 -0500 From: Michael Ellerman To: Hari Bathini , linux-kernel@vger.kernel.org Cc: fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, dyoung@redhat.com, kexec@lists.infradead.org, Mahesh J Salgaonkar , ebiederm@xmission.com, linuxppc-dev@lists.ozlabs.org, vgoyal@redhat.com Subject: Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions In-Reply-To: <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> References: <148363729327.11570.6244765717789390817.stgit@hbathini.in.ibm.com> <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 20 Jan 2017 16:47:38 +1100 Message-ID: <87tw8umged.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hari Bathini writes: > Get rid of multiple definitions of append_elf_note() & final_note() > functions. Reuse these functions compiled under CONFIG_CRASH_CORE > Also, define Elf_Word and use it instead of generic u32 or the more > specific Elf64_Word. > > Signed-off-by: Hari Bathini > --- > > Changes from v3: > * Dropped hard-coded values and used DIV_ROUND_UP(). > > Changes from v2: > * Added a definition for Elf_Word. > * Used IA64 version of append_elf_note() and final_note() functions. > > > arch/ia64/kernel/crash.c | 22 ---------------------- > include/linux/crash_core.h | 4 ++++ > include/linux/elf.h | 2 ++ > kernel/crash_core.c | 34 ++++++++++++++-------------------- > kernel/kexec_core.c | 28 ---------------------------- > 5 files changed, 20 insertions(+), 70 deletions(-) Do the powerpc patches later in the series actually depend on this one? Or is this just an unrelated cleanup? As it is I can't merge the series until we at least get an ack on this from the ia64 folks. If you can just split this out as a separate patch that would make it a lot easier to get the rest merged. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ozlabs.org ([103.22.144.67]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cUS3w-0007rG-1m for kexec@lists.infradead.org; Fri, 20 Jan 2017 05:48:37 +0000 From: Michael Ellerman Subject: Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions In-Reply-To: <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> References: <148363729327.11570.6244765717789390817.stgit@hbathini.in.ibm.com> <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> Date: Fri, 20 Jan 2017 16:47:38 +1100 Message-ID: <87tw8umged.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Hari Bathini , linux-kernel@vger.kernel.org Cc: fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com Hari Bathini writes: > Get rid of multiple definitions of append_elf_note() & final_note() > functions. Reuse these functions compiled under CONFIG_CRASH_CORE > Also, define Elf_Word and use it instead of generic u32 or the more > specific Elf64_Word. > > Signed-off-by: Hari Bathini > --- > > Changes from v3: > * Dropped hard-coded values and used DIV_ROUND_UP(). > > Changes from v2: > * Added a definition for Elf_Word. > * Used IA64 version of append_elf_note() and final_note() functions. > > > arch/ia64/kernel/crash.c | 22 ---------------------- > include/linux/crash_core.h | 4 ++++ > include/linux/elf.h | 2 ++ > kernel/crash_core.c | 34 ++++++++++++++-------------------- > kernel/kexec_core.c | 28 ---------------------------- > 5 files changed, 20 insertions(+), 70 deletions(-) Do the powerpc patches later in the series actually depend on this one? Or is this just an unrelated cleanup? As it is I can't merge the series until we at least get an ack on this from the ia64 folks. If you can just split this out as a separate patch that would make it a lot easier to get the rest merged. cheers _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Fri, 20 Jan 2017 05:47:38 +0000 Subject: Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions Message-Id: <87tw8umged.fsf@concordia.ellerman.id.au> List-Id: References: <148363729327.11570.6244765717789390817.stgit@hbathini.in.ibm.com> <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> In-Reply-To: <148363740554.11570.4870634597647436827.stgit@hbathini.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hari Bathini , linux-kernel@vger.kernel.org Cc: fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, dyoung@redhat.com, kexec@lists.infradead.org, Mahesh J Salgaonkar , ebiederm@xmission.com, linuxppc-dev@lists.ozlabs.org, vgoyal@redhat.com Hari Bathini writes: > Get rid of multiple definitions of append_elf_note() & final_note() > functions. Reuse these functions compiled under CONFIG_CRASH_CORE > Also, define Elf_Word and use it instead of generic u32 or the more > specific Elf64_Word. > > Signed-off-by: Hari Bathini > --- > > Changes from v3: > * Dropped hard-coded values and used DIV_ROUND_UP(). > > Changes from v2: > * Added a definition for Elf_Word. > * Used IA64 version of append_elf_note() and final_note() functions. > > > arch/ia64/kernel/crash.c | 22 ---------------------- > include/linux/crash_core.h | 4 ++++ > include/linux/elf.h | 2 ++ > kernel/crash_core.c | 34 ++++++++++++++-------------------- > kernel/kexec_core.c | 28 ---------------------------- > 5 files changed, 20 insertions(+), 70 deletions(-) Do the powerpc patches later in the series actually depend on this one? Or is this just an unrelated cleanup? As it is I can't merge the series until we at least get an ack on this from the ia64 folks. If you can just split this out as a separate patch that would make it a lot easier to get the rest merged. cheers