From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks
Date: Tue, 02 Feb 2016 09:38:44 +0100 [thread overview]
Message-ID: <87twlrtskr.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <87zivkz8ec.fsf@blackfin.pond.sub.org> (Markus Armbruster's message of "Mon, 01 Feb 2016 17:45:47 +0100")
Markus Armbruster <armbru@redhat.com> writes:
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
>
>> Hi
>>
>> On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>> The existing users pass a func that saves dev, and free the saved dev
>>> later. Works as long as we call func() at most once. If multiple
>>> devices match, all but the last one are leaked. Can this happen?
>>
>> It is the responsability of the func() callback to deal with multiple
>> matches.
>
> If that's the case, and multiple devices can match, then the callbacks
> are all broken.
>
>> I don't think this needs to change.
>
> If you mean to say that you don't have to fix it in this series: yes,
> but it still needs fixing. If you don't want to fix it, consider adding
> a FIXME comment.
I'll have some ivshmem work coming up, and will try to remember to
include a fix for this.
[...]
next prev parent reply other threads:[~2016-02-02 8:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:30 [Qemu-devel] [PATCH 0/8] ivshmem: test msi=off, remove CharDriver marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 1/8] ivshmem: no need for opaque argument marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 2/8] ivshmem: remove redundant assignment, fix crash with msi=off marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 3/8] ivshmem-test: leak fixes marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 4/8] libqos: remove some leaks marcandre.lureau
2016-01-29 15:43 ` Markus Armbruster
2016-02-01 13:59 ` Marc-André Lureau
2016-02-01 16:45 ` Markus Armbruster
2016-02-02 8:38 ` Markus Armbruster [this message]
2015-12-21 11:30 ` [Qemu-devel] [PATCH 5/8] ivshmem-test: test both msi & irq cases marcandre.lureau
2015-12-21 11:30 ` [Qemu-devel] [PATCH 6/8] ivshmem: generalize ivshmem_setup_interrupts marcandre.lureau
2016-01-29 15:59 ` Markus Armbruster
2016-02-01 14:50 ` Marc-André Lureau
2016-02-01 16:50 ` Markus Armbruster
2015-12-21 11:30 ` [Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver marcandre.lureau
2016-01-29 16:23 ` Markus Armbruster
2016-02-01 15:22 ` Marc-André Lureau
2016-02-01 16:49 ` Markus Armbruster
2016-02-22 9:28 ` Markus Armbruster
2015-12-21 11:30 ` [Qemu-devel] [PATCH 8/8] char: remove qemu_chr_open_eventfd marcandre.lureau
2016-01-07 15:52 ` [Qemu-devel] [PATCH 0/8] ivshmem: test msi=off, remove CharDriver Marc-André Lureau
2016-01-29 10:12 ` Marc-André Lureau
2016-01-29 15:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twlrtskr.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.