From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer Date: Fri, 18 Dec 2015 11:49:07 +0200 Message-ID: <87twngccj0.fsf@intel.com> References: <1450428695-28831-1-git-send-email-jani.nikula@intel.com> <20151218091037.GA26780@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 939D76EA44 for ; Fri, 18 Dec 2015 01:49:09 -0800 (PST) In-Reply-To: <20151218091037.GA26780@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAxOCBEZWMgMjAxNSwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IE9uIEZyaSwgRGVjIDE4LCAyMDE1IGF0IDEwOjUxOjM1QU0gKzAyMDAsIEph bmkgTmlrdWxhIHdyb3RlOgo+PiBVc2UgZGV2X3ByaXYgcmF0aGVyIHRoYW4gZGV2IHBvaW50ZXIg d2hlcmUgYXBwbGljYWJsZS4gUmVtb3ZlIHBsZW50eSBvZgo+PiB1bm5lY2Vzc2FyeSB0ZW1wIHZh cmlhYmxlcy4gTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wYW5lbC5jIHwgMTU2ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCA1OCBpbnNlcnRpb25zKCspLCA5OCBkZWxldGlv bnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5l bC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+PiBpbmRleCBmNWI0Yzk4 ZGU2MDguLjIxZWU2NDc3YmY5OCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcGFuZWwuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5j Cj4+IEBAIC00NjEsOCArNDYxLDcgQEAgc3RhdGljIGlubGluZSB1MzIgc2NhbGVfaHdfdG9fdXNl cihzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICBzdGF0aWMgdTMyIGludGVs X3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0 b3IsCj4+ICAJCQkJCSAgdTMyIHZhbCkKPj4gIHsKPj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY29ubmVjdG9yLT5iYXNlLmRldjsKPj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4+ICAJc3RydWN0IGludGVs X3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+PiAgCj4+ICAJV0FSTl9PTihwYW5l bC0+YmFja2xpZ2h0Lm1heCA9PSAwKTsKPj4gQEAgLTQ4MCw0NSArNDc5LDQwIEBAIHN0YXRpYyB1 MzIgaW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKHN0cnVjdCBpbnRlbF9jb25uZWN0b3Ig KmNvbm5lY3RvciwKPj4gIAo+PiAgc3RhdGljIHUzMiBscHRfZ2V0X2JhY2tsaWdodChzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4+ICB7Cj4+IC0Jc3RydWN0IGRybV9kZXZpY2Ug KmRldiA9IGNvbm5lY3Rvci0+YmFzZS5kZXY7Cj4+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5lY3Rvci0+YmFzZS5kZXYpOwo+PiAgCj4+ICAJcmV0 dXJuIEk5MTVfUkVBRChCTENfUFdNX1BDSF9DVEwyKSAmIEJBQ0tMSUdIVF9EVVRZX0NZQ0xFX01B U0s7Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyB1MzIgcGNoX2dldF9iYWNrbGlnaHQoc3RydWN0IGlu dGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+PiAgewo+PiAtCXN0cnVjdCBkcm1fZGV2aWNlICpk ZXYgPSBjb25uZWN0b3ItPmJhc2UuZGV2Owo+PiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2KTsKPj4gIAo+PiAgCXJldHVy biBJOTE1X1JFQUQoQkxDX1BXTV9DUFVfQ1RMKSAmIEJBQ0tMSUdIVF9EVVRZX0NZQ0xFX01BU0s7 Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyB1MzIgaTl4eF9nZXRfYmFja2xpZ2h0KHN0cnVjdCBpbnRl bF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPj4gIHsKPj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY29ubmVjdG9yLT5iYXNlLmRldjsKPj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4+ICAJc3RydWN0IGludGVs X3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+PiAgCXUzMiB2YWw7Cj4+ICAKPj4g IAl2YWwgPSBJOTE1X1JFQUQoQkxDX1BXTV9DVEwpICYgQkFDS0xJR0hUX0RVVFlfQ1lDTEVfTUFT SzsKPj4gLQlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA0KQo+PiArCWlmIChJTlRFTF9JTkZP KGRldl9wcml2KS0+Z2VuIDwgNCkKPj4gIAkJdmFsID4+PSAxOwo+PiAgCj4+ICAJaWYgKHBhbmVs LT5iYWNrbGlnaHQuY29tYmluYXRpb25fbW9kZSkgewo+PiAgCQl1OCBsYnBjOwo+PiAgCj4+IC0J CXBjaV9yZWFkX2NvbmZpZ19ieXRlKGRldi0+cGRldiwgUENJX0xCUEMsICZsYnBjKTsKPj4gKwkJ cGNpX3JlYWRfY29uZmlnX2J5dGUoZGV2X3ByaXYtPmRldi0+cGRldiwgUENJX0xCUEMsICZsYnBj KTsKPgo+IGRldl9wcml2LT5kZXYtPnBkZXYKPiB0b19wY2lfZGV2KGRldl9wcml2KQoKTWFrZXMg c2Vuc2UuCgo+IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gdG9faTkxNV9mcm9tX2Nv bm5lY3Rvcihjb25uZWN0b3IpOwo+Cj4gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gdG9faTkx NV9mcm9tX2NydGMoY3J0Yyk7CgpJbiBwcmFjdGlzZSwgdG9faTkxNV9mcm9tX2Nvbm5lY3Rvcigm aW50ZWxfY29ubmVjdG9yLT5iYXNlKSBpcyBub3Qgc28KbmVhdC4gV291bGQgaGF2ZSB0byB0cnkg b3V0IHNvbWUgcGF0Y2hlcyB0byBzZWUgd2hhdCBpdCB0dXJucyBvdXQgdG8gYmUKbGlrZS4KCj4g SnVzdCB0aGlua2luZyBhbG91ZC4KPgo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KClRoYW5rcywKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==