From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix irq enable tracking in driver
	load
Date: Thu, 04 Sep 2014 16:42:36 +0300
Message-ID: <87tx4nec37.fsf@intel.com>
References: <1409127094-5843-1-git-send-email-daniel.vetter@ffwll.ch>
 <87oauvfxmd.fsf@intel.com> <20140904130501.GL15520@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4C4E16E53E
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Sep 2014 06:42:47 -0700 (PDT)
In-Reply-To: <20140904130501.GL15520@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Oliver Hartkopp <socketcan@hartkopp.net>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 04 Sep 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote:
>> On Wed, 27 Aug 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> > A bunch of warnings fire on some ->irq_postinstall hooks since those
>> > can enable interrupts (e.g. rps interrupts). And then our ordering
>> > self-checks fire and complain.
>> >
>> > To fix that set the tracking boolen before enabling the irqs witho
>> > drm_irq_install. Quoting the discussion with Jesse why that's safe:
>> 
>> Yi Sun's testing result needs to be addressed one way or another before
>> merging this:
>> 
>> http://mid.gmane.org/D9F66AA509623343B6A9A3D4502D5A52112B0676@SHSMSX101.ccr.corp.intel.com
>
> Shrug it off as an unstable test result. Both mine and Jesse's patch
> really only change the logic we use to WARN about interrupt state. We
> don't use pm._irqs_disabled for anything else at all.

Okay, so this is a PITA to review, but at least
ironlake_enable_display_irq will behave differently during
drm_irq_install because of this patch.

Jani.

> Which means that black screen is at most a timing issue. Or the baseline
> kernels don't perfectly match (the new warning in Jesse's patch is a bit
> an indicator for that).
> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center