From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwayE-0002Gu-0P for qemu-devel@nongnu.org; Tue, 09 Jul 2013 12:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwayC-0005HS-W2 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 12:40:53 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:48840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwayC-0005HH-Q6 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 12:40:52 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2013 08:08:20 -0600 From: Anthony Liguori In-Reply-To: <20130708235701.GE2696@voom.redhat.com> References: <1372315560-5478-1-git-send-email-aik@ozlabs.ru> <1372315560-5478-4-git-send-email-aik@ozlabs.ru> <877gh029hi.fsf@codemonkey.ws> <20130708235701.GE2696@voom.redhat.com> Date: Tue, 09 Jul 2013 09:06:21 -0500 Message-ID: <87txk34yle.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Alexey Kardashevskiy , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Paolo Bonzini , Paul Mackerras David Gibson writes: > On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >> > From: David Gibson >> > >> > The vmstate infrastructure includes a VMS_MULTIPY flag, and associated >> > VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a >> > variably sized buffer where the size in bytes of the buffer isn't directly >> > accessible as a structure field, but an element count from which the size >> > can be derived is. >> >> Why? What's the point of sending the total size vs. the element >> count? > > Because it's more convenient to work with the total size at runtime, > and because the VMSTATE stuff works with actual structure fields, > there's not really a way to convert it at migrate time, short of this. The only thing I see using it is the tce array which is broken anyway. Regards, Anthony Liguori > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson