* [PATCH] This patch fix a bug in the register indexing for GPIOs numbers > 31
@ 2011-01-25 8:56 Hirosh Dabui
2011-01-25 16:00 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Hirosh Dabui @ 2011-01-25 8:56 UTC (permalink / raw)
To: linux-arm-kernel
to get the relevant hardware registers of tnetv107x to control the GPIOs.
In the structure tnetv107x_gpio_regs:
struct tnetv107x_gpio_regs {
u32 idver;
u32 data_in[3];
u32 data_out[3];
u32 direction[3];
u32 enable[3];
};
The GPIO hardware register addresses of tnetv107x are stored.
The chip implements 3 registers of each entity to serve 96 GPIOs,
each register provides a subset of 32 GPIOs.
The driver provides these macros: gpio_reg_set_bit, gpio_reg_get_bit
and gpio_reg_clear_bit.
The bug implied the use of macros to access the relevant hardware
register e.g. the driver code used the macro like this:
'gpio_reg_clear_bit(®->data_out, gpio)'
But it has to be used like this:
'gpio_reg_clear_bit(reg->data_out, gpio)'.
The different results are shown here:
- ®->data_out + 1 (it will add the full array size of data_out i.e. 12 bytes)
- reg->data_out + 1 (it will increment only the size of data_out i.e. only 4 bytes)
Acked-by: Cyril Chemparathy <cyril@ti.com>
Signed-off-by: Hirosh Dabui <hirosh.dabui@snom.com>
---
arch/arm/mach-davinci/gpio-tnetv107x.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-davinci/gpio-tnetv107x.c b/arch/arm/mach-davinci/gpio-tnetv107x.c
index d102986..3fa3e28 100644
--- a/arch/arm/mach-davinci/gpio-tnetv107x.c
+++ b/arch/arm/mach-davinci/gpio-tnetv107x.c
@@ -58,7 +58,7 @@ static int tnetv107x_gpio_request(struct gpio_chip *chip, unsigned offset)
spin_lock_irqsave(&ctlr->lock, flags);
- gpio_reg_set_bit(®s->enable, gpio);
+ gpio_reg_set_bit(regs->enable, gpio);
spin_unlock_irqrestore(&ctlr->lock, flags);
@@ -74,7 +74,7 @@ static void tnetv107x_gpio_free(struct gpio_chip *chip, unsigned offset)
spin_lock_irqsave(&ctlr->lock, flags);
- gpio_reg_clear_bit(®s->enable, gpio);
+ gpio_reg_clear_bit(regs->enable, gpio);
spin_unlock_irqrestore(&ctlr->lock, flags);
}
@@ -88,7 +88,7 @@ static int tnetv107x_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
spin_lock_irqsave(&ctlr->lock, flags);
- gpio_reg_set_bit(®s->direction, gpio);
+ gpio_reg_set_bit(regs->direction, gpio);
spin_unlock_irqrestore(&ctlr->lock, flags);
@@ -106,11 +106,11 @@ static int tnetv107x_gpio_dir_out(struct gpio_chip *chip,
spin_lock_irqsave(&ctlr->lock, flags);
if (value)
- gpio_reg_set_bit(®s->data_out, gpio);
+ gpio_reg_set_bit(regs->data_out, gpio);
else
- gpio_reg_clear_bit(®s->data_out, gpio);
+ gpio_reg_clear_bit(regs->data_out, gpio);
- gpio_reg_clear_bit(®s->direction, gpio);
+ gpio_reg_clear_bit(regs->direction, gpio);
spin_unlock_irqrestore(&ctlr->lock, flags);
@@ -124,7 +124,7 @@ static int tnetv107x_gpio_get(struct gpio_chip *chip, unsigned offset)
unsigned gpio = chip->base + offset;
int ret;
- ret = gpio_reg_get_bit(®s->data_in, gpio);
+ ret = gpio_reg_get_bit(regs->data_in, gpio);
return ret ? 1 : 0;
}
@@ -140,9 +140,9 @@ static void tnetv107x_gpio_set(struct gpio_chip *chip,
spin_lock_irqsave(&ctlr->lock, flags);
if (value)
- gpio_reg_set_bit(®s->data_out, gpio);
+ gpio_reg_set_bit(regs->data_out, gpio);
else
- gpio_reg_clear_bit(®s->data_out, gpio);
+ gpio_reg_clear_bit(regs->data_out, gpio);
spin_unlock_irqrestore(&ctlr->lock, flags);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] This patch fix a bug in the register indexing for GPIOs numbers > 31
2011-01-25 8:56 [PATCH] This patch fix a bug in the register indexing for GPIOs numbers > 31 Hirosh Dabui
@ 2011-01-25 16:00 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2011-01-25 16:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi Hirosh,
Hirosh Dabui <hirosh.dabui@snom.com> writes:
> to get the relevant hardware registers of tnetv107x to control the GPIOs.
Your patch/changelog is still messed up. You're missing a good
subject/shortlog and the first line of the changelog has become the
subject/shortlog.
Kevin
> In the structure tnetv107x_gpio_regs:
>
> struct tnetv107x_gpio_regs {
> u32 idver;
> u32 data_in[3];
> u32 data_out[3];
> u32 direction[3];
> u32 enable[3];
> };
>
> The GPIO hardware register addresses of tnetv107x are stored.
> The chip implements 3 registers of each entity to serve 96 GPIOs,
> each register provides a subset of 32 GPIOs.
> The driver provides these macros: gpio_reg_set_bit, gpio_reg_get_bit
> and gpio_reg_clear_bit.
>
> The bug implied the use of macros to access the relevant hardware
> register e.g. the driver code used the macro like this:
> 'gpio_reg_clear_bit(®->data_out, gpio)'
>
> But it has to be used like this:
> 'gpio_reg_clear_bit(reg->data_out, gpio)'.
>
> The different results are shown here:
> - ®->data_out + 1 (it will add the full array size of data_out i.e. 12 bytes)
> - reg->data_out + 1 (it will increment only the size of data_out i.e. only 4 bytes)
>
> Acked-by: Cyril Chemparathy <cyril@ti.com>
> Signed-off-by: Hirosh Dabui <hirosh.dabui@snom.com>
> ---
> arch/arm/mach-davinci/gpio-tnetv107x.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/gpio-tnetv107x.c b/arch/arm/mach-davinci/gpio-tnetv107x.c
> index d102986..3fa3e28 100644
> --- a/arch/arm/mach-davinci/gpio-tnetv107x.c
> +++ b/arch/arm/mach-davinci/gpio-tnetv107x.c
> @@ -58,7 +58,7 @@ static int tnetv107x_gpio_request(struct gpio_chip *chip, unsigned offset)
>
> spin_lock_irqsave(&ctlr->lock, flags);
>
> - gpio_reg_set_bit(®s->enable, gpio);
> + gpio_reg_set_bit(regs->enable, gpio);
>
> spin_unlock_irqrestore(&ctlr->lock, flags);
>
> @@ -74,7 +74,7 @@ static void tnetv107x_gpio_free(struct gpio_chip *chip, unsigned offset)
>
> spin_lock_irqsave(&ctlr->lock, flags);
>
> - gpio_reg_clear_bit(®s->enable, gpio);
> + gpio_reg_clear_bit(regs->enable, gpio);
>
> spin_unlock_irqrestore(&ctlr->lock, flags);
> }
> @@ -88,7 +88,7 @@ static int tnetv107x_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
>
> spin_lock_irqsave(&ctlr->lock, flags);
>
> - gpio_reg_set_bit(®s->direction, gpio);
> + gpio_reg_set_bit(regs->direction, gpio);
>
> spin_unlock_irqrestore(&ctlr->lock, flags);
>
> @@ -106,11 +106,11 @@ static int tnetv107x_gpio_dir_out(struct gpio_chip *chip,
> spin_lock_irqsave(&ctlr->lock, flags);
>
> if (value)
> - gpio_reg_set_bit(®s->data_out, gpio);
> + gpio_reg_set_bit(regs->data_out, gpio);
> else
> - gpio_reg_clear_bit(®s->data_out, gpio);
> + gpio_reg_clear_bit(regs->data_out, gpio);
>
> - gpio_reg_clear_bit(®s->direction, gpio);
> + gpio_reg_clear_bit(regs->direction, gpio);
>
> spin_unlock_irqrestore(&ctlr->lock, flags);
>
> @@ -124,7 +124,7 @@ static int tnetv107x_gpio_get(struct gpio_chip *chip, unsigned offset)
> unsigned gpio = chip->base + offset;
> int ret;
>
> - ret = gpio_reg_get_bit(®s->data_in, gpio);
> + ret = gpio_reg_get_bit(regs->data_in, gpio);
>
> return ret ? 1 : 0;
> }
> @@ -140,9 +140,9 @@ static void tnetv107x_gpio_set(struct gpio_chip *chip,
> spin_lock_irqsave(&ctlr->lock, flags);
>
> if (value)
> - gpio_reg_set_bit(®s->data_out, gpio);
> + gpio_reg_set_bit(regs->data_out, gpio);
> else
> - gpio_reg_clear_bit(®s->data_out, gpio);
> + gpio_reg_clear_bit(regs->data_out, gpio);
>
> spin_unlock_irqrestore(&ctlr->lock, flags);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-25 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 8:56 [PATCH] This patch fix a bug in the register indexing for GPIOs numbers > 31 Hirosh Dabui
2011-01-25 16:00 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.