From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5B1AC4167B for ; Thu, 30 Nov 2023 10:19:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 863CB10E6D2; Thu, 30 Nov 2023 10:19:54 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0001310E6DC for ; Thu, 30 Nov 2023 10:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701339590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wO58wVM0/9bXpJ9VSmAQf3wg6nyduVC421Lit//29no=; b=LJrLRP5qX1svfFon/FmEFIQPVal+Glibo3Bkp2OZIlXTYEkQjr9StAU9euMBm9el2JieBa W9JvRo2QgVBKstPAro2eF5wTqlzDeU18yJWd0w0li9RpBxqNzfIsIAatb/gJhIpbIuc/ID 7iSLFeK2FuObzYG2ipyFFCtBs3K9aNM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-GPxEEG75MMS_WOpqpFtkew-1; Thu, 30 Nov 2023 05:19:49 -0500 X-MC-Unique: GPxEEG75MMS_WOpqpFtkew-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40b3712ef28so5530325e9.2 for ; Thu, 30 Nov 2023 02:19:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339588; x=1701944388; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wO58wVM0/9bXpJ9VSmAQf3wg6nyduVC421Lit//29no=; b=IfccQ962/N/nwmcdnucJwz/KNne2ZivTb36pxdkJGp6+nOK8OCuK5xgscNfSm/DMqp NFR6pSHnJ23kFH096aTevNavdgNlTauPjHLUKHgLzN671VULQgA7iVq4aa9AVbh1NcEU 1QHKDU2B3l6LmkDeUgAfQjJQk4sNzQ1UHvFR5kAzTgJrJLVpXyoVFfqigMRJOPpCMBIr V7o6CzZ9dJlHoX2o09U3X8mXdbqvZukgVrzx7fM/dy2++cbfm03RjhHmj0U42vPJdlZh AtShZfBElH8MAXyPL90MK3IFsZdAABrGVZLHYIOjzwWPG5JaaqBgXCT82etTIkc/WGMa 9dvQ== X-Gm-Message-State: AOJu0YzlV7jeIzM0wqM3rGoL89tpIrBwF+zporK4VdIWG70v89BsnrXl QCdgZD8WTDZJYJTxayK4zuEuq8/Yoq4JtZshcbt76Dl4U0JcAdMPoAU5eybKrAp4RBLUmmYey4j 8SSIwQCJjhz9hPiKOYQM7iXQZCzsD X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr16519977wmf.25.1701339588019; Thu, 30 Nov 2023 02:19:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX77Bh9evkGb0uKx2BzFC3Nw8ErAav4a8jpAMm4IlrO79E7Bg2OPhWwsTzUaMy1NDoqoKrGA== X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr16519962wmf.25.1701339587693; Thu, 30 Nov 2023 02:19:47 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c384f00b0040b35195e54sm1467180wmr.5.2023.11.30.02.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:19:47 -0800 (PST) From: Javier Martinez Canillas To: Maxime Ripard , Jani Nikula Subject: Re: [RFC] drm: enable W=1 warnings by default across the subsystem In-Reply-To: References: <20231129181219.1237887-1-jani.nikula@intel.com> <72248f22-6337-487a-9979-a0d79e37a9ed@amd.com> <874jh362ta.fsf@intel.com> <87zfyva8qg.fsf@minerva.mail-host-address-is-not-set> <87y1ef4lrb.fsf@intel.com> Date: Thu, 30 Nov 2023 11:19:46 +0100 Message-ID: <87v89jo859.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pan@freedesktop.org, Karol Herbst , intel-gfx@lists.freedesktop.org, Xinhui , Abhinav Kumar , dri-devel@lists.freedesktop.org, Nathan Chancellor , Dmitry Baryshkov , Danilo Krummrich , Hamza Mahfooz , Thomas Zimmermann , Alex Deucher , Marijn Suijten , Sean Paul , Christian =?utf-8?Q?K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Maxime Ripard writes: > On Thu, Nov 30, 2023 at 11:46:00AM +0200, Jani Nikula wrote: [...] >> >> Then we'll have a ping pong of people not using W=1 or >> CONFIG_DRM_EXTRA_CHECKS introducing warnings, and people using them >> fixing the warnings... >> >> I really do think making it unconditional is the only way. > > Yeah, I agree. > > Plus, if we need to have an extra Kconfig option, it's pretty equivalent > to using W=1 > Yeah, with the difference that having a Kconfig symbol allows for example distros to set it in their kernel configs. It's a fair point though that probably the only option is to enable it unconditionally. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 875BEC4167B for ; Thu, 30 Nov 2023 10:19:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B35B610E6DC; Thu, 30 Nov 2023 10:19:54 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADF0B10E6D2 for ; Thu, 30 Nov 2023 10:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701339590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wO58wVM0/9bXpJ9VSmAQf3wg6nyduVC421Lit//29no=; b=LJrLRP5qX1svfFon/FmEFIQPVal+Glibo3Bkp2OZIlXTYEkQjr9StAU9euMBm9el2JieBa W9JvRo2QgVBKstPAro2eF5wTqlzDeU18yJWd0w0li9RpBxqNzfIsIAatb/gJhIpbIuc/ID 7iSLFeK2FuObzYG2ipyFFCtBs3K9aNM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-DoWztOPUO2Oin9bt1JCO-Q-1; Thu, 30 Nov 2023 05:19:49 -0500 X-MC-Unique: DoWztOPUO2Oin9bt1JCO-Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40b3712ef28so5530335e9.2 for ; Thu, 30 Nov 2023 02:19:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339588; x=1701944388; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wO58wVM0/9bXpJ9VSmAQf3wg6nyduVC421Lit//29no=; b=xKX08iJNFw8ACDfxSKqod5EprviJRo3m1u7+w4YFr4O9u1rSGVabXII4V6YQvyfQz+ S1Cob9NKBHRLvwUtkRACID2fx2UWW49HYyv+w7h0QA958VfjIUlrN5PqaAIgdIz/WZ05 rd5SCq15k51z5Ayd4+Q00zdwgkTsm0gg27oiziblgXruH7VCTFp6jQYJcm2sUh5qV3j6 Io/Biue+X4rtgUbkT3fyNT4Nx7dDa2IXyZ7B/Bm3NfmsTKCpk4HkSdgc2Ub6UutSxZJz Su+fmThxS9c1jjv+6ncJNyYR8/7MGt0w9bcAzK34aG99NYttNg+bljPP04GYxOkApK5X aUwQ== X-Gm-Message-State: AOJu0YwI/FQuLIvnTSplL0tn0KulpzbciH4eZ7I6zHpPpKRRne0ytWqd 182LP9PslB+ZX2SWAFAxuy2gZEoPnP4IMziVr6mbI+kWFGrCNfloaBST3CA+czKq6rqwPlchkuD bPYeG+rhpNU+UsbCNXG2CoLkBhhMb X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr16519983wmf.25.1701339588022; Thu, 30 Nov 2023 02:19:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX77Bh9evkGb0uKx2BzFC3Nw8ErAav4a8jpAMm4IlrO79E7Bg2OPhWwsTzUaMy1NDoqoKrGA== X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr16519962wmf.25.1701339587693; Thu, 30 Nov 2023 02:19:47 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c384f00b0040b35195e54sm1467180wmr.5.2023.11.30.02.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:19:47 -0800 (PST) From: Javier Martinez Canillas To: Maxime Ripard , Jani Nikula In-Reply-To: References: <20231129181219.1237887-1-jani.nikula@intel.com> <72248f22-6337-487a-9979-a0d79e37a9ed@amd.com> <874jh362ta.fsf@intel.com> <87zfyva8qg.fsf@minerva.mail-host-address-is-not-set> <87y1ef4lrb.fsf@intel.com> Date: Thu, 30 Nov 2023 11:19:46 +0100 Message-ID: <87v89jo859.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pan@freedesktop.org, Karol Herbst , intel-gfx@lists.freedesktop.org, Xinhui , Abhinav Kumar , dri-devel@lists.freedesktop.org, Nathan Chancellor , Dmitry Baryshkov , Danilo Krummrich , Hamza Mahfooz , Thomas Zimmermann , Alex Deucher , Marijn Suijten , Christian =?utf-8?Q?K=C3=B6nig?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Maxime Ripard writes: > On Thu, Nov 30, 2023 at 11:46:00AM +0200, Jani Nikula wrote: [...] >> >> Then we'll have a ping pong of people not using W=1 or >> CONFIG_DRM_EXTRA_CHECKS introducing warnings, and people using them >> fixing the warnings... >> >> I really do think making it unconditional is the only way. > > Yeah, I agree. > > Plus, if we need to have an extra Kconfig option, it's pretty equivalent > to using W=1 > Yeah, with the difference that having a Kconfig symbol allows for example distros to set it in their kernel configs. It's a fair point though that probably the only option is to enable it unconditionally. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat