From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9D37EE57C1 for ; Fri, 8 Sep 2023 04:38:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7010C10E863; Fri, 8 Sep 2023 04:38:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CC0310E863 for ; Fri, 8 Sep 2023 04:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694147936; x=1725683936; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=fs/15MBFHO/a3druxfyoUTEsvuOWFuhMZLZkKnYam/Y=; b=Sp0Cr/N3PktYlQNZWsb9kssdrX+ZW1e4CT28nzP1+y7sYOJwFWjnykNN tK/428q6/e6oNscS5qF+g6LsEPRffG0NR46PpJHJHeXwoqSRM6AlHU0GJ EN3VRh6BJ3xLgcCwlBpW7Sk1g5QuvXNOaSOE17zqIlUGvEW1+fRm4E2ns zcVBMNdTqvCnjHdMwKx5GqYeXmRjgFzNnb7oB0QEtQKczLOy25S33aFTN ZbZxEN/sqQWpmIGdIkw8vGrM3R3zhQBKTJMBoj0NVEutYsYMiPz7vGYnp Ndci6FzXAub1KRfNl8ZYlYIevs+w6U37C9YHPHxpZ200CyiNGuBITEV2A A==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="441575364" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="441575364" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:38:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="857208856" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="857208856" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.97.168]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:38:55 -0700 Date: Thu, 07 Sep 2023 21:38:53 -0700 Message-ID: <87v8clqnxe.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Nerlige Ramappa, Umesh" In-Reply-To: References: <20230808013159.38811-1-ashutosh.dixit@intel.com> <20230808013159.38811-7-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 06/10] drm/xe/oa: Start implementing OA stream open ioctl X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-xe@lists.freedesktop.org" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 23 Aug 2023 12:55:09 -0700, Nerlige Ramappa, Umesh wrote: > Hi Umesh, > On Mon, Aug 07, 2023 at 06:31:55PM -0700, Ashutosh Dixit wrote: > >+/* > >+ * OA timestamp frequency = CS timestamp frequency in most platforms. On some > >+ * platforms OA unit ignores the CTC_SHIFT and the 2 timestamps differ. In such > >+ * cases, return the adjusted CS timestamp frequency to the user. > >+ */ > >+u32 xe_oa_timestamp_frequency(struct xe_device *xe) > > This should ideally be dependent on OA buffer, but the i915 interface > did not have a way to pass that. We should do that in XE. By "dependent on OA buffer" you mean per gt? I have added a new patch making xe_oa_timestamp_frequency per gt so that the changes can be reviewed easily, if needed we can squash the new patch with this one. https://patchwork.freedesktop.org/patch/556307/?series=121084&rev=5 Please review. Thanks. -- Ashutosh