From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A35C43217 for ; Sat, 26 Nov 2022 12:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbiKZMxS (ORCPT ); Sat, 26 Nov 2022 07:53:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiKZMxQ (ORCPT ); Sat, 26 Nov 2022 07:53:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 451FE1A239 for ; Sat, 26 Nov 2022 04:53:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA7C76069A for ; Sat, 26 Nov 2022 12:53:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22832C433C1; Sat, 26 Nov 2022 12:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669467195; bh=0tj611paSClr2KhG41wBuDzLa0tN0B/v8K0CuhNujKo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AX5dqXjgQjTm/Cq3mUq9RGHw44m+sX/k5dh4cZGzc5IcF3srchzOQTW5W0MWY2pCw Ys54M/KyQHFKg8xpcjZDd00sAXYig75AtXsvlJlhEasuloImWB8kjZOv6tzAfnu4rN 1H7HKR22Wm835xctrazxVtCMmcqRd6PaOn26cK1JrrnWyaGeOkslMwzMxXURiAYwdl UGdaW7PVqv31vCiBSJ6/u8HtJ/wAEJTssIxELL+6+gPVtuvAftLzQ3EaMXdcH1QRg/ 0YVCR/OkvPkUDmcmPKWywbixqxutm1Kg3au/SaE06+LpCs6vTpEiak9K5dNpsdI6mp xZZsE6eMSylSg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oyugC-008iLS-QW; Sat, 26 Nov 2022 12:53:12 +0000 Date: Sat, 26 Nov 2022 12:53:04 +0000 Message-ID: <87v8n1ubbj.wl-maz@kernel.org> From: Marc Zyngier To: Tiezhu Yang Cc: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] irqchip: LoongArch: Select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP In-Reply-To: <1666841949-5244-1-git-send-email-yangtiezhu@loongson.cn> References: <1666841949-5244-1-git-send-email-yangtiezhu@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yangtiezhu@loongson.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Oct 2022 04:39:09 +0100, Tiezhu Yang wrote: > > An IRQ's effective affinity can only be different from its configured > affinity if there are multiple CPUs. Make it clear that this option is > only meaningful when SMP is enabled. > > Signed-off-by: Tiezhu Yang > --- > > v2: rebased on 6.1-rc2 > > drivers/irqchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 7ef9f5e..8461915 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -575,7 +575,7 @@ config IRQ_LOONGARCH_CPU > bool > select GENERIC_IRQ_CHIP > select IRQ_DOMAIN > - select GENERIC_IRQ_EFFECTIVE_AFF_MASK > + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP > select LOONGSON_LIOINTC > select LOONGSON_EIOINTC > select LOONGSON_PCH_PIC We already have this: # Supports effective affinity mask config GENERIC_IRQ_EFFECTIVE_AFF_MASK depends on SMP bool Do we really need to express this for every interrupt controller? M. -- Without deviation from the norm, progress is not possible.