From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8689ECAAA1 for ; Fri, 16 Sep 2022 21:47:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6B93D84334; Fri, 16 Sep 2022 21:47:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6B93D84334 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EOJOHuLJFR4V; Fri, 16 Sep 2022 21:47:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 9FDF8842FA; Fri, 16 Sep 2022 21:47:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9FDF8842FA Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4BAF71BF3DA for ; Fri, 16 Sep 2022 21:47:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 31C656FAF6 for ; Fri, 16 Sep 2022 21:47:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 31C656FAF6 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ERggo1Jd0nxS for ; Fri, 16 Sep 2022 21:47:07 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 35E7F6FAD0 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp3.osuosl.org (Postfix) with ESMTPS id 35E7F6FAD0 for ; Fri, 16 Sep 2022 21:47:07 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 997B340005; Fri, 16 Sep 2022 21:47:03 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1oZJAs-008lNC-FW; Fri, 16 Sep 2022 23:47:02 +0200 From: Peter Korsgaard To: Giulio Benetti References: <20220815154854.17628-1-giulio.benetti@benettiengineering.com> <20220815154854.17628-5-giulio.benetti@benettiengineering.com> Date: Fri, 16 Sep 2022 23:47:02 +0200 In-Reply-To: <20220815154854.17628-5-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Mon, 15 Aug 2022 17:48:54 +0200") Message-ID: <87v8pn56w9.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 4/4] Revert "configs/bananapi_m1: use NEON+VFPv4 as FPU strategy" X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luca Ceresoli , Jagan Teki , "Yann E . MORIN" , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Giulio" == Giulio Benetti writes: > The gcc man page states that specifying Neon as part of the fpu setting > has no effect, unless the -funsafe-math-optimizations is also specified, > because Neon is not compliant with IEEE 754: > ``` > If the selected floating-point hardware includes the NEON extension > (e.g. -mfpu=neon), note that floating-point operations are not > generated by GCC's auto-vectorization pass unless > -funsafe-math-optimizations is also specified. This is because NEON > hardware does not fully implement the IEEE 754 standard for > floating-point arithmetic (in particular denormal values are treated > as zero), so the use of NEON instructions may lead to a loss of > precision. > ``` > -funsafe-math-optimizations must be explictly specified per package to > really use NEON as FPU, but it's something that is left to the user as > well as setting BR2_ARM_FPU_NEON_VFPV4. This way the default > BR2_ARM_FPU_VFPV4D16 is used as previously. So let's revert the > offending patch. > This reverts commit aaced92e8c69e3eb71c2cba4c5ae6a1770ae8972. > Signed-off-by: Giulio Benetti Committed to 2022.05.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot