From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09689C433EF for ; Tue, 19 Jul 2022 01:09:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E11DC11A389; Tue, 19 Jul 2022 01:09:28 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2031511A389; Tue, 19 Jul 2022 01:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658192968; x=1689728968; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=4doDKoozIJ8Dhlj7dk1j/WUO+LdV8y0vAgf5A+9PWc8=; b=UPHS/6KU5XK9vShzv0DGGop5WT4KnmHwHvmBfj31WAIpyY7e25KWOZGS njXC7yB2Wsg6DTAtLOemzBR4xtxbhaYlmyRDqr7ncHocRPTcvW1BYAe1N QJQsjWuCRikZpOo1k8zr/EC44w42xVo82CNYqq1/Zo1sIVJ2NBVQ+RKko h54BuZ9w5AKOG6zCzhFD0belPIFaW5J+2KvRyjLjce9yy6sDkfS/y5OU7 y2P5Td485UoWnmvS2Hk+ltGuU1YxOhZTB6DHrLIPE/vu4WPjmaiiqwdfS LUhF8PwQ4PaKd0bl29jDlru3TrdAdlhlGrtY//0GrrmmgNFSy6yVq7ray Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="269380878" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="269380878" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 18:09:27 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="597460086" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.229.53]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 18:09:27 -0700 Date: Mon, 18 Jul 2022 18:09:27 -0700 Message-ID: <87v8rtc3i0.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Roper Subject: Re: [Intel-gfx] [PATCH v2 0/3] drm/i915/gt: Expose per gt defaults in sysfs In-Reply-To: <87o7zapjov.wl-ashutosh.dixit@intel.com> References: <87h7527i59.wl-ashutosh.dixit@intel.com> <87o7zapjov.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Andi Shyti , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 02 Jun 2022 16:55:50 -0700, Matt Roper wrote: > > On Thu, Jun 02, 2022 at 04:36:02PM -0700, Dixit, Ashutosh wrote: > > On Fri, 27 May 2022 16:41:28 -0700, Matt Roper wrote: > > > > > > On Thu, May 26, 2022 at 12:00:42PM -0700, Ashutosh Dixit wrote: > > > > Create a gt/gtN/.defaults directory (similar to > > > > engine//.defaults) to expose default parameter values for each > > > > gt in sysfs. This allows userspace to restore default parameter values > > > > after they may have changed. > > > > > > Drive-by comment: since this is a GT-related change, I think we're > > > required to Cc: dri-devel as well. > > > > Sure. > > > > > And since this is new ABI, we'd need an open source userspace consumer > > > or a very clear explanation why this is an exception to the rule (e.g., > > > if these are meant to be twiddled directly by the user rather than > > > accessed by userspace software). > > > > This series is in response to the following oneAPI requirement ("setting to > > -1 will return the frequency to the factory value"): > > > > https://spec.oneapi.io/level-zero/latest/sysman/api.html?highlight=zesfrequencysetrange#zesfrequencysetrange > > https://spec.oneapi.io/level-zero/latest/sysman/api.html?highlight=zesfrequencysetrange#_CPPv416zes_freq_range_t > > > > So maybe an open-source oneAPI user mode driver will be acceptable > > userspace? So yes not merely to be twiddled just by the user. > > oneapi/l0 is implemented at https://github.com/intel/compute-runtime, > right? I think that should be fine as long as we provide a link to the > actual implementation code that's accessing the new sysfs directory. > Since the userspace code probably won't fully land until after the > kernel change lands, this would be something like a pull request > against their repo that's reviewed and fully-ready to go. I have included a reference to an approved oneAPI/Level-0 UMD pull request in the latest version of this series here: https://patchwork.freedesktop.org/series/106460/ I have also removed sysfs files which are not included in the UMD pull request from the series. Thanks. -- Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67B59C43334 for ; Tue, 19 Jul 2022 01:09:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C90311A3A4; Tue, 19 Jul 2022 01:09:29 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2031511A389; Tue, 19 Jul 2022 01:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658192968; x=1689728968; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=4doDKoozIJ8Dhlj7dk1j/WUO+LdV8y0vAgf5A+9PWc8=; b=UPHS/6KU5XK9vShzv0DGGop5WT4KnmHwHvmBfj31WAIpyY7e25KWOZGS njXC7yB2Wsg6DTAtLOemzBR4xtxbhaYlmyRDqr7ncHocRPTcvW1BYAe1N QJQsjWuCRikZpOo1k8zr/EC44w42xVo82CNYqq1/Zo1sIVJ2NBVQ+RKko h54BuZ9w5AKOG6zCzhFD0belPIFaW5J+2KvRyjLjce9yy6sDkfS/y5OU7 y2P5Td485UoWnmvS2Hk+ltGuU1YxOhZTB6DHrLIPE/vu4WPjmaiiqwdfS LUhF8PwQ4PaKd0bl29jDlru3TrdAdlhlGrtY//0GrrmmgNFSy6yVq7ray Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="269380878" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="269380878" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 18:09:27 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="597460086" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.229.53]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 18:09:27 -0700 Date: Mon, 18 Jul 2022 18:09:27 -0700 Message-ID: <87v8rtc3i0.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Roper In-Reply-To: <87o7zapjov.wl-ashutosh.dixit@intel.com> References: <87h7527i59.wl-ashutosh.dixit@intel.com> <87o7zapjov.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v2 0/3] drm/i915/gt: Expose per gt defaults in sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Andi Shyti , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 02 Jun 2022 16:55:50 -0700, Matt Roper wrote: > > On Thu, Jun 02, 2022 at 04:36:02PM -0700, Dixit, Ashutosh wrote: > > On Fri, 27 May 2022 16:41:28 -0700, Matt Roper wrote: > > > > > > On Thu, May 26, 2022 at 12:00:42PM -0700, Ashutosh Dixit wrote: > > > > Create a gt/gtN/.defaults directory (similar to > > > > engine//.defaults) to expose default parameter values for each > > > > gt in sysfs. This allows userspace to restore default parameter values > > > > after they may have changed. > > > > > > Drive-by comment: since this is a GT-related change, I think we're > > > required to Cc: dri-devel as well. > > > > Sure. > > > > > And since this is new ABI, we'd need an open source userspace consumer > > > or a very clear explanation why this is an exception to the rule (e.g., > > > if these are meant to be twiddled directly by the user rather than > > > accessed by userspace software). > > > > This series is in response to the following oneAPI requirement ("setting to > > -1 will return the frequency to the factory value"): > > > > https://spec.oneapi.io/level-zero/latest/sysman/api.html?highlight=zesfrequencysetrange#zesfrequencysetrange > > https://spec.oneapi.io/level-zero/latest/sysman/api.html?highlight=zesfrequencysetrange#_CPPv416zes_freq_range_t > > > > So maybe an open-source oneAPI user mode driver will be acceptable > > userspace? So yes not merely to be twiddled just by the user. > > oneapi/l0 is implemented at https://github.com/intel/compute-runtime, > right? I think that should be fine as long as we provide a link to the > actual implementation code that's accessing the new sysfs directory. > Since the userspace code probably won't fully land until after the > kernel change lands, this would be something like a pull request > against their repo that's reviewed and fully-ready to go. I have included a reference to an approved oneAPI/Level-0 UMD pull request in the latest version of this series here: https://patchwork.freedesktop.org/series/106460/ I have also removed sysfs files which are not included in the UMD pull request from the series. Thanks. -- Ashutosh