From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736D4C433EF for ; Wed, 13 Jul 2022 07:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231782AbiGMHdA (ORCPT ); Wed, 13 Jul 2022 03:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbiGMHc7 (ORCPT ); Wed, 13 Jul 2022 03:32:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3726E4774 for ; Wed, 13 Jul 2022 00:32:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D23261768 for ; Wed, 13 Jul 2022 07:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24001C34114; Wed, 13 Jul 2022 07:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657697577; bh=UcbUpXspfUdR2zvM5gzzHMfRiMHU4bnakBZL+5BG5H8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZpLFWGEmrbYJTl6EuBALQ0auDpwPBVBTcxR1KvhJfwcoUHXQZoKe66edvY11VtPjE tZ/Yf3kwl1WHjXSErTLegHuZlJJl7cqqDfLFypEjSfj6+LblJQn8H3ZFJJA1r0+C53 N7AkNFaM4X3uzgBArJUQA/CDU2/HTQ/13VPA9ter5SIzmyJ7xDK6oPsIbYvVNk2hNy UAGnOgNsR34j4h/IJW/OqSlfpXuQ14tDTCzySKxnnfMU28ot7X21xrAuq/3IVyR1qP Ed5pfi/jMMbaMnCFgs9I5ci1RmnmtNP7oaTZfdvC2uDrMK8JKIL4sGY6ECZc9TjOBZ EEmK/DYBLfAYw== From: Kalle Valo To: viktor.barna@celeno.com Cc: linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Aviad Brikman , Eliav Farber , Maksym Kokhan , Oleksandr Savchenko , Shay Bar Subject: Re: [RFC v2 03/96] cl8k: add Kconfig References: <20220524113502.1094459-1-viktor.barna@celeno.com> <20220524113502.1094459-4-viktor.barna@celeno.com> Date: Wed, 13 Jul 2022 10:32:53 +0300 In-Reply-To: <20220524113502.1094459-4-viktor.barna@celeno.com> (viktor barna's message of "Tue, 24 May 2022 14:33:29 +0300") Message-ID: <87v8s1mpqy.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org viktor.barna@celeno.com writes: > From: Viktor Barna > > (Part of the split. Please, take a look at the cover letter for more > details). > > Signed-off-by: Viktor Barna I haven't looked at rest of the driver yet, will do that in a later revision. Just looking at build scripts in this round. > --- /dev/null > +++ b/drivers/net/wireless/celeno/cl8k/Kconfig > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +config CL8K > + tristate "Celeno CL8K WLAN support" > + depends on m > + depends on MAC80211 > + help > + This option enables support for Celeno CL8K WLAN. > + Select M (recommended), if you have a wireless module. Why depending on m? Drivers should be able to link to the kernel. > +config CL8K_VERSION > + string "Version" > + depends on CL8K > + default "8.1.x" > + help > + Sets module version, which may be important for FW compatibility > + analysis and syncing upstream codebase with the internal codebase. Johannes already commented on this. > +config CL8K_EEPROM_STM24256 > + bool "EEPROM STM24256 support" > + depends on CL8K > + default n > + help > + Enables EEPROM STM24256 (specific for some of the platforms). Kconfig should not be used for device configuration, ie. the same kernel binary should work on all devices. Is there a better way to detect this runtime? If not, I suggest to drop this in initial submission and submit after the driver is accepted. > +config CL8K_DYN_BCAST_RATE > + bool "Enable dynamic broadcast rate selection" > + depends on CL8K > + default n > + help > + Enables dynamic broadcast rate selection, > + that allows to tune rate of broadcast frames taking into account > + capabilities of all associated stations. I don't think features like this should be in Kconfig. Why not always enable this? > +config CL8K_DYN_MCAST_RATE > + bool "Enable dynamic multicast rate selection" > + depends on CL8K > + default n > + help > + Enables dynamic multicast rate selection, > + that allows to tune rate of multicast frames taking into account > + capabilities of all associated stations. Same with this one. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches