From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED66C433EF for ; Tue, 2 Nov 2021 07:39:46 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8041360EB9 for ; Tue, 2 Nov 2021 07:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8041360EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 33EE640276; Tue, 2 Nov 2021 07:39:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m8wvYGgjCM_N; Tue, 2 Nov 2021 07:39:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9C44A40132; Tue, 2 Nov 2021 07:39:44 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6FCD8C0012; Tue, 2 Nov 2021 07:39:44 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id B3CA3C000E for ; Tue, 2 Nov 2021 07:39:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9ABFC401F6 for ; Tue, 2 Nov 2021 07:39:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u-ORBeJfXZFz for ; Tue, 2 Nov 2021 07:39:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id B184040132 for ; Tue, 2 Nov 2021 07:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635838781; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYJ+rzPHjNuYUW6zXStopClVVMx1ShvzWhMFsee97fE=; b=iGEbYaf/cXKiuvYWLuwkJjj1z7/F2+1vhYl3bs1pEkM3eN9yuMj8b7suMMkN5lIwV1ekru F2aNiytjO1M8okiQ0hMi//e9oDAqq9FW3l2TUOcgCzjXFpdXIWVIySI0+XQQwnssU9zQ5K RxvRwdD7Vk2ayadSJq0cI+SynINKaK8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-dzWo-qkRM7SjhkI9hejj-g-1; Tue, 02 Nov 2021 03:39:40 -0400 X-MC-Unique: dzWo-qkRM7SjhkI9hejj-g-1 Received: by mail-wr1-f69.google.com with SMTP id q7-20020adff507000000b0017d160d35a8so4003201wro.4 for ; Tue, 02 Nov 2021 00:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=rvM+Poc8HmK0BbG3MONenb/GbOeLn0E+m/VzqR43GaU=; b=23E0oxWaXechlDWWKT5jKt5kqfUHd5AaH5mHNLkOBTyd6kWk0IywlouKnLY8yRo0vj wCcHeCABQ2li6fFTpH3vYgTgnhOVvqoVYH31ZzNTpDnHPS0bs82tQbwGdVHgv8GTs69f u7/gRb0qa09tXonT8/mW9KrhSYJWATrTvO0T9QeHDU2s0O3ygBa4vzNpXMfDNsgP8ngz 39l9Usg/haZXloVsGqvHHNx54DJPZqPdO9Th3QCbUI9gm0vNolS2r7FswyykX/SU+hZ8 M2a2VPCQi0e47svMvQOo7YRm40aFlxxLi1B9td07CtdsqoMAm1N/gNpNPAC4MNvK1TY5 cGYA== X-Gm-Message-State: AOAM533XIxiBbOoMd0n+r6CoT5lOgIJDerZrTTPaBlk4UGLxg0r1ce9x Ygkzq6oIwkmBRicTK4K1Sw/H6A0JXJCeBTZUFr4VS8s//QmliVgK0fjPXnesl0L9r9qXzi0kQst d0e7Kx83qErBFpW1snM2RS/fLhM5FggJjBHSwxMqiHA== X-Received: by 2002:a5d:5144:: with SMTP id u4mr38439751wrt.91.1635838779288; Tue, 02 Nov 2021 00:39:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy+z3nFQGpQaDjuMoiWl0dWnpUbkeD+0o1Qxrj5xdUgGO0aNAPyIJ6uswMVBNtDdR+HtpFSg== X-Received: by 2002:a5d:5144:: with SMTP id u4mr38439734wrt.91.1635838779151; Tue, 02 Nov 2021 00:39:39 -0700 (PDT) Received: from localhost ([188.26.219.88]) by smtp.gmail.com with ESMTPSA id e12sm535754wrq.20.2021.11.02.00.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 00:39:38 -0700 (PDT) From: Juan Quintela To: "Michael S. Tsirkin" Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq In-Reply-To: <20211102033023-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 2 Nov 2021 03:32:32 -0400") References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-3-eperezma@redhat.com> <87a6inow7s.fsf@secure.mitica> <20211102033023-mutt-send-email-mst@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 02 Nov 2021 08:39:37 +0100 Message-ID: <87v91bngzq.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , Eugenio =?utf-8?Q?P=C3=A9rez?= , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Eric Blake , virtualization@lists.linux-foundation.org, Parav Pandit X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ik1pY2hhZWwgUy4gVHNpcmtpbiIgPG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiBPbiBUdWUsIE5v diAwMiwgMjAyMSBhdCAwODoyNToyN0FNICswMTAwLCBKdWFuIFF1aW50ZWxhIHdyb3RlOgo+PiBF dWdlbmlvIFDDqXJleiA8ZXBlcmV6bWFAcmVkaGF0LmNvbT4gd3JvdGU6Cj4+ID4gVGhlIC0xIGFz c3VtZXMgdGhhdCBhbGwgZGV2aWNlcyB3aXRoIG5vIGN2cSBoYXZlIGFuIHNwYXJlIHZxIGFsbG9j YXRlZAo+PiA+IGZvciB0aGVtLCBidXQgd2l0aCBubyBvZmZlciBvZiBWSVJUSU9fTkVUX0ZfQ1RS TF9WUS4gVGhpcyBtYXkgbm90IGJlIHRoZQo+PiA+IGNhc2UsIGFuZCB0aGUgZGV2aWNlIG1heSBo YXZlIGEgcGFpciBudW1iZXIgb2YgcXVldWVzLgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXl5eXgo+PiBldmVuCj4+IAo+PiBJIGtub3csIEkga25vdywgSSBhbSBTcGFuaXNo IG15c2VsZiBPOi0pCj4KPiBOb2JvZHkgZXhwZWN0cyB0aGUgU3BhbmlzaCA7KQoKTzotKQoKPj4g aW50IG1haW4odm9pZCkKPj4gewo+PiAJaW50IGkgPSA3Owo+PiAJaSAmPSAtMVVMTDsKPgo+IFN0 ZWZhbm8ncyBwYXRjaCBoYXMgfjFVTEwgLCBub3QgLTFVTEwgaGVyZS4KPgoKU3R1cGlkIGV5ZXMu CgpUaGFua3MsIEp1YW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA587C433EF for ; Tue, 2 Nov 2021 07:41:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6051960E9B for ; Tue, 2 Nov 2021 07:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6051960E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhoPk-00032k-AJ for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 03:41:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhoOZ-00028d-EW for qemu-devel@nongnu.org; Tue, 02 Nov 2021 03:39:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:42936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhoOX-0000dd-BR for qemu-devel@nongnu.org; Tue, 02 Nov 2021 03:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635838781; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYJ+rzPHjNuYUW6zXStopClVVMx1ShvzWhMFsee97fE=; b=iGEbYaf/cXKiuvYWLuwkJjj1z7/F2+1vhYl3bs1pEkM3eN9yuMj8b7suMMkN5lIwV1ekru F2aNiytjO1M8okiQ0hMi//e9oDAqq9FW3l2TUOcgCzjXFpdXIWVIySI0+XQQwnssU9zQ5K RxvRwdD7Vk2ayadSJq0cI+SynINKaK8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-ft7f9AdvN4iotTNSUfzbEg-1; Tue, 02 Nov 2021 03:39:40 -0400 X-MC-Unique: ft7f9AdvN4iotTNSUfzbEg-1 Received: by mail-wm1-f69.google.com with SMTP id y9-20020a1c7d09000000b003316e18949bso3747840wmc.5 for ; Tue, 02 Nov 2021 00:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=rvM+Poc8HmK0BbG3MONenb/GbOeLn0E+m/VzqR43GaU=; b=yOpasLXpG2UymS6ikq5EdNz8wVyoQS3IFySZlr0Jr2tyJsutRxrIGaNsfBGfNvizDC 4uDOrGXDlCBXkdptcvVL+1o2ReD0+W3KwJuTln4ohCQWcBkUGCmNfJjut2VU/3dux2lv tkh9hCp11D0CQCPibMr/Tb3EiDYBUVBisJQXrw57dXnTdV750V1cRXv8N3ugMF/sXHEN XvF/n0W9KDpp1di5lF/JtDBLm2RSYrPWHIV4lsyXTmdO/E3SOBuvBehixZACREkf6LLm ihU6yp9CV11RoBt9Tmh9AcMatMVercSQQWVxPhcu4Ph0ld7wdbMAoADntYaIgfchgjut 6zSw== X-Gm-Message-State: AOAM533X1L/mtTfR8g0yktG21xx4toCKY2EKzyxhOfG1dBQRpc3Mh+EH v/DSv3LE8j3WPnGrPSZKGO9cdDtm2ToVUr8/1Goz0JpehnVcPgr/SibGaEViyjX5Vdm0C/m4mzZ ff3A0TtnxOwlmlnI= X-Received: by 2002:a5d:5144:: with SMTP id u4mr38439771wrt.91.1635838779357; Tue, 02 Nov 2021 00:39:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy+z3nFQGpQaDjuMoiWl0dWnpUbkeD+0o1Qxrj5xdUgGO0aNAPyIJ6uswMVBNtDdR+HtpFSg== X-Received: by 2002:a5d:5144:: with SMTP id u4mr38439734wrt.91.1635838779151; Tue, 02 Nov 2021 00:39:39 -0700 (PDT) Received: from localhost ([188.26.219.88]) by smtp.gmail.com with ESMTPSA id e12sm535754wrq.20.2021.11.02.00.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 00:39:38 -0700 (PDT) From: Juan Quintela To: "Michael S. Tsirkin" Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq In-Reply-To: <20211102033023-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 2 Nov 2021 03:32:32 -0400") References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-3-eperezma@redhat.com> <87a6inow7s.fsf@secure.mitica> <20211102033023-mutt-send-email-mst@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 02 Nov 2021 08:39:37 +0100 Message-ID: <87v91bngzq.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.734, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Laurent Vivier , Eduardo Habkost , Jason Wang , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , Markus Armbruster , Eugenio =?utf-8?Q?P=C3=A9rez?= , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Stefano Garzarella , Eric Blake , virtualization@lists.linux-foundation.org, Parav Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Michael S. Tsirkin" wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio P=C3=A9rez wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be t= he >> > case, and the device may have a pair number of queues. >> ^^^^ >> even >>=20 >> I know, I know, I am Spanish myself O:-) > > Nobody expects the Spanish ;) O:-) >> int main(void) >> { >> =09int i =3D 7; >> =09i &=3D -1ULL; > > Stefano's patch has ~1ULL , not -1ULL here. > Stupid eyes. Thanks, Juan.