From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70351C4320A for ; Thu, 5 Aug 2021 09:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5960E6104F for ; Thu, 5 Aug 2021 09:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238799AbhHEJC7 (ORCPT ); Thu, 5 Aug 2021 05:02:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:60302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232517AbhHEJC6 (ORCPT ); Thu, 5 Aug 2021 05:02:58 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BDF260E8D; Thu, 5 Aug 2021 09:02:44 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mBZH0-0035ot-DT; Thu, 05 Aug 2021 10:02:42 +0100 Date: Thu, 05 Aug 2021 10:02:41 +0100 Message-ID: <87v94kb6xa.wl-maz@kernel.org> From: Marc Zyngier To: Saravana Kannan Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/3] Clean up and fix error handling in mdio_mux_init() In-Reply-To: <20210804214333.927985-1-saravanak@google.com> References: <20210804214333.927985-1-saravanak@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: saravanak@google.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, narmstrong@baylibre.com, khilman@baylibre.com, kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, On Wed, 04 Aug 2021 22:43:29 +0100, Saravana Kannan wrote: > > This patch series was started due to -EPROBE_DEFER not being handled > correctly in mdio_mux_init() and causing issues [1]. While at it, I also > did some more error handling fixes and clean ups. The -EPROBE_DEFER fix is > the last patch. > > Ideally, in the last patch we'd treat any error similar to -EPROBE_DEFER > but I'm not sure if it'll break any board/platforms where some child > mdiobus never successfully registers. If we treated all errors similar to > -EPROBE_DEFER, then none of the child mdiobus will work and that might be a > regression. If people are sure this is not a real case, then I can fix up > the last patch to always fail the entire mdio-mux init if any of the child > mdiobus registration fails. > > Cc: Marc Zyngier > Cc: Neil Armstrong > Cc: Kevin Hilman > [1] - https://lore.kernel.org/lkml/CAGETcx95kHrv8wA-O+-JtfH7H9biJEGJtijuPVN0V5dUKUAB3A@mail.gmail.com/#t > > Saravana Kannan (3): > net: mdio-mux: Delete unnecessary devm_kfree > net: mdio-mux: Don't ignore memory allocation errors > net: mdio-mux: Handle -EPROBE_DEFER correctly > > drivers/net/mdio/mdio-mux.c | 37 ++++++++++++++++++++++++------------- > 1 file changed, 24 insertions(+), 13 deletions(-) Thanks for this. I've just gave it a go on my test platform, and this indeed addresses the issues I was seeing [1]. Acked-by: Marc Zyngier Tested-by: Marc Zyngier M. [1] https://lore.kernel.org/r/87im0m277h.wl-maz@kernel.org -- Without deviation from the norm, progress is not possible.